[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905054#comment-16905054 ] Jacques Le Roux commented on OFBIZ-10817: - No worries, you were in vacation :) > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905031#comment-16905031 ] Mathieu Lirzin commented on OFBIZ-10817: Sorry for the delay > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901333#comment-16901333 ] Jacques Le Roux commented on OFBIZ-10817: - OK, Nicolas told me that Mathieu is in vacation :) > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900815#comment-16900815 ] Jacques Le Roux commented on OFBIZ-10817: - Hi Mathieu, Is there a reason why you don't commit this patch apart that it does not apply anymore? > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898890#comment-16898890 ] Nicolas Malin commented on OFBIZ-10817: --- +1 > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898886#comment-16898886 ] Jacques Le Roux commented on OFBIZ-10817: - Hi [~mthl], Could you please commit this patch in order for this issue to be closed and the Resolved resolution being removed: https://markmail.org/message/idneym4rihyp4sbn Thanks! > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859228#comment-16859228 ] Mathieu Lirzin commented on OFBIZ-10817: Lambda expressions are not meant to be stored inside variables. In most cases it is better to define a static method and use a method reference instead. Static methods have the benefits of having a more explicit signature and some javadoc attached to them. I have included [^OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch] which is rewriting current implementing to use method references. If nobody disagrees I will commit the patch in a couple of days. > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857309#comment-16857309 ] Deepak Dixit commented on OFBIZ-10817: -- Added Debug.logError in OFBIZ_DEFAULT_HANDLER at r#1860696 It will be helpful for debugging. > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[
https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811523#comment-16811523
]
Jacques Le Roux commented on OFBIZ-10817:
-
Thanks Nicolas,
Your example works!
Actually you don't need a patch simply remove a # in (for instance) product
Main.ftl. You will see that in this case (same for main.ftl in ecommerce, etc.
I guess) there is no stack trace OOTB.
If you use the above widget .properties setting, to be clear I copy mine :):
{noformat}
Index: widget.properties
===
--- widget.properties (revision 1857048)
+++ widget.properties (working copy)
@@ -25,7 +25,7 @@
# overridden in an application's web.xml file or in the screen rendering
context.
# A setting of false will override all other settings and disable all widget
# boundary comments.
-widget.verbose=true
+widget.verbose=false
# Default number of items to be displayed per page in a list form
widget.form.defaultViewSize=20
@@ -48,4 +48,4 @@
# When you don't displaying freemarker stacktrace, you can replace it by an
other message
# by default it use ∎ but you can set what you want, like 'ERROR', '##' or ' '
-#widget.freemarker.template.exception.message=
+widget.freemarker.template.exception.message=ERROR ERROR ERROR
{noformat}
and get to product component you will see no "ERROR ERROR ERROR" but the same
error than OOTB, ie:
{noformat}
Catalog Administration Main Page
Error rendering included template at location
[component://product/template/Main.ftl]: freemarker.core.ParseException: Syntax
error in template "component://product/template/Main.ftl" in line 23, column 1:
Unexpected directive, "". Check if you have a valid #if-#elseif-#else
structure.{noformat}
> Configure stackTrace displaying on ftl rendering
>
>
> Key: OFBIZ-10817
> URL: https://issues.apache.org/jira/browse/OFBIZ-10817
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch,
> OFBIZ-10817.patch, OFBIZ-10817.patch, Sélection_236.png, Sélection_237.png
>
>
> Currently when freemarker failed to execute a template, you have on end
> screen rendered all java stack trace generate.
> I propose to improve this to display the stack trace only when the property
> widget.verbose is true, no regression during development and when you switch
> to production site, in general your widget.verbose is false so end user
> haven't stack trace (that totally unused for them).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810668#comment-16810668 ] Jacques Le Roux commented on OFBIZ-10817: - I tried again putting an error in ecommerce main.ftl and by default I only see the stack trace in log. It's the same when I set widget.verbose=false. Also I just noticed that showjGrowl() is the one that shows the error message with no stack trace in both cases... Same when breaking main.ftl in product but w/o showjGrowl()... Also I don't see any difference when I set widget.freemarker.template.verbose=true And when I set widget.freemarker.template.exception.message=ERROR ERROR ERROR I don't see "ERROR ERROR ERROR" but the std error message Error rendering included template at location [component://product/template/Main.ftl]: freemarker.core.ParseException: Syntax error in template "component://product/template/Main.ftl" in line 23, column 1: Unexpected directive, "". Check if you have a valid #if-#elseif-#else structure. > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[
https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810111#comment-16810111
]
Jacques Le Roux commented on OFBIZ-10817:
-
Hi Nicolas,
I'm not sure what I miss (did not dig in code), but here is my quick experience.
# Put an error in themes/rainbowstone/template/includes/Footer.ftl:
{{<#include "ofbizhome://VERSION" ignore_missing=true/>}}
# Get to https://localhost:8443/webtools/control/FindUtilCache w/ default
values
I see an error saying:
{{Error rendering included template at location
[component://rainbowstone/template/includes/Footer.ftl]}} (2 lines)
But no stack trace, only in log
Then using the properties in widget.properties has no effect. Could I have an
example with a stack trace? Thanks!
> Configure stackTrace displaying on ftl rendering
>
>
> Key: OFBIZ-10817
> URL: https://issues.apache.org/jira/browse/OFBIZ-10817
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch,
> OFBIZ-10817.patch, OFBIZ-10817.patch
>
>
> Currently when freemarker failed to execute a template, you have on end
> screen rendered all java stack trace generate.
> I propose to improve this to display the stack trace only when the property
> widget.verbose is true, no regression during development and when you switch
> to production site, in general your widget.verbose is false so end user
> haven't stack trace (that totally unused for them).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804716#comment-16804716 ] Jacques Le Roux commented on OFBIZ-10817: - I did not test yet, but it sounds possible to me. I'll test next week... > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804694#comment-16804694 ] Nicolas Malin commented on OFBIZ-10817: --- I commited it on trunk at 1856524 I propose to backport also on 18.12 because it's simple improvement and interesting for end user > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799609#comment-16799609 ] Nicolas Malin commented on OFBIZ-10817: --- It's just for testing, will commit only the java source and commented properties > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[
https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799606#comment-16799606
]
Jacques Le Roux commented on OFBIZ-10817:
-
Hi Nicolas,
Are we sure we want to set {{widget.verbose=false}} as default? Is it necessary
or?
> Configure stackTrace displaying on ftl rendering
>
>
> Key: OFBIZ-10817
> URL: https://issues.apache.org/jira/browse/OFBIZ-10817
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch,
> OFBIZ-10817.patch, OFBIZ-10817.patch
>
>
> Currently when freemarker failed to execute a template, you have on end
> screen rendered all java stack trace generate.
> I propose to improve this to display the stack trace only when the property
> widget.verbose is true, no regression during development and when you switch
> to production site, in general your widget.verbose is false so end user
> haven't stack trace (that totally unused for them).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799604#comment-16799604 ] Nicolas Malin commented on OFBIZ-10817: --- I will finish this issue :) Thanks for your message, I update the patch[^OFBIZ-10817.patch] with adding two properties : * widget.freemarker.template.verbose : if you want for the exception displaying * widget.freemarker.template.exception.message :if you want edit your stacktrace string replacement [~mthl] I agree it would be better to improve the design, currently I have no time to refund it (other priority issue :) ) and I prefer make a simple step to escape the bad case that you send an pdf order with twenty page of ftl stacktrace to the end user due to infra issue. [~mbrohl] I implement your idea, just by property and direct display configuration (no use flexible expander or context analysis) to start. I can't use EntityUtilProperties easly without delegator. So ... first operational step as goal. For your second suggest, I prefer to dedicate this part to log4j by production site configuration. > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753399#comment-16753399 ] Michael Brohl commented on OFBIZ-10817: --- I think it is a good idea to have simething more user-friendly in production instead of displaying the full stacktrace. I also agree that it is no good idea to simply hide it completely. It would be better to display a configurable nice error page or page snippet with a general error message and a hint to inform the administrator. In an extended version, maybe with the option to send a message to a configured admin address? > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749600#comment-16749600 ] Jacques Le Roux commented on OFBIZ-10817: - I can't really see what it renders (actually no time to check) but I trust you, thanks Nicolas > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749069#comment-16749069 ] Nicolas Malin commented on OFBIZ-10817: --- [~deepak.dixit], [~jacques.le.roux] thanks for your comments :) , I created this issue quickly to didn't lost the code and idea from Grégoire Fruleux on old ofbiz version. I updated the patch correctly with trunk and your remarks. to display something on error I choose the unicode "∎" [^OFBIZ-10817.patch] > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748471#comment-16748471 ] Jacques Le Roux commented on OFBIZ-10817: - Hi Nicolas, I find the idea good, but could we not at least show a small message to the user saying there was a problem? > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748386#comment-16748386 ] Deepak Dixit commented on OFBIZ-10817: -- I like the idea, One small suggestion: Can we use ModelWidget.widgetBoundaryCommentsEnabled method instead of just getting widget.verbose from properties files? > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
