[jira] [Commented] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’
[
https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837929#comment-16837929
]
Mathieu Lirzin commented on OFBIZ-11019:
After a deeper look at the {{security}} interface it seems that every method
signature referencing {{HttpSession}} should be deprecated and replaced by a
static helper method like what is done for
{{hasPermission(String,HttpSession)}} as a consequence I will provide extra
patches for that.
> Removing ‘hasPermission(String, HttpSession)’ from ‘Security’
> -
>
> Key: OFBIZ-11019
> URL: https://issues.apache.org/jira/browse/OFBIZ-11019
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch
>
>
> The ‘hasPermission(String, HttpSession)’ method declaration from the
> ‘Security’ interface is breaking the minimality principle of interfaces
> because it is easily expressible in term of ‘hasPermission(String,
> GenericEntity)’. As a consequence a static helper method should be
> implemented to achieve same convenience without polluting the ‘Security’
> interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837367#comment-16837367 ] Mathieu Lirzin commented on OFBIZ-11019: I have included [^OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch] which fixes that minimality issue. > Removing ‘hasPermission(String, HttpSession)’ from ‘Security’ > - > > Key: OFBIZ-11019 > URL: https://issues.apache.org/jira/browse/OFBIZ-11019 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: > OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch > > > The ‘hasPermission(String, HttpSession)’ method declaration from the > ‘Security’ interface is breaking the minimality principle of interfaces > because it is easily expressible in term of ‘hasPermission(String, > GenericEntity)’. As a consequence a static helper method should be > implemented to achieve same convenience without polluting the ‘Security’ > interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
