[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099671#comment-17099671 ] Pierre Smits commented on OFBIZ-11024: -- Thanks [~pawan] and other for your assistance to get this into the repo > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pawan Verma >Priority: Major > Labels: invoice, purchase, supplier > Fix For: Upcoming Branch > > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099648#comment-17099648 ] ASF subversion and git services commented on OFBIZ-11024: - Commit adb60c2a9efb87d2a96b363a9a2207ed4cc06e61 in ofbiz-framework's branch refs/heads/trunk from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=adb60c2 ] Improved: Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER (OFBIZ-11024) Added new LookupSupplier and used it. Thanks: Pierre, Rohit, Jacques, Nicolas for your contribution. > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pawan Verma >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044183#comment-17044183 ] Pierre Smits commented on OFBIZ-11024: -- Hi [~pawan], [~rohit.hukkeri] It was good back when I tested it. And the suggest change wasn't a blocker for implementing it. Met vriendelijke groet, Pierre > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pawan Verma >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044141#comment-17044141 ] Pawan Verma commented on OFBIZ-11024: - Hi [~pierresmits] [~nmalin] Are we good with the patch suggested by [~rohit.hukkeri]. Could you please review when you get some time? :) > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pawan Verma >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938548#comment-16938548 ] Rohit Hukkeri commented on OFBIZ-11024: --- Hello Pierre, Nicolas I have updated the patch with the term 'LookupSupplier' in place of 'LookupSupplierName'. Thanks! > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Rohit Hukkeri >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917714#comment-16917714 ] Rohit Hukkeri commented on OFBIZ-11024: --- Hi Nicolas Malin, IMO in such case, the organization need to set the parent type = Supplier then only we will get all the parties linked to a SUPPLIER role. This should leave upon business-specific requirement rather than doing it generic to manage all supplier case. Thanks! > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Rohit Hukkeri >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915590#comment-16915590 ] Nicolas Malin commented on OFBIZ-11024: --- Hello, just a remark, a supplier isn't only parties linked to SUPPPLIER role but all parties linked to a child SUPPLIER role. With this, your lookup would be more generic to manage all supplier case. > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Rohit Hukkeri >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915588#comment-16915588 ] Jacques Le Roux commented on OFBIZ-11024: - Thanks Pierre > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Rohit Hukkeri >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915564#comment-16915564 ] Pierre Smits commented on OFBIZ-11024: -- Hi [~rohit.hukkeri], I have reviewed your patch, and tested it in a local test environment (see [1]). In both test setups the provided patch performed in accordance with expectations. One minor observation: you're using the term 'LookupSupplierName'. I guess this is inline with other variants, but it is not about looking up the name of the supplier, but just the appropriate supplier(s) using a.o. names. Hence a better solution would be to use just LookupSupplier (e.g. to remove potential confusion). [1] tests * against trunk * against r17.12 > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Rohit Hukkeri >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915177#comment-16915177 ] Jacques Le Roux commented on OFBIZ-11024: - Hi Pierre, could you please confirm it's OK with you? > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Rohit Hukkeri >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11024) Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
[ https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914916#comment-16914916 ] Rohit Hukkeri commented on OFBIZ-11024: --- Hello Pierre, The issue has been resolved now and the patch is available here. This also resolves the issue raised in OFBIZ-11025 hence both the tickets need to get closed. Thanks > Purchase Invoice creation should be limited for parties with roleTypeId = > SUPPLIER > -- > > Key: OFBIZ-11024 > URL: https://issues.apache.org/jira/browse/OFBIZ-11024 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Rohit Hukkeri >Priority: Major > Labels: invoice, purchase, supplier > Attachments: OFBIZ_11024.patch > > > Currently in the invoice creation process in accounting regarding purchase > invoices, all parties can be selected as the invoice from party. This should > be limited to parties with roleTypeId=SUPPLIER -- This message was sent by Atlassian Jira (v8.3.2#803003)
