[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-16 Thread Denglong Zhou (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841228#comment-16841228 ] Denglong Zhou commented on OFBIZ-11029: --- Thanks you all for the quick fix, great team! > Issue in

[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840021#comment-16840021 ] Aditya Sharma commented on OFBIZ-11029: --- Thanks Denglong Zhou for reporting the issue, Pawan Verma

[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839743#comment-16839743 ] Jacques Le Roux commented on OFBIZ-11029: - Thanks Pawan, Your patch looks good to me too :) >

[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839737#comment-16839737 ] Jacques Le Roux commented on OFBIZ-11029: - Thanks Aditya for changing the affected versions.

[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839223#comment-16839223 ] Suraj Khurana commented on OFBIZ-11029: --- +1. Patch looks good to me. > Issue in function

[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Pawan Verma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839209#comment-16839209 ] Pawan Verma commented on OFBIZ-11029: - Nice Catch, Yes it should beĀ isVirtual instead of productId.