[jira] [Commented] (OFBIZ-11070) Refactor EntityDataLoadContainer
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859287#comment-16859287 ] Jacques Le Roux commented on OFBIZ-11070: - Thanks Mathieu, Bisect is one of the tools that makes Git apart. Will you close this issue as is or will your fix the problem you crossed before? > Refactor EntityDataLoadContainer > > > Key: OFBIZ-11070 > URL: https://issues.apache.org/jira/browse/OFBIZ-11070 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch, > OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch, > OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch, > OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11070) Refactor EntityDataLoadContainer
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859231#comment-16859231 ] Mathieu Lirzin commented on OFBIZ-11070: After bisecting I identified that the revision 1860063 corresponding to [^OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch] was the root cause for the regression. As a consequence I am reapplying the other patches which are not concerned with the regression. > Refactor EntityDataLoadContainer > > > Key: OFBIZ-11070 > URL: https://issues.apache.org/jira/browse/OFBIZ-11070 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch, > OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch, > OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch, > OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11070) Refactor EntityDataLoadContainer
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848765#comment-16848765 ] Jacques Le Roux commented on OFBIZ-11070: - Hi Mathieu, There was [something wrong with these changes|https://markmail.org/message/i3r5pr74cibh47be], I reverted at revision: 1860113. Please check and fix, thanks. > Refactor EntityDataLoadContainer > > > Key: OFBIZ-11070 > URL: https://issues.apache.org/jira/browse/OFBIZ-11070 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch, > OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch, > OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch, > OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)