[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420815#comment-17420815 ] ASF subversion and git services commented on OFBIZ-0: - Commit 7cc848cfabcdb16352d953edb2cbc8ca4a60973e in ofbiz-framework's branch refs/heads/release18.12 from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7cc848c ] Improved: Mandatory contact number when create/update a TelecumNumber (OFBIZ-0) It's possible that create a Telecum number without contactNumber that appears as an inconsistency. Thanks: Rashi Dhagat for this issue > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Nicolas Malin >Priority: Major > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420801#comment-17420801 ] ASF subversion and git services commented on OFBIZ-0: - Commit be5f6aef7618799716029b355381a3060edeb53c in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=be5f6ae ] Improved: Mandatory contact number when create/update a TelecumNumber (OFBIZ-0) It's possible that create a Telecum number without contactNumber that appears as an inconsistency. Thanks: Rashi Dhagat for this issue > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420576#comment-17420576 ] Jacques Le Roux commented on OFBIZ-0: - Yes thanks Nicolas, please do so > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420573#comment-17420573 ] Nicolas Malin commented on OFBIZ-0: --- I propose to move this issue as an improvement, and merge it on 18 and trunk. If some people are an actual case to empty a vital information ... all issue are welcome :) Jacques I can take the lead to push it if you want > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283291#comment-17283291 ] Jacques Le Roux commented on OFBIZ-0: - Yes, it could be an improvement where we would remove all contact mech types but Postal Address, Phone Number and Email Address... Not sure another Jira is necessary, but maybe clearer... > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283165#comment-17283165 ] Michael Brohl commented on OFBIZ-0: --- [~jleroux] [~pawan] is this really to be classified as a bug? I do not see a problem to add an empty telecom number (or wipe an existing one). It would be a bug if the empty number breaks some other functionality but this is not reported. What do you think? > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870862#comment-16870862 ] Pawan Verma commented on OFBIZ-0: - I think, we should be able to generate this issue in Trunk and other branches also. We should also check it once and if this exists please update the Affects Version/s. > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Priority: Major > Attachments: OFBIZ-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870259#comment-16870259 ] Pierre Smits commented on OFBIZ-0: -- Should we not work towards a solution that when no contact type has been selected that a default is set? > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Priority: Major > Attachments: HC-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number
[ https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870242#comment-16870242 ] Pradeep Choudhary commented on OFBIZ-0: --- Overrided 'contactNumber' field in 'updatePartyTelecomNumber' and 'updateTelecomNumber' service and marked optional="false". It will validate the empty contact number values and prevent user to add empty values for Telecom Number form. Added patch for the same. > Able to add phone no. as contact type without adding number > --- > > Key: OFBIZ-0 > URL: https://issues.apache.org/jira/browse/OFBIZ-0 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Pradeep Choudhary >Priority: Major > Attachments: HC-0.patch > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select phone no as contact type > # Click on Create > # Click on Save > Actual: Able to add phone no as contact type without adding no. > Expected: Error message should be displayed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
