[jira] [Commented] (OFBIZ-11311) Themes documentation migration from md to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042674#comment-17042674 ] ASF subversion and git services commented on OFBIZ-11311: - Commit 241d49d903eab5d8076a66b003abe2b4d0442ef6 in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=241d49d ] Documented: Themes documentation migration from md to asciidoc (OFBIZ-11311) Thanks Olivier Heintz for reporting and providing the patch. > Themes documentation migration from md to asciidoc > -- > > Key: OFBIZ-11311 > URL: https://issues.apache.org/jira/browse/OFBIZ-11311 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-11311.patch, themes.adoc > > > Include Themes documentation in developper-manual, so > * I have migrates README.md from themes directory to themes.adoc > * add a include line in developper-manual > > As this documentation is about themes (a directory in ofbiz root) I have'nt > created a doc/documentation directory in the themes directory but only put > file at the same place than the previous README.md -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11311) Themes documentation migration from md to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000895#comment-17000895 ] Mathieu Lirzin commented on OFBIZ-11311: I find that this is a great idea to homogenize the documentation format and location. I am not a fan of the current practice of spreading included documentation files into components directories but that's another topic so +1 If you are willing to continue to work on that a nice next step would be to migrate the $COMPONENT/documents/*.xml files into asciidoc. > Themes documentation migration from md to asciidoc > -- > > Key: OFBIZ-11311 > URL: https://issues.apache.org/jira/browse/OFBIZ-11311 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: OFBIZ-11311.patch, themes.adoc > > > Include Themes documentation in developper-manual, so > * I have migrates README.md from themes directory to themes.adoc > * add a include line in developper-manual > > As this documentation is about themes (a directory in ofbiz root) I have'nt > created a doc/documentation directory in the themes directory but only put > file at the same place than the previous README.md -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11311) Themes documentation migration from md to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000777#comment-17000777 ] Jacques Le Roux commented on OFBIZ-11311: - Thanks Olivier, I compared the 2 rendered files and it looks good to me: +1 > Themes documentation migration from md to asciidoc > -- > > Key: OFBIZ-11311 > URL: https://issues.apache.org/jira/browse/OFBIZ-11311 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: OFBIZ-11311.patch, themes.adoc > > > Include Themes documentation in developper-manual, so > * I have migrates README.md from themes directory to themes.adoc > * add a include line in developper-manual > > As this documentation is about themes (a directory in ofbiz root) I have'nt > created a doc/documentation directory in the themes directory but only put > file at the same place than the previous README.md -- This message was sent by Atlassian Jira (v8.3.4#803005)
