[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037506#comment-17037506
]
ASF subversion and git services commented on OFBIZ-11317:
-
Commit 969f48b7c9f692b8a6f1c54e2b4ce6ae1392961b in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=969f48b ]
Fixed: Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
(OFBIZ-11317)
In some place, like at least themes/tomahawk/template/AppBarClose.ftl the CSRF
token is not generated. Because in those places OfbizUrlTransform is used.
An immediate solution is to add the CSRF token generation in OfbizUrlTransform
class.
A definitive solution is to complete OFBIZ-11229
"Merge UrlRegexpTransform and OfbizUrlTransform classes"
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035989#comment-17035989
]
Jacques Le Roux commented on OFBIZ-11317:
-
Right Pierre, fixed
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035983#comment-17035983
]
Pierre Smits commented on OFBIZ-11317:
--
I guess you mean OFBIZ-11306, as shown in the links of this ticket.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035373#comment-17035373
]
Pierre Smits commented on OFBIZ-11317:
--
IMO, it does not bite current release branches. And it would be beneficial to
have it in now, than wait another number of years
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035371#comment-17035371
]
Jacques Le Roux commented on OFBIZ-11317:
-
Pierre,
About your:
bq. Shouldn't we consider this issue for back porting to active release
branches?
I think so indeed, because even if OFBIZ-11306 does not directly depent upon
it, it's safer to have been backported with it. This should though be discussed
on dev ML to get a consensus about that.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035345#comment-17035345
]
Jacques Le Roux commented on OFBIZ-11317:
-
Quoting from Slack
{quote}
Maybe I should not have pushed to all branches but only trunk. I'll try that
next time
I have checked this feature to push together R17 and R18 when backporting
So we need to delete the ‘refs/pull/13/head’ from remote, right?
Pierre Smits [13 h 47]
That appears to be the way to go.
Jacques Le Roux [13 h 50]
Done, how it goes on your side?
Both local and remote deleted
Pierre Smits [13 h 51]
Let me check.
It seems ok now (and again). I see all available (and implemented PR) branches.
As it should be.
13 h 56
OK, I guess it was the push ALL which created the issue
{quote}
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035313#comment-17035313
]
Pierre Smits commented on OFBIZ-11317:
--
Apparently not Because now I get this:
{code:java}
git --no-optional-locks -c color.branch=false -c color.diff=false -c
color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c
credential.helper=sourcetree fetch --prune OFBiz
fatal: Cannot fetch both refs/pull/13/head and refs/heads/pr/13 to
refs/remotes/OFBiz/pr/13
Completed with errors, see above
{code}
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035311#comment-17035311
]
Jacques Le Roux commented on OFBIZ-11317:
-
I wonder why we have 2 commits when I only made one, but seems OK
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035290#comment-17035290
]
Pierre Smits commented on OFBIZ-11317:
--
Shouldn't we consider this issue for back porting to active release branches?
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035282#comment-17035282
]
ASF subversion and git services commented on OFBIZ-11317:
-
Commit e1e1a4813d05f236ea851c729d3b01f5c2ff44a4 in ofbiz-framework's branch
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e1e1a48 ]
Implemented: Add 'controlPath' attribute
(OFBIZ-11317)
added: Missed aspected in header.ftl in bluelight theme
(cherry picked from commit ae98498701a8c5e28e9b58af0bb3b64c4d2e511a)
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035283#comment-17035283
]
ASF subversion and git services commented on OFBIZ-11317:
-
Commit ae98498701a8c5e28e9b58af0bb3b64c4d2e511a in ofbiz-framework's branch
refs/heads/pr/13 from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ae98498 ]
Implemented: Add 'controlPath' attribute
(OFBIZ-11317)
added: Missed aspected in header.ftl in bluelight theme
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034411#comment-17034411
]
Pierre Smits commented on OFBIZ-11317:
--
You're welcome.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034408#comment-17034408
]
Jacques Le Roux commented on OFBIZ-11317:
-
Thanks Pierre
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034308#comment-17034308
]
Pierre Smits commented on OFBIZ-11317:
--
Thanks Jacques.
A new search (after the aforementioned fix) revealed only hard coded ' Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034303#comment-17034303
]
Jacques Le Roux commented on OFBIZ-11317:
-
Thanks Pierre,
Are we sure it's the only one?
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013778#comment-17013778
]
James Yong commented on OFBIZ-11317:
Hi Jacques,
Using https://gitbox.apache.org/repos/asf/ofbiz-framework.git works.
Thanks.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013777#comment-17013777
]
ASF subversion and git services commented on OFBIZ-11317:
-
Commit 7cbc4b6d79a59662679f3bc2f98d9efe2e303b23 in ofbiz-plugins's branch
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7cbc4b6 ]
Improved: Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
(OFBIZ-11317)
Adding the controlPath attribute to allow the controls by ofbizUrl to support
uri to other OFBiz web application.
Thanks: Jacques for the review
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013776#comment-17013776
]
ASF subversion and git services commented on OFBIZ-11317:
-
Commit 05ffbd28177374004a5e63305ba338dc37729fa8 in ofbiz-framework's branch
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=05ffbd2 ]
Improved: Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
(OFBIZ-11317)
Adding the controlPath attribute to allow the controls by ofbizUrl to support
uri to other OFBiz web application.
Thanks: Jacques for the review
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013766#comment-17013766
]
Jacques Le Roux commented on OFBIZ-11317:
-
Do you have used https://gitbox.apache.org/repos/asf/ofbiz-framework.git to
clone? Then it should be OK.
Try {{$ git remote -v}}
to check you get:
{noformat}
origin https://gitbox.apache.org/repos/asf/ofbiz-framework.git (fetch)
origin https://gitbox.apache.org/repos/asf/ofbiz-framework.git (push)
{noformat}
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013734#comment-17013734
]
James Yong commented on OFBIZ-11317:
May I know what is the consequence of committing to
[https://github.com/apache/ofbiz-framework.git]
instead of
[https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git] ?
I tried the former but didn't see the new change after checking the project out
again.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013724#comment-17013724
]
Jacques Le Roux commented on OFBIZ-11317:
-
Ah indeed, missed that (did not test)
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013694#comment-17013694
]
James Yong commented on OFBIZ-11317:
Updated the patch as a vital change in the UrlRegexpTransform.java is missed.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013675#comment-17013675
]
Jacques Le Roux commented on OFBIZ-11317:
-
Hi James,
Thanks for this improvement, it looks good to me. Please commit, thanks.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
