[jira] [Commented] (OFBIZ-11927) Deprecate unused HTML Renderers
[ https://issues.apache.org/jira/browse/OFBIZ-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266535#comment-17266535 ] ASF subversion and git services commented on OFBIZ-11927: - Commit 3f76f86014665905c2cb29d322c918fc8c7e38e8 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3f76f86 ] Improved: Marked unused HTML renderers as deprecated (OFBIZ-11927) Upcoming Branch is actually another name for trunk. It's always evolving and never released. Better put a date when deprecating a Class or method. Else you have no idea when it was deprecated, apart referring to git-blame. > Deprecate unused HTML Renderers > --- > > Key: OFBIZ-11927 > URL: https://issues.apache.org/jira/browse/OFBIZ-11927 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > The HTML renderers in package org.apache.ofbiz.widget.renderer.html do not > appear to be used. While refactoring other parts of the widget system we > have to make corresponding changes to the HTML renderers, but don't have any > test cases to prove the HTML renderers continue to function correctly. > OFBIZ-6281 suggests that HtmlScreenRenderer was deprecated some time ago and > has since been removed from ofbiz sources. > Mark the remaining HTML renderers as deprecated since they should have been > superseded by the Macro renderers. > Assuming the HTML renderer classes are deprecated in the next release they > can be removed in the following release. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11927) Deprecate unused HTML Renderers
[ https://issues.apache.org/jira/browse/OFBIZ-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265059#comment-17265059 ] ASF subversion and git services commented on OFBIZ-11927: - Commit 406f51d032ba4012aed6a5e6253b524a31364e42 in ofbiz-framework's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=406f51d ] Improved: Marked unused HTML renderers as deprecated (OFBIZ-11927) > Deprecate unused HTML Renderers > --- > > Key: OFBIZ-11927 > URL: https://issues.apache.org/jira/browse/OFBIZ-11927 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > The HTML renderers in package org.apache.ofbiz.widget.renderer.html do not > appear to be used. While refactoring other parts of the widget system we > have to make corresponding changes to the HTML renderers, but don't have any > test cases to prove the HTML renderers continue to function correctly. > OFBIZ-6281 suggests that HtmlScreenRenderer was deprecated some time ago and > has since been removed from ofbiz sources. > Mark the remaining HTML renderers as deprecated since they should have been > superseded by the Macro renderers. > Assuming the HTML renderer classes are deprecated in the next release they > can be removed in the following release. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11927) Deprecate unused HTML Renderers
[ https://issues.apache.org/jira/browse/OFBIZ-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264816#comment-17264816 ] James Yong commented on OFBIZ-11927: To my knowledge, the following classes are unused and should be deprecated: HtmlMenuRendererImage HtmlMenuWrapperImage HtmlTreeRenderer > Deprecate unused HTML Renderers > --- > > Key: OFBIZ-11927 > URL: https://issues.apache.org/jira/browse/OFBIZ-11927 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: Trunk >Reporter: Daniel Watford >Priority: Minor > > The HTML renderers in package org.apache.ofbiz.widget.renderer.html do not > appear to be used. While refactoring other parts of the widget system we > have to make corresponding changes to the HTML renderers, but don't have any > test cases to prove the HTML renderers continue to function correctly. > OFBIZ-6281 suggests that HtmlScreenRenderer was deprecated some time ago and > has since been removed from ofbiz sources. > Mark the remaining HTML renderers as deprecated since they should have been > superseded by the Macro renderers. > Assuming the HTML renderer classes are deprecated in the next release they > can be removed in the following release. -- This message was sent by Atlassian Jira (v8.3.4#803005)
