[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation
[
https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353929#comment-17353929
]
Daniel Watford commented on OFBIZ-12247:
Hi [~jleroux] - retested in trunk and passed. Thanks
> Allow to pass a Google API key for geolocation
> --
>
> Key: OFBIZ-12247
> URL: https://issues.apache.org/jira/browse/OFBIZ-12247
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01
>
>
> This is related to this question from Daniel at
> [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended
> up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl
> line 44 with my key. Line 44 looked similar to: src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_";
> type="application/javascript">
> Is there a way to configure ofbiz with the API key?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation
[
https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353924#comment-17353924
]
ASF subversion and git services commented on OFBIZ-12247:
-
Commit ad5822461412e8caa2daa1a152c8c15fa9afe708 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ad58224 ]
Improved: Allow to pass a Google API key for geolocation (OFBIZ-12247)
Fixes the call to the Google API key
Thanks to Daniel
> Allow to pass a Google API key for geolocation
> --
>
> Key: OFBIZ-12247
> URL: https://issues.apache.org/jira/browse/OFBIZ-12247
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This is related to this question from Daniel at
> [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended
> up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl
> line 44 with my key. Line 44 looked similar to: src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_";
> type="application/javascript">
> Is there a way to configure ofbiz with the API key?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation
[
https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353923#comment-17353923
]
ASF subversion and git services commented on OFBIZ-12247:
-
Commit 81654fc155c2d6d54914b4daf731525271be71ad in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=81654fc ]
Improved: Allow to pass a Google API key for geolocation (OFBIZ-12247)
Better way to handle a missing Google API key
> Allow to pass a Google API key for geolocation
> --
>
> Key: OFBIZ-12247
> URL: https://issues.apache.org/jira/browse/OFBIZ-12247
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This is related to this question from Daniel at
> [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended
> up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl
> line 44 with my key. Line 44 looked similar to: src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_";
> type="application/javascript">
> Is there a way to configure ofbiz with the API key?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation
[
https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353922#comment-17353922
]
ASF subversion and git services commented on OFBIZ-12247:
-
Commit 7778b7692db43d34967bdd80c89c6fb104e01966 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7778b76 ]
Improved: Allow to pass a Google API key for geolocation (OFBIZ-12247)
This is related to this question from Daniel at
https://github.com/apache/ofbiz-framework/pull/220
I couldn't figure out how to configure OFBiz with my Google API key so ended up
temporarily patching
themes/common-theme/template/includes/GeoLocation.ftl line 44 with my key.
Line 44 looked similar to:
https://maps.googleapis.com/maps/api/js?key=secret_google_api_key";
type="application/javascript">
Is there a way to configure ofbiz with the API key?
Disclaimer: w/o a not free "Google API key" I was not able to test, will ask
Daniel...
Conflicts handled by hand
framework/common/config/general.properties
> Allow to pass a Google API key for geolocation
> --
>
> Key: OFBIZ-12247
> URL: https://issues.apache.org/jira/browse/OFBIZ-12247
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This is related to this question from Daniel at
> [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended
> up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl
> line 44 with my key. Line 44 looked similar to: src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_";
> type="application/javascript">
> Is there a way to configure ofbiz with the API key?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation
[
https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353921#comment-17353921
]
ASF subversion and git services commented on OFBIZ-12247:
-
Commit c4b106e1b1d4a9e4fbc74849a40965d9691e4951 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c4b106e ]
Improved: Allow to pass a Google API key for geolocation (OFBIZ-12247)
Fixes the call to the Google API key
Thanks to Daniel
> Allow to pass a Google API key for geolocation
> --
>
> Key: OFBIZ-12247
> URL: https://issues.apache.org/jira/browse/OFBIZ-12247
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This is related to this question from Daniel at
> [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended
> up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl
> line 44 with my key. Line 44 looked similar to: src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_";
> type="application/javascript">
> Is there a way to configure ofbiz with the API key?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation
[
https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353783#comment-17353783
]
Daniel Watford commented on OFBIZ-12247:
Hi [~jleroux],
Slight change needed on line 49 of GeoLocation.ftl:
https://maps.googleapis.com/maps/api/js?key=${googleApiKey}";
type="application/javascript">
> Allow to pass a Google API key for geolocation
> --
>
> Key: OFBIZ-12247
> URL: https://issues.apache.org/jira/browse/OFBIZ-12247
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/common, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> This is related to this question from Daniel at
> [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended
> up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl
> line 44 with my key. Line 44 looked similar to: src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_";
> type="application/javascript">
> Is there a way to configure ofbiz with the API key?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation
[
https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353706#comment-17353706
]
ASF subversion and git services commented on OFBIZ-12247:
-
Commit de5d1f8fc4619772f066eafb86b9fe028c5f0cfb in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=de5d1f8 ]
Improved: Allow to pass a Google API key for geolocation (OFBIZ-12247)
Better way to handle a missing Google API key
> Allow to pass a Google API key for geolocation
> --
>
> Key: OFBIZ-12247
> URL: https://issues.apache.org/jira/browse/OFBIZ-12247
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/common, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> This is related to this question from Daniel at
> [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended
> up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl
> line 44 with my key. Line 44 looked similar to: src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_";
> type="application/javascript">
> Is there a way to configure ofbiz with the API key?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation
[
https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353701#comment-17353701
]
ASF subversion and git services commented on OFBIZ-12247:
-
Commit fec6559e7b3f82604514868b0de72a9e47758d7a in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fec6559 ]
Improved: Allow to pass a Google API key for geolocation (OFBIZ-12247)
This is related to this question from Daniel at
https://github.com/apache/ofbiz-framework/pull/220
I couldn't figure out how to configure OFBiz with my Google API key so ended up
temporarily patching
themes/common-theme/template/includes/GeoLocation.ftl line 44 with my key.
Line 44 looked similar to:
https://maps.googleapis.com/maps/api/js?key=secret_google_api_key";
type="application/javascript">
Is there a way to configure ofbiz with the API key?
Disclaimer: w/o a not free "Google API key" I was not able to test, will ask
Daniel...
> Allow to pass a Google API key for geolocation
> --
>
> Key: OFBIZ-12247
> URL: https://issues.apache.org/jira/browse/OFBIZ-12247
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/common, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> This is related to this question from Daniel at
> [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended
> up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl
> line 44 with my key. Line 44 looked similar to: src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_";
> type="application/javascript">
> Is there a way to configure ofbiz with the API key?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
