[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943737#comment-16943737 ] Jacques Le Roux commented on OFBIZ-1463: This Suraj's answer clarifies the situation: https://markmail.org/message/zlf5chufefekb5r2, we can use the same ticket while converting the test to Groovy > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942884#comment-16942884 ] Jacques Le Roux commented on OFBIZ-1463: Moreover, most of the work here is about data, not only the tests themselves. So it would not be smart to drop all the work done, even if we have to change file paths and even adapt data > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879873#comment-16879873 ] Jacques Le Roux commented on OFBIZ-1463: Here is my conclusion on the discussion on dev ML I started following the one in OFBIZ-1463, [[DISCUSSION] Committing Minilang test patches under OFBIZ-1463|https://markmail.org/message/yejhuoyfxo5wnnl5]: bq. After 3 days, only people against expressed their opinions, so I think the discussion is closed. > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853949#comment-16853949 ] Jacques Le Roux commented on OFBIZ-1463: I'm still wondering about that. Because, even if the logic will still be the same it would be a pity to lose the work done because the patches don't apply in future. So it's a bit of more work (patching testing and removing when same in Groovy exist) but the tests would be there and used and it could be easier to move from Minilang to Groovy once the code is in place in the project. What do you think? Anyway I'll start a discussion in dev ML! > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726942#comment-16726942 ] Michael Brohl commented on OFBIZ-1463: -- There is indeed no waste of effort since we can use the test logic and convert it into Groovy based tests. We decided to not add any new mini lang code to the code base so it does not make much sense to commit the remaining patches. They should be migrated instead. It would be great if we someone could start an effort to migrate the tests from this issue (committed or provided as patches). > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726630#comment-16726630 ] Jacques Le Roux commented on OFBIZ-1463: Indeed Suraj (we crossed on wire as I did not update the Jira- mean the Jira issue there). As is said, maybe no need to commit (disclaimer: no reviews just thinking)... > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726626#comment-16726626 ] Jacques Le Roux commented on OFBIZ-1463: I'ts not really wasted, as the algorithms in the minilang patches can be interpreted in Groovy, a bit harder than pure Minilang code, but the ideas are there. > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726479#comment-16726479 ] Suraj Khurana commented on OFBIZ-1463: -- IMO, we can commit these patches and convert them to Java and/or DSL as time allows. Just my two cents !! > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725844#comment-16725844 ] Pierre Smits commented on OFBIZ-1463: - What a pity to waste the effort spent by the various parties who provided the patches to the sub tasks still open. > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725776#comment-16725776 ] Aditya Sharma commented on OFBIZ-1463: -- Makes sense Michael. IMO we can close these tickets with tests in mini lang and can create new tickets for test suite with Java/Groovy when needed. > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873280#comment-15873280 ] Michael Brohl commented on OFBIZ-1463: -- We are currently discussing to stop introducing more mini lang code to the codebase so we should postpone commiting the remianing patches in the subtasks until a decision is made. The provided patches can later be converted to Java and/or DSL tests if we decide to deprecate mini lang. > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
