[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-04-19 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821944#comment-16821944
 ] 

Swapnil M Mane commented on OFBIZ-4690:
---

The change of calling 'cancelPicklistAndItems' action service in sync mode is 
committed in 

trunk at rev 1857813
 release18.12 at rev 1857814
 release17.12 at rev 1857815
 release16.11 at rev 1857816

Thanks!

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-04-19 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821919#comment-16821919
 ] 

Swapnil M Mane commented on OFBIZ-4690:
---

Thank you [~jacques.le.roux] !

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-04-19 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821915#comment-16821915
 ] 

Jacques Le Roux commented on OFBIZ-4690:


Hi Swapnil,

Yes please proceed, we are in CTR (Commit Then Review) mode, so if somebody see 
a problem with that we will still be able to amend it, thanks!

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-04-19 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821809#comment-16821809
 ] 

Swapnil M Mane commented on OFBIZ-4690:
---

Dear [~jacques.le.roux], 
Thanks for your comment. 
Should I proceed to change the calling of 'cancelPicklistAndItems' action 
service in sync mode.
Thanks!

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-04-02 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807464#comment-16807464
 ] 

Jacques Le Roux commented on OFBIZ-4690:


Hi Swapnil,

I guess you crossed an issue with that and then it makes sense indeed, thanks.

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-03-18 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795051#comment-16795051
 ] 

Swapnil M Mane commented on OFBIZ-4690:
---

No worries [~jacques.le.roux], please take your time. :)

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-03-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795047#comment-16795047
 ] 

Jacques Le Roux commented on OFBIZ-4690:


Hi Swapnil,

Bear with me, being buzy I'll not be able to answer before a week or two...

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-03-18 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794917#comment-16794917
 ] 

Swapnil M Mane commented on OFBIZ-4690:
---

Thank you [~ankit.jain] and [~jacques.le.roux] for your contribution.

I think we should handle the following case:
A transaction in running in which Picklist entity is updated, now if the 
transaction is rollback the picklist status will not be updated but since we 
call the cancelPicklistAndItems in async mode, the picklist item's status will 
get updated.

So the situation here is status of Picklist is not updated, but status of 
Picklist items are updated.

Here are two possible solutions:

1.) Run the eca on "commit" event.
2.) Call cancelPicklistAndItems action service in sync mode.

Please let me know thoughts or and let me know if I missed anything.

Thanks!

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)