[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2019-06-09 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859401#comment-16859401
 ] 

Jacques Le Roux commented on OFBIZ-5048:


Hi Michael,

Actually this line was copied as is from 
[ServiceEventHandler|http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/ServiceEventHandler.java?r1=1847478=1847477=1847478].
 So it's hard to tell w/o going into history. I did it for you: it's like that 
from pre Apache era. So it's your decision if nobody answer...

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-12-02 Thread Rohit Koushal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706665#comment-16706665
 ] 

Rohit Koushal commented on OFBIZ-5048:
--

Thank you for looking into it [~jacques.le.roux]. (y)

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-12-02 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706335#comment-16706335
 ] 

Deepak Dixit commented on OFBIZ-5048:
-

Thanks Jacques.

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-12-02 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706169#comment-16706169
 ] 

Jacques Le Roux commented on OFBIZ-5048:


backported in R17 at r1847478

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-27 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700173#comment-16700173
 ] 

Jacques Le Roux commented on OFBIZ-5048:


I see no problems with that Deepak, just that I only reviewed (simple enough) 
and did not test.

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699977#comment-16699977
 ] 

Deepak Dixit commented on OFBIZ-5048:
-

I think we can backport this to R17.12 as well, as its missing code in Groovy 
handler. 

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Rohit Koushal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698684#comment-16698684
 ] 

Rohit Koushal commented on OFBIZ-5048:
--

Thanks [~jacques.le.roux] ,

Attaching the revised patch by name OFBIZ-5048V2.patch

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698647#comment-16698647
 ] 

Jacques Le Roux commented on OFBIZ-5048:


Hi Rohit,

Your patch looks good to me, but it can't be applied as is. It's in Git format, 
please provide a Svn format: "{{git diff --no-prefix}}" thanks

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-24 Thread Rohit Koushal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697879#comment-16697879
 ] 

Rohit Koushal commented on OFBIZ-5048:
--

I am attaching here the revised patch with some minor changes.

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)