[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-19 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620413#comment-17620413 ] Jacques Le Roux commented on OFBIZ-6747: Finally, I has a serious look at UtilCache. I wrote

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-19 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620078#comment-17620078 ] Jacques Le Roux commented on OFBIZ-6747: Forgot to mention that I fixed the

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619430#comment-17619430 ] ASF subversion and git services commented on OFBIZ-6747: Commit

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-18 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619429#comment-17619429 ] Jacques Le Roux commented on OFBIZ-6747: Thanks for the tip was useful in one case

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-17 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619048#comment-17619048 ] Ben Manes commented on OFBIZ-6747: -- I think you want to use {{Cache.asMap()}} to get a map view. >

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-17 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618986#comment-17618986 ] Jacques Le Roux commented on OFBIZ-6747: Forgot to say that it's ony the OOTB situation. Things

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-17 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618985#comment-17618985 ] Jacques Le Roux commented on OFBIZ-6747: Hi, As those interested certainly noticed the commits

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616811#comment-17616811 ] ASF subversion and git services commented on OFBIZ-6747: Commit

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616809#comment-17616809 ] ASF subversion and git services commented on OFBIZ-6747: Commit

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-12 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616231#comment-17616231 ] Jacques Le Roux commented on OFBIZ-6747: Indeed, just tried: 2 errors to fix, does not seem

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616204#comment-17616204 ] Ben Manes commented on OFBIZ-6747: -- I see that comment in your {{ldap/build.gradle}} file, but now that

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616197#comment-17616197 ] Jacques Le Roux commented on OFBIZ-6747: We crossed on wire :) > Replace ConcurrentLinkedHashMap

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616196#comment-17616196 ] Jacques Le Roux commented on OFBIZ-6747: Thanks for targetCompatibility info. As I said I'm far

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616194#comment-17616194 ] Ben Manes commented on OFBIZ-6747: -- I think you could change these [two

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616193#comment-17616193 ] Jacques Le Roux commented on OFBIZ-6747: By curiosity I tried that with 3.1.1: {code} ---

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616191#comment-17616191 ] Ben Manes commented on OFBIZ-6747: -- {quote}We run under Java 11, but the build requires Java 8, right?

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616188#comment-17616188 ] Jacques Le Roux commented on OFBIZ-6747: Hi Ben, I'm still not sure to understand the reason we

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615993#comment-17615993 ] Ben Manes commented on OFBIZ-6747: -- Good catch. The error you saw and figured out is that Caffeine v3

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615730#comment-17615730 ] Jacques Le Roux commented on OFBIZ-6747: 2.9.3 works > Replace ConcurrentLinkedHashMap by

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615671#comment-17615671 ] Jacques Le Roux commented on OFBIZ-6747: I tried to add caffeine:3.1.1 and got this: {noformat}

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615572#comment-17615572 ] Jacques Le Roux commented on OFBIZ-6747: Thanks Ben, That's another perspective to consider

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615508#comment-17615508 ] Ben Manes commented on OFBIZ-6747: -- Sorry, I did not mean for you to replace {{UtilCache}} as it

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2022-10-11 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615501#comment-17615501 ] Jacques Le Roux commented on OFBIZ-6747: This is not an easy work. There are 289 occurrences of

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-13 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511657#comment-16511657 ] Jacques Le Roux commented on OFBIZ-6747: Hi Taher, actually I'm not working on this at the

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-12 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510062#comment-16510062 ] Ben Manes commented on OFBIZ-6747: -- In regards to fun algorithms, some resources to look into are... *

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-12 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510004#comment-16510004 ] Taher Alkhateeb commented on OFBIZ-6747: Ahh I just noticed that Jacques is working on this issue

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-12 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509486#comment-16509486 ] Taher Alkhateeb commented on OFBIZ-6747: Amazing Ben, in a few words you're opening my eyes to a

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-11 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508752#comment-16508752 ] Ben Manes commented on OFBIZ-6747: -- If you do switch to Caffeine, a few minor notes to be aware of... #

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-11 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508717#comment-16508717 ] Taher Alkhateeb commented on OFBIZ-6747: Thank you Ben, this is indeed quite informative. So I

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-09 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507108#comment-16507108 ] Ben Manes commented on OFBIZ-6747: -- The two libraries do share a compatible interface via

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-09 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506992#comment-16506992 ] Taher Alkhateeb commented on OFBIZ-6747: I am also in favor of Mathieu's approach. I assume the

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506951#comment-16506951 ] Jacques Le Roux commented on OFBIZ-6747: Good point Mathieu, For history: [~doogie] was at the

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-09 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506881#comment-16506881 ] Mathieu Lirzin commented on OFBIZ-6747: --- I am not aware about the whole story and the rationale

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506858#comment-16506858 ] Jacques Le Roux commented on OFBIZ-6747: To clarify the issue, I changed the title from "Upgrade