[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-08-08 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903015#comment-16903015
 ] 

Jacques Le Roux commented on OFBIZ-7963:


Just noticed this "ASF Sonarqube instance deprecated.": 
https://lists.apache.org/thread.html/e69f95e0fd52d55bca2e858019d78d103dcd197863abc4a4f7609c4e@%3Cusers.infra.apache.org%3E

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revive INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-28 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849902#comment-16849902
 ] 

Pierre Smits commented on OFBIZ-7963:
-

Keep in mind that sonarqube != sonarcloud.io

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revive INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849469#comment-16849469
 ] 

Jacques Le Roux commented on OFBIZ-7963:


Actually I must confess I did not look into details of sonarqube only 
https://plugins.gradle.org/plugin/org.sonarqube.

I need to read 
https://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
 and then will get back to you...

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revive INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848421#comment-16848421
 ] 

Pierre Smits commented on OFBIZ-7963:
-

You keep mentioning to have the sonar task to be available for local execution. 
I understand this as having adopters (and their developers) to be able to 
execute such and post the results to the sonarcloud.io service for the project. 
This should be considered as undesirable, as it may lead to having the service 
show results not applicable to the code base of the projects (what is in its 
repos).

Any adopter can have in their own environment their own - specific - setup 
(with adjustments to gradle). But it should not dictate the setup for the 
project. 

You're talking about 'how could we test them before committing'. Let me do 
my thing and you'll get something that works. Now you're not. 

Are you saying that current buildbot configuration does not offer such 
flexibility?

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848415#comment-16848415
 ] 

Jacques Le Roux commented on OFBIZ-7963:


bq. Due to secret key(s) required by SonarCloud.io this service will not work 
(ever) when done locally. You don't share secret keys with just anybody. The 
risk of the result getting messed is ever present.
Hu?  I don't get it, the sonarqube task runs locally, even if it reports an 
error.

bq. What you're referring to are missing inclusion/exclusion aspects. These 
should (must??) not be included in the gradle task, but should rather be 
included in the CI setup (as parameters) to ensure flexibility.
Which flexibility are your referring about? The code structure is the same 
locally or on Buildbot. I don't see a reason it would not work locally. We 
don't use Buildbot specific parameters so far, all tasks are usable locally. 
How could we test them before committing else?

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848402#comment-16848402
 ] 

Pierre Smits commented on OFBIZ-7963:
-

Jacques,

Due to secret key(s) required by SonarCloud.io this service will not work 
(ever) when done locally. You don't share secret keys with just anybody. The 
risk of the result getting messed is ever present.

You're saying that the patch does not work. That is an incorrect/incomplete 
statement. What you're referring to are missing inclusion/exclusion aspects. 
These should (must??) not be included in the gradle task, but should rather be 
included in the CI setup (as parameters) to ensure flexibility.





> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848397#comment-16848397
 ] 

Jacques Le Roux commented on OFBIZ-7963:


Thanks Pierre,
 # was almost already clear to me, I only mentionned Travis because Fabrice 
Bellingard did so.
 I understand that the patch is necessary for us because we use only Buildbot 
as CI tool.
 # I know now that Travis is not part of CI ASF services.
 # no comment
 # I don't need to ask infra, if the Gradle patch works. It does not for now 
and we (the community as a whole) need to investigate, of course in terms of 
our priorities...

I must add that I'd like to have this Gradle task working because it could then 
be used not only locally (why not) but especially in Buildbot. So like we have 
shared demos, shared tests (thanks to Buildbot) we would have shared 
[continuous inspection of code quality.|https://en.wikipedia.org/wiki/SonarQube]

We only make real progress as a whole team, and that's what I'm really 
concerned about :)

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385
 ] 

Pierre Smits commented on OFBIZ-7963:
-

Jacques,

To clarify some things:
# The Jenkins+Sonar aspect is based on a sonarqube service provided by the ASF 
that has been deprecated in favour of the 3rd party Sonar service 
(sonarcloud.io). So there is only the in-house CI services (buildbot and 
Jenkins). I have explained in the referenced tickets that the in-house Sonar 
service was going away. 
I have also explained that in order to have this (code analysis) working, the 
patch is required. So without the patch there is no code analysis. 
# CI is not vague! What projects use to have CI (or not, and with what) is up 
to the projects. The ASF provides only buildbot and Jenkins. Travis is not an 
ASF service. It is a 3rd party service.
# Ultimately it is you who is concerned about buildbot+sonar. The rest does not 
care, as long as the service to the project is as expected.
# Everyone with privileges has access to ASF services, or can request them via 
INFRA.

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848380#comment-16848380
 ] 

Jacques Le Roux commented on OFBIZ-7963:


bq. What are you talking about when stating: 'if it still works'? 
Jenkins+Sonar like you got results at OFBIZ-10919 and OFBIZ-10918

bq. The solution is intended to work with ASF services, meaning the CI and the 
repos available.
CI is vague, at the ASF some use Jenkins, others Travis, we use Builbot. I 
understand that ultimately we want to use Builbot+Gradle with sonarqube task

bq. Agree to what? IIUC, the community already agreed to the fact that code 
analysis is beneficial to the project.
Yes, as stated above "ultimately we want to use Builbot+Gradle with sonarqube 
task". But in the meantime we could use Jenkins+Sonar (if it still works, I 
don't know what you did there, and I have no access)

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848362#comment-16848362
 ] 

Pierre Smits commented on OFBIZ-7963:
-

Agree to what? IIUC, the community already agreed to the fact that code 
analysis is beneficial to the project.

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848361#comment-16848361
 ] 

Pierre Smits commented on OFBIZ-7963:
-

What are you talking about when stating: 'if it still works'? 

The solution is intended to work with ASF services, meaning the CI and the 
repos available.

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848357#comment-16848357
 ] 

Jacques Le Roux commented on OFBIZ-7963:


BTW if it still works and the community agrees about that, why not using, at 
least in the meantime, Jenkins and the Git mirror repos?

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848356#comment-16848356
 ] 

Jacques Le Roux commented on OFBIZ-7963:


Hi Pierre,

Your last patch gives the same "result" than I put above (normal it's the same 
thing).

I looked at the reason it fails. This is related: 
[https://github.com/SonarOpenCommunity/sonar-cxx/wiki/FAQ] (look for "Q: ERROR: 
Caused by: File [...] can't be indexed twice.").
 They explain:
{noformat}
An example could look like this:

sonar.sources=.
sonar.tests=.
sonar.test.inclusions=**/*Test*/**
sonar.exclusions=**/*Test*/**
{noformat}
Should those be properties in sonarqube section? What should we put there 
actually? Would you mind investigating?
If I understand well the 1st test failing 
(MultivaluedMapContextAdapterTests.java) is the 1st running, all others are the 
same. So as long as we have not defined some sonarqube parameters (maybe 
beggining with the explanation above) we will not get any usable result, as you 
did with OFBIZ-10919 and OFBIZ-10918. If I refer to INFRA-18188, where Jenkins 
was used, it's not that easy to transpose to Gradle: Jenkins do the job for you 
there as says Fabrice Bellingard.

So you don't need to answer my questions at OFBIZ-10917, I think I got the big 
picture and I guess we "only" need now to correctly define the properties in 
sonarqube section...



> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-21 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844756#comment-16844756
 ] 

Pierre Smits commented on OFBIZ-7963:
-

I will submit a new patch.

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-21 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844752#comment-16844752
 ] 

Pierre Smits commented on OFBIZ-7963:
-

I am expection other issues to occur when triggered manually, as it is intended 
to work with ASF CI services.

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844723#comment-16844723
 ] 

Jacques Le Roux commented on OFBIZ-7963:


Hi Pierre,

I have seen you put the "Patch Available" status, but did not annouce it. I 
though tried it and found it misses {{id 'org.sonarqube' version '2.7.1' apply 
false}} in plugins sections. Once added it almost works, I get:


{noformat}
> Task :sonarqube
SCM provider autodetection failed. Please use "sonar.scm.provider" to define 
SCM of your project, or disable the SCM Sensor in the project settings.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\collections\MultivaluedMapContextAdapterTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\collections\MultivaluedMapContextTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\template\FreeMarkerWorkerTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\UtilCodecTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\entity\src\test\java\org\apache\ofbiz\entity\DelegatorUnitTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\entity\src\test\java\org\apache\ofbiz\entity\EntityConditionVisitorTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\entity\src\test\java\org\apache\ofbiz\entity\util\EntitySaxReaderTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\common\src\test\java\org\apache\ofbiz\common\GetLocaleListTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\webapp\src\test\java\org\apache\ofbiz\webapp\control\ControlFilterTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\webapp\src\test\java\org\apache\ofbiz\webapp\control\ExternalLoginKeysManagerTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\webapp\src\test\java\org\apache\ofbiz\webapp\control\RequestHandlerTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\webapp\src\test\java\org\apache\ofbiz\webapp\WebAppCacheTest.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\widget\src\test\java\org\apache\ofbiz\widget\renderer\FormRendererTest.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\start\src\test\java\org\apache\ofbiz\base\start\OfbizStartupUnitTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\groovy\org\apache\ofbiz\base\util\FileUtilTests.groovy'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\accounting'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\collections\MultivaluedMapContextAdapterTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\commonext'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\collections\MultivaluedMapContextTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\commonext'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\commonext'.
File 
'C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\template\FreeMarkerWorkerTests.java'
 is ignored. It is not located in module basedir 
'C:\projectsASF\ofbiz\applications\commonext'.
File 

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-17 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842070#comment-16842070
 ] 

Pierre Smits commented on OFBIZ-7963:
-

I hope to provide a patch for review soon. Just waiting on feedback from an 
involved party from SonarCloud on approach.

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-17 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842066#comment-16842066
 ] 

Pierre Smits commented on OFBIZ-7963:
-

In order to have code analysis on OFBiz artefacts through available ASF 
services (CI and external SonarCloud.io) we need to have the build.gradle file 
adjusted.

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2016-08-20 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429259#comment-15429259
 ] 

Taher Alkhateeb commented on OFBIZ-7963:


Hi Jacques,

Is this necessary at this point in time? Sonar requires first a lot of code 
cleanup which we did not yet complete. Perhaps we can put this in your backlog 
or wiki for ideas on what to do?

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)