[jira] [Commented] (OFBIZ-8202) Use try-with-resources statement wherever it's possible
[ https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027623#comment-17027623 ] Jacques Le Roux commented on OFBIZ-8202: I think so even if I'm not sure we have done it completely. In such case new Jiras can be created anyway. And we could then create one for Groov using withCloseable, we have any currently. I'll do so when I'll get a chance, should not be too long... > Use try-with-resources statement wherever it's possible > --- > > Key: OFBIZ-8202 > URL: https://issues.apache.org/jira/browse/OFBIZ-8202 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 17.12.01, 16.11.03 > > Attachments: OFBIZ-9410.patch > > > This is a non functional change task. > I have already commited some such changes for OFBIZ-8115 and at r1759082 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8202) Use try-with-resources statement wherever it's possible
[ https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027580#comment-17027580 ] Michael Brohl commented on OFBIZ-8202: -- Shouldn't this be closed, [~jleroux] ? > Use try-with-resources statement wherever it's possible > --- > > Key: OFBIZ-8202 > URL: https://issues.apache.org/jira/browse/OFBIZ-8202 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 17.12.01, 16.11.03 > > Attachments: OFBIZ-9410.patch > > > This is a non functional change task. > I have already commited some such changes for OFBIZ-8115 and at r1759082 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8202) Use try-with-resources statement wherever it's possible
[ https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044222#comment-16044222 ] Jacques Le Roux commented on OFBIZ-8202: I fixed an issue (reported by Daniel Coris on user ML) introduced by r1787949, with another similar, in the R16.11 branch with revision: 1798179 > Use try-with-resources statement wherever it's possible > --- > > Key: OFBIZ-8202 > URL: https://issues.apache.org/jira/browse/OFBIZ-8202 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Release > > > This is a non functional change task. > I have already commited some such changes for OFBIZ-8115 and at r1759082 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8202) Use try-with-resources statement wherever it's possible
[ https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496540#comment-15496540 ] Jacques Le Roux commented on OFBIZ-8202: I reverted r1761023 at r1761045, because it works locally on Windows but not locally on Linux see http://markmail.org/message/r5pxmyymsj74ywek for details I have no ideas why this happens yet, still investigating > Use try-with-resources statement wherever it's possible > --- > > Key: OFBIZ-8202 > URL: https://issues.apache.org/jira/browse/OFBIZ-8202 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > This is a non functional change task. > I have already commited some such changes for OFBIZ-8115 and at r1759082 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8202) Use try-with-resources statement wherever it's possible
[ https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496116#comment-15496116 ] Jacques Le Roux commented on OFBIZ-8202: Done for the accounting component at r1761023 > Use try-with-resources statement wherever it's possible > --- > > Key: OFBIZ-8202 > URL: https://issues.apache.org/jira/browse/OFBIZ-8202 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > This is a non functional change task. > I have already commited some such changes for OFBIZ-8115 and at r1759082 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8202) Use try-with-resources statement wherever it's possible
[ https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15476153#comment-15476153 ] Jacques Le Roux commented on OFBIZ-8202: Next step is to have EntityListIterator to implement AutoCloseable, fortunately it has a clean close() method, so it's more about where it's used... > Use try-with-resources statement wherever it's possible > --- > > Key: OFBIZ-8202 > URL: https://issues.apache.org/jira/browse/OFBIZ-8202 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > This is a non functional change task. > I have already commited some such changes for OFBIZ-8115 and at r1759082 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8202) Use try-with-resources statement wherever it's possible
[ https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15476149#comment-15476149 ] Jacques Le Roux commented on OFBIZ-8202: Changes in SagePayServices class, including use of "try-with-resources statement" and formatting at r1759944 > Use try-with-resources statement wherever it's possible > --- > > Key: OFBIZ-8202 > URL: https://issues.apache.org/jira/browse/OFBIZ-8202 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > This is a non functional change task. > I have already commited some such changes for OFBIZ-8115 and at r1759082 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
