[jira] [Commented] (OFBIZ-8986) OFBIZ-7520: Consistency and Readability improvements for make-value tag

2017-07-10 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080158#comment-16080158
 ] 

Rishi Solanki commented on OFBIZ-8986:
--

Thanks [~deepak.dixit]

> OFBIZ-7520: Consistency and Readability improvements for make-value tag
> ---
>
> Key: OFBIZ-8986
> URL: https://issues.apache.org/jira/browse/OFBIZ-8986
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8986.patch
>
>
> Code written in Minilang for the entity-one tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8986) OFBIZ-7520: Consistency and Readability improvements for make-value tag

2017-07-10 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079931#comment-16079931
 ] 

Deepak Dixit commented on OFBIZ-8986:
-

Hi Rishi,

Code committed under this ticket generated issue reported in OFBIZ-9114, So I 
reverted commit done under this ticket.
So OFBIZ-8953 is not completed.

OFBIZ-9114 is simply linked with this ticket for reference.


> OFBIZ-7520: Consistency and Readability improvements for make-value tag
> ---
>
> Key: OFBIZ-8986
> URL: https://issues.apache.org/jira/browse/OFBIZ-8986
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8986.patch
>
>
> Code written in Minilang for the entity-one tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8986) OFBIZ-7520: Consistency and Readability improvements for make-value tag

2017-07-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079558#comment-16079558
 ] 

Rishi Solanki commented on OFBIZ-8986:
--

Can we resolve this one as OFBIZ-9114 is closed.

> OFBIZ-7520: Consistency and Readability improvements for make-value tag
> ---
>
> Key: OFBIZ-8986
> URL: https://issues.apache.org/jira/browse/OFBIZ-8986
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8986.patch
>
>
> Code written in Minilang for the entity-one tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8986) OFBIZ-7520: Consistency and Readability improvements for make-value tag

2016-11-05 Thread Ankush Upadhyay (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15639090#comment-15639090
 ] 

Ankush Upadhyay commented on OFBIZ-8986:


Improved consistency and readability improvements for the tag as suggested.

> OFBIZ-7520: Consistency and Readability improvements for make-value tag
> ---
>
> Key: OFBIZ-8986
> URL: https://issues.apache.org/jira/browse/OFBIZ-8986
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8986.patch
>
>
> Code written in Minilang for the entity-one tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)