[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942334#comment-15942334
]
Shi Jinghai commented on OFBIZ-9123:
Thank you Jacques for the reopen, and thanks Pierre and Michael
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941683#comment-15941683
]
Jacques Le Roux commented on OFBIZ-9123:
Hi Jinghai,
We missed a point Pierre made:
bq. Following
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756948#comment-15756948
]
Jacques Le Roux commented on OFBIZ-9123:
Forever I don't know, but thanks :)
> Add a PriCat
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748401#comment-15748401
]
Shi Jinghai commented on OFBIZ-9123:
Thank you Jacques! You are my mentor forever :)
No, I haven't
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747927#comment-15747927
]
Jacques Le Roux commented on OFBIZ-9123:
Hi Jinghai,
I have just changed the Java files you
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732036#comment-15732036
]
Jacques Le Roux commented on OFBIZ-9123:
Agreed Michael, this has already been started in the
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732012#comment-15732012
]
Michael Brohl commented on OFBIZ-9123:
--
This discussion has nothing to do with the issue, please move
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732002#comment-15732002
]
Jacques Le Roux commented on OFBIZ-9123:
Pierre, I guess they are updated regularly
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731949#comment-15731949
]
Pierre Smits commented on OFBIZ-9123:
-
Hi [~shi.jinghai],
The following components are already
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731930#comment-15731930
]
Shi Jinghai commented on OFBIZ-9123:
Ha, finally I got the feeling of what you are worrying about.
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731925#comment-15731925
]
Pierre Smits commented on OFBIZ-9123:
-
Huh?
Committers are required to commit changes for the various
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731880#comment-15731880
]
Jacques Le Roux commented on OFBIZ-9123:
Just for what is already OOTB, like pricat in
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731872#comment-15731872
]
Jacques Le Roux commented on OFBIZ-9123:
Thanks for the explanation Jinghai. So let's wait
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731687#comment-15731687
]
Shi Jinghai commented on OFBIZ-9123:
Hi Jacques,
Here's the test case on OFBizPricatUtil:
1. Import
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731581#comment-15731581
]
Pierre Smits commented on OFBIZ-9123:
-
Following up on this the freemarker templates are not in the
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731577#comment-15731577
]
Pierre Smits commented on OFBIZ-9123:
-
Jacques,
I wonder where you want to have the project having
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731560#comment-15731560
]
Jacques Le Roux commented on OFBIZ-9123:
Hi Jinghai,
IIRW it has been already discussed but I
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690657#comment-15690657
]
Jacques Le Roux commented on OFBIZ-9123:
Thanks for the tip Jinghai.
> Add a PriCat component
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690317#comment-15690317
]
Shi Jinghai commented on OFBIZ-9123:
Hi Jacques,
I submitted a simple readme and replaced some (many)
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689339#comment-15689339
]
Jacques Le Roux commented on OFBIZ-9123:
Hi Jinghai,
My proposition is to create a Maven
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688517#comment-15688517
]
Shi Jinghai commented on OFBIZ-9123:
Hi Jacques,
Thanks for your review!
I'll add a readme asap, and
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683155#comment-15683155
]
Pierre Smits commented on OFBIZ-9123:
-
I already did a cursory review and found that the component is
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683125#comment-15683125
]
Michael Brohl commented on OFBIZ-9123:
--
Maybe I have not expressed myself well enough.
If I got it
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683037#comment-15683037
]
Shi Jinghai commented on OFBIZ-9123:
Hi Michael,
Honestly, this piece of pricat component has been
[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683006#comment-15683006
]
Michael Brohl commented on OFBIZ-9123:
--
Hi Jinghai,
thanks for your contribution. It's appreciated
25 matches
Mail list logo
