[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491087#comment-17491087 ] ASF subversion and git services commented on OFBIZ-9138: Commit b52091d4b993ce74bce55faefe108198df1554a4 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b52091d ] Documented: Continue the common-theme upload (OFBIZ-9138 Create a common theme) Removes 2 FIXMEs about locations for image.server.path and image.management.path properties This follows a message I sent to the user ML https://lists.apache.org/thread/syysbhl99h0753h77hzd5frb50foclsq that is: <> Thanks: APL+Win to help me format the message to 80 chars in a breeze :) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 17.12.01 > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144912#comment-16144912 ] Jacques Le Roux commented on OFBIZ-9138: When I'll get some time I'll do a kinda SVN bisect (ie by hand) to find where the issues were introduced. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144904#comment-16144904 ] Jacques Le Roux commented on OFBIZ-9138: Ha another one, is that you can't select a line in autocomplete list (anyone). I can't find a Jira for that, but I think one exists. Both cases works at r1806036 > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144874#comment-16144874 ] Wei Zhang commented on OFBIZ-9138: -- Sorry, Nicolas. I posted it in wrong issue. I am going to delete my comments. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144870#comment-16144870 ] Jacques Le Roux commented on OFBIZ-9138: BTW I will do a check out of https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk at the revision just before to check for OFBIZ-9645 > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[
https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144868#comment-16144868
]
Nicolas Malin commented on OFBIZ-9138:
--
Hello Wai, can you explain me what is this code and what the relation with the
common-theme ?
Because if I check the entity view :
{code}
~/workspace/apache-svn/ofbiz-trunk
nemo$ grep ExampleTypeView * -R
~/workspace/apache-svn/ofbiz-trunk
nemo$ cd ../ofbiz-plugins/
~/workspace/apache-svn/ofbiz-plugins
nemo$ grep ExampleTypeView * -R
~/workspace/apache-svn/ofbiz-plugins
{code}
So I have no idea this the error
> Create a common theme
> -
>
> Key: OFBIZ-9138
> URL: https://issues.apache.org/jira/browse/OFBIZ-9138
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Fix For: Upcoming Release
>
> Attachments: common-theme-macro.svg, common-theme-screen.svg
>
>
> A first task to UI Improvement would be create a common that receive the
> existent code.
> The benefice would be have a framework/common who list all screens that
> available for theme surcharge, so without technology information (css/html or
> something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical
> element for theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common
> After the realization on this task, all current themes call theme/common for
> html rendering instead of framework/common, framework/images and
> framework/widget. Just pave the way for the next
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144869#comment-16144869 ] Jacques Le Roux commented on OFBIZ-9138: Hi Wei Zhang, If you are sure it's a bug introduced by this new feature (you need to prove it), it's better to create a new Jira issue, to mark it as broken by the current one (OFBIZ-9138) and maybe to notice here (done already if you can prove it ;)). Else we will have few follow-ups mixed here. For instance, it's maybe the same for OFBIZ-9645 (unsure, I was not able to revert just before the switch to common-theme to check it was working just before) and it's possible that we will notice some others. Thanks > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[
https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144665#comment-16144665
]
Wei Zhang commented on OFBIZ-9138:
--
Hi Nicolas,
This fix causes a another problem. You may get the problem by the code below.
{code:borderStyle=solid}
EntityQuery.use(delegator).from("ExampleTypeView").queryList()
{code}
And the error message is:
2017-08-29 10:27:09,990 |jsse-nio-8443-exec-3 |GenericDelegator
|E| Failure in findByCondition operation for entity [ExampleTypeView]:
org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while
executing the following:SELECT EX.EXAMPLE_ID, EX.EXAMPLE_TYPE_ID FROM
public.EXAMPLE EX GROUP BY EX.EXAMPLE_TYPE_ID (ERROR: column "ex.example_id"
must appear in the GROUP BY clause or be used in an aggregate function
Position: 8). Rolling back transaction.
org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while
executing the following:SELECT EX.EXAMPLE_ID, EX.EXAMPLE_TYPE_ID FROM
public.EXAMPLE EX GROUP BY EX.EXAMPLE_TYPE_ID (ERROR: column "ex.example_id"
must appear in the GROUP BY clause or be used in an aggregate function
Position: 8)
at
org.apache.ofbiz.entity.jdbc.SQLProcessor.executeQuery(SQLProcessor.java:446)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java:869)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.datasource.GenericHelperDAO.findListIteratorByCondition(GenericHelperDAO.java:141)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1552)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1586)
[ofbiz.jar:?]
at org.apache.ofbiz.entity.util.EntityQuery.query(EntityQuery.java:451)
[ofbiz.jar:?]
at
org.apache.ofbiz.entity.util.EntityQuery.queryList(EntityQuery.java:381)
[ofbiz.jar:?]
at org.apache.ofbiz.entity.util.EntityQuery$queryList$1.call(Unknown
Source) [ofbiz.jar:?]
at
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
[groovy-all-2.4.12.jar:2.4.12]
at
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
[groovy-all-2.4.12.jar:2.4.12]
at
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:117)
[groovy-all-2.4.12.jar:2.4.12]
at uk.co.robertheath.mobile.FooServices.getFoo(FooServices.groovy:31)
[script:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_112]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_112]
Kind Regards,
Wei
> Create a common theme
> -
>
> Key: OFBIZ-9138
> URL: https://issues.apache.org/jira/browse/OFBIZ-9138
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Fix For: Upcoming Release
>
> Attachments: common-theme-macro.svg, common-theme-screen.svg
>
>
> A first task to UI Improvement would be create a common that receive the
> existent code.
> The benefice would be have a framework/common who list all screens that
> available for theme surcharge, so without technology information (css/html or
> something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical
> element for theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common
> After the realization on this task, all current themes call theme/common for
> html rendering instead of framework/common, framework/images and
> framework/widget. Just pave the way for the next
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142046#comment-16142046 ] Deepak Dixit commented on OFBIZ-9138: - Fixed COMMON theme id display issue, removed the visualThemeSetId from COMMON theme. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142026#comment-16142026 ] Deepak Dixit commented on OFBIZ-9138: - Need to hide COMMON theme id from set visual theme popup. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141809#comment-16141809 ] Jacques Le Roux commented on OFBIZ-9138: Thanks Nicolas, This is quite an achievement! Just that we have an issue with scrum tests https://ci.apache.org/projects/ofbiz/logs/trunk/html/ I checked locally it's the same. We know the scrum does not always follow the best practices, so it could be that we need to improve the code or even the tests there... > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141450#comment-16141450 ] Nicolas Malin commented on OFBIZ-9138: -- Ok I finalized the commits serie : 1806134 : load VisualTheme and ModelTheme on different session and context 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit values from the theme definition 1806150 : migrate all other screen and scripts to exploit values from the theme definition 180615 : improve error message and announce the commit end :) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141410#comment-16141410 ] Nicolas Malin commented on OFBIZ-9138: -- Sure Deepak, I continue the work I think it will be correct it > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[
https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141369#comment-16141369
]
Deepak Dixit commented on OFBIZ-9138:
-
Hi [~soledad],
Please have a look at OFBIZ-9622, I think this is broken due to recent change.
{quote}
2017-08-25 12:01:17,506 |jsse-nio-8443-exec-4 |ModelScreenWidget |W| In
decorator-section-include could not find sections object in the context, not
rendering section with name [pre-body]
2017-08-25 12:01:17,513 |jsse-nio-8443-exec-4 |ModelScreen |E| Error rendering
screen component://common-theme/widget/CommonScreens.xml#GlobalDecorator:
java.lang.NullPointerException. Rolling back transaction.
{quote}
> Create a common theme
> -
>
> Key: OFBIZ-9138
> URL: https://issues.apache.org/jira/browse/OFBIZ-9138
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Attachments: common-theme-macro.svg, common-theme-screen.svg
>
>
> A first task to UI Improvement would be create a common that receive the
> existent code.
> The benefice would be have a framework/common who list all screens that
> available for theme surcharge, so without technology information (css/html or
> something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical
> element for theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common
> After the realization on this task, all current themes call theme/common for
> html rendering instead of framework/common, framework/images and
> framework/widget. Just pave the way for the next
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141341#comment-16141341 ] Jacques Le Roux commented on OFBIZ-9138: Oops forgot that step, no issues with it :) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141324#comment-16141324 ] Nicolas Malin commented on OFBIZ-9138: -- Hi Jacques, do you have already the problem after a "./gradlew loadAll" ? > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140817#comment-16140817 ] Nicolas Malin commented on OFBIZ-9138: -- The second step r1806084, I moved all images folder to common-theme The third step r1806091 and r1806093 I moved all ftl template from common to common-theme and all macro ftl libraries. I hope to break nothing at this time. The next steps will load the dynamic theme load on session > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140515#comment-16140515 ] Nicolas Malin commented on OFBIZ-9138: -- I commited a first step (engine and documentation) at 1806075 on trunk. I will continue to separate my commits to help the code review > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116535#comment-16116535 ] Jacques Le Roux commented on OFBIZ-9138: Thanks Nicolas for this easy to understand schemas :) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105634#comment-16105634 ] Nicolas Malin commented on OFBIZ-9138: -- It's now done, the common theme support the common screen redirection to the theme. For the session problem, I force to load the user pref at the looking. The single problem with that, if you change your theme on a webapp, it's currently not change in your others open sessions. In other word, if you have a browser tab in party and an other in product, if you change your theme the tab open with a party session, your product session keep your old preference. To reset it you need to logout from product. At this time I consider this as minor. So we can by theme surcharge : * widget properties * ftl template macro * common screen And I detect no regression. So if you want to play with it, it's the time ! :) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096443#comment-16096443 ] Nicolas Malin commented on OFBIZ-9138: -- Hello, I continue my work on this subject and success to pass the main problem that I detected the last time. I create an xml definition for the theme and three class : ModelTheme : a threadsafe class to load each theme definition Theme : is a runnable classe that contains a modelTheme and the specific visual theme selected ThemeFactory: to initialize in cache models and resolve easily a Theme from a visualThemeId With that, I modified OFBiz to set a theme on context for screen script and service, so when you need a value related to a theme, you just ask :) Each theme can extend an other theme (all theme extend common-theme). I realized some try and it's really fun. This open a multiple possibility, I imagine now to define a decorator API and each theme can surcharge the wanted element to indicate how it want render it. This is a POC, I appreciate if some other commiters can check this works for criticize it, because I move step by step and change my mind with each problem that I raised. So please I need some fresh eyes for some verification on my java class creation, the xsd definition and some other idea to improve this start. Oh The patch it's big so I isolate the ModelTheme adding on this commit https://github.com/nmalin/ofbiz-framework/commit/813b0aac473e32e71c9eef78ed18f9ffcb5e1cca Have fun > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842655#comment-15842655 ] Nicolas Malin commented on OFBIZ-9138: -- Thanks [~deepak.dixit], I appreciate the confirmation from an other commiter that we take a good way. I will continue this after finalize the flexible report > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842302#comment-15842302 ] Deepak Dixit commented on OFBIZ-9138: - Hi [~soledad], Moving common theme related stuff from framework to themes/common make sense to me, I rethink on my comment and realize that Its good idea to keep theme part out from core. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840280#comment-15840280 ] Nicolas Malin commented on OFBIZ-9138: -- Hi Deepak sorry for the latency, my concentration move on an other task :) After sharing with Taher, Julien and Gil on the apachecon eu , we prefer to move all rendering system out framework and keep only the model on the framework. But if you have some arguments to defend you idea, I'm yours > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734393#comment-15734393 ] Deepak Dixit commented on OFBIZ-9138: - Hi Nicolas, Can we use framework/common to put common theme? > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732136#comment-15732136 ] Nicolas Malin commented on OFBIZ-9138: -- I continue the work with : * with move macro ftl on common-theme * move uneeded properties from widget.properties commonWidget.properties present on common-theme to keep on first properties file only property related to widget model and not widget rendering * review some code on FindAutocompleteOptions.groovy and MacroFormRenderer.java to move rendering property use to FtlMacro or decorator screen POC available on https://github.com/nmalin/ApacheOFBiz/tree/common-theme > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15720367#comment-15720367 ] Nicolas Malin commented on OFBIZ-9138: -- As I informed on mailing I create a POC with success for the two first points but I think we need to storm about the name. currently I use themes/common for the directory and common-theme for the webapp. Your remarks ? > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)
