[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174462#comment-16174462
]
Jacques Le Roux commented on OFBIZ-9185:
This thread is related http://markmail.org/message/57ehpngp5c6ans6l
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116537#comment-16116537
]
Jacques Le Roux commented on OFBIZ-9185:
Thanks Jacopo,
Because it's currently not very useful, sometimes (actually most of the time)
fails and can be misleading I prefer to look at how to remove this service and
will do so if easily possible.
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116406#comment-16116406
]
Jacopo Cappellato commented on OFBIZ-9185:
--
Hi [~jacques.le.roux],
in that old commit I have renamed a broken link
(removeWorkEffort-->deleteWorkEffort) so that the existing "delete" link could
work. However, as it has been already commented in this ticket, the service as
is now is not very useful and we could either improve it or remove (I don't
have a strong opinion).
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116331#comment-16116331
]
Jacques Le Roux commented on OFBIZ-9185:
Hi [~jacopoc]
While looking for history, I found your commit
http://svn.apache.org/viewvc?view=revision&revision=434040.
You then (2006) said:
bq. I've commented a few (broken) links from the find work effort screen and
fixed the delete link that was pointing to a wrong request name; now deleting a
workeffort is possible even if there are still some oddities in the way that
page works (it's too complex to work fine and in fact it doesn't work well).
Would you agree that it's better to remove the deleteWorkEffort service and let
people handle it their way?
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082188#comment-16082188
]
Jacques Le Roux commented on OFBIZ-9185:
I tend to agree Deepak. I always found weird to have both deleting and
deprecating patterns in OFBiz.
For me the deprecating pattern is better for at least 2 reasons:
# Data can still be audited, even in cases that could be surprising helpful (ie
not foreseen when deciding to initially deleting)
# If the reason is because people would need place (less and less a problem
nowadays), then it's better to carefully review what really needs to deleted,
and then deletion be done with a custom SQL script.
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079502#comment-16079502
]
Deepak Dixit commented on OFBIZ-9185:
-
I think deleteWorkEffort service is not useful, as WorkEffort is very complex
data model so instead of deleting workEffort it should be managed through
status or from setting thruDate in assoc entities.
There is no sense to keep delete workEffort service.
Same apply for Party, Product, UserLogin etc.
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834659#comment-15834659
]
Jacques Le Roux commented on OFBIZ-9185:
BTW, I have to look closer in the RemoveRelated class, but it seems to me that
the remove-foreign-key is not even needed. You want to remove or not, that's
all. So if you use remove-related it means you want to get rid of the record/s
in the related entity. I'll be back :)
Actually I though proposed the remove-foreign-key attribute because of the
legacy behaviour which could else cause issues in custom projects.
So I finally think we should still use it as proposed above. Just that
something which is supposed to remove and don't is surprising, moreover after
more than 10 years :-o
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834422#comment-15834422
]
Jacques Le Roux commented on OFBIZ-9185:
Actually I even think we should do that by using remove-related with a default
remove-foreign-key attribute sets to no.
Because this issue is not only deleteWorkEffort but everywhere remove-related
is used.
If remove-foreign-key is set to yes then we 1st remove, from the WorkEffort
record, the value linking it to the related entity. Then the EE will not
prevent to remove the related entity, et voilà.
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833512#comment-15833512
]
Jacques Le Roux commented on OFBIZ-9185:
I thought wonder if this has never worked, maybe it has not been tested when
committed.
But I still wonder because I guess people delete WorkEffort entities since then.
> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
> Issue Type: Bug
> Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship
> with a RuntimeData or any of the entities Workeffort has a relation with (eg
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort,
> would be to add
> {code}
> relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service needs more work. The only solution I
> see is to remove the FK from the Workeffort (ie put null in the related field
> if it's not) and then deleted the related entity instead of directly calling
> remove-related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
