[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-16 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051750#comment-16051750 ] Deepak Dixit commented on OFBIZ-9409: - Created OFBIZ-9413 for currency uom update. > Add numeric code

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-16 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051741#comment-16051741 ] Deepak Dixit commented on OFBIZ-9409: - Thanks [~mbrohl] and [~jacques.le.roux] for review and

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-16 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051728#comment-16051728 ] Jacques Le Roux commented on OFBIZ-9409: Hi Michael, Ah, indeed, I did not look down to the end

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-16 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051675#comment-16051675 ] Michael Brohl commented on OFBIZ-9409: -- Jacques, seems to be a misunderstanding: the patch already

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-16 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051676#comment-16051676 ] Michael Brohl commented on OFBIZ-9409: -- Hi [~deepak.dixit], +1 for your patch with a change to use

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-16 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051656#comment-16051656 ] Jacques Le Roux commented on OFBIZ-9409: Hi Pierre, Why would you want to use the 'short-varchar'

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-16 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051599#comment-16051599 ] Deepak Dixit commented on OFBIZ-9409: - Thanks Pierre for review, I simply took reference from

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-15 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050996#comment-16050996 ] Pierre Smits commented on OFBIZ-9409: - Hi [~deepak.dixit], I reviewed your patch file. Maybe you

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-15 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050900#comment-16050900 ] Deepak Dixit commented on OFBIZ-9409: - While adding nurmericCode to currency UOM, I found we need to

[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM

2017-06-15 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050344#comment-16050344 ] Deepak Dixit commented on OFBIZ-9409: - For this we need to extend Uom entity and add new field