[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743088#comment-16743088 ] Jacques Le Roux commented on OFBIZ-9677: Thanks Paul, Backported in R18 r1851361 R17 r1851359 R16 r1851357 > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743077#comment-16743077 ] Paul Foxworthy commented on OFBIZ-9677: --- There was a problem with a boundary condition when there is single reservation and its quantity exactly matches the quantity to pack. The tests now pass locally. Committed in r1851353. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741556#comment-16741556 ] Jacques Le Roux commented on OFBIZ-9677: Before reverting all (easy), I let Paul have a look at it. Notably if he should not have changed the tests which fail, say 3 days... > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741526#comment-16741526 ] Michael Brohl commented on OFBIZ-9677: -- The issue should at least be updated with the correct affects and fix versions. If the commit(s) introduced a new bug, they should be reverted and corrected before being committed again. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741515#comment-16741515 ] Pierre Smits commented on OFBIZ-9677: - I would suggest not to backport when the 'affected version' does not indicate that it experienced in an already released version/branch. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741512#comment-16741512 ] Jacques Le Roux commented on OFBIZ-9677: Hi Paul; Actually I backported too early. There is a test problem with your commit, see bottom of OFBIZ-9115 > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741454#comment-16741454 ] Paul Foxworthy commented on OFBIZ-9677: --- Thanks Jacques. Sorry I didn't get to this. I will commit with backports in future. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741276#comment-16741276 ] Jacques Le Roux commented on OFBIZ-9677: Backported in R18 r1851163 R17 r1851164 R16 r1851165 after resolving a conflict by hand > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739224#comment-16739224 ] Jacques Le Roux commented on OFBIZ-9677: Hi Paul, Any reasons why you did not backport? > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738959#comment-16738959 ] Paul Foxworthy commented on OFBIZ-9677: --- Committed in r1850914. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407592#comment-16407592 ] Jacques Le Roux commented on OFBIZ-9677: I see, did not spot that, thanks Paul > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407530#comment-16407530 ] Paul Foxworthy commented on OFBIZ-9677: --- Updated patch that fixes nasty problem when there was only one reservation - it was packing quantity from the reservation, not the quantity the user asked for. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213885#comment-16213885 ] Pierre Smits commented on OFBIZ-9677: - I agree. You can only pick/pack what is on Hand (QoH). > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy > Labels: pack, reservation > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155782#comment-16155782 ] Jacques Le Roux commented on OFBIZ-9677: Hi Paul, +1 I agree about the idea and the code > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy > Labels: pack, reservation > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
