[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624562#comment-16624562 ] Suraj Khurana commented on OFBIZ-9761: -- Thanks [~amit.gadaley], I have back ported it to Release16.11 at revision #1841664. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Suraj Khurana >Priority: Major > Labels: backport-needed > Fix For: Release Branch 16.11, Release Branch 17.12 > > Attachments: OFBIZ-9761-16.11.patch, OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624544#comment-16624544 ] Amit Gadaley commented on OFBIZ-9761: - Hi [~arunpati] I have provided the patch for release OFBIZ.16.11. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Labels: backport-needed > Fix For: Trunk > > Attachments: OFBIZ-9761-16.11.patch, OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375521#comment-16375521 ] Arun Patidar commented on OFBIZ-9761: - Committed changes in trunk at rev: 1825216 in 17.12 at rev: 1825217 There are some conflicts while applying the patch on 16.11 so will commit in 16.11 after resolving conflicts. Thanks [~amit.gadaley] for your contribution and [~mbrohl] for reviewing and suggestions. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Labels: backport-needed > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375508#comment-16375508 ] Michael Brohl commented on OFBIZ-9761: -- Thanks for the link and your efforts. I have no obections at the moment, please go ahead. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375506#comment-16375506 ] Arun Patidar commented on OFBIZ-9761: - Hi [~mbrohl] , JCB checks looks good to me as per details in document - [https://www.regular-expressions.info/creditcard.html] For now, I am committing changes. Please let me know if you have any suggestions here. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375475#comment-16375475 ] Michael Brohl commented on OFBIZ-9761: -- Thanks [~amit.gadaley], technically this looks good to me now. Just noticed that the JCB checks significantly changed in the patch (first4digs), is this correct, also for older credit cards? > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375473#comment-16375473 ] Amit Gadaley commented on OFBIZ-9761: - Updated the patch. Thanks, [~mbrohl] and [~arunpati] for the guidance. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375437#comment-16375437 ] Michael Brohl commented on OFBIZ-9761: -- Hi [~amit.gadaley], the new patch still contains the pattern .equals() instead of .equals(). Can you please fix this? > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375435#comment-16375435 ] Amit Gadaley commented on OFBIZ-9761: - Updated the patch. Thanks, [~mbrohl] and [~arunpati] for the guidance. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214067#comment-16214067 ] Michael Brohl commented on OFBIZ-9761: -- [~amit.gadaley], we have change the way of using the equals method recently (.equals()) so your patch cannot be applied and the equals methods are the other way around. Can you please provide an updated patch? Thanks! Michael > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213911#comment-16213911 ] Pierre Smits commented on OFBIZ-9761: - I guess that new credit cards pop up frequently. A page in confluence where to find additional information on credit cards and their regex would be highly appreciated by adopters/developers, etc. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
