[jira] [Commented] (OFBIZ-9870) [Refactoring] Package org.apache.ofbiz.accounting.invoice
[ https://issues.apache.org/jira/browse/OFBIZ-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287430#comment-16287430 ] Jacques Le Roux commented on OFBIZ-9870: I made a better answer at http://markmail.org/message/zs5dm5342sltbvsd > [Refactoring] Package org.apache.ofbiz.accounting.invoice > - > > Key: OFBIZ-9870 > URL: https://issues.apache.org/jira/browse/OFBIZ-9870 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-9870_org.apache.ofbiz.accounting.invoice.InvoiceServices_refactoring.patch, > > OFBIZ-9870_org.apache.ofbiz.accounting.invoice.InvoiceWorker_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9870) [Refactoring] Package org.apache.ofbiz.accounting.invoice
[ https://issues.apache.org/jira/browse/OFBIZ-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287400#comment-16287400 ] Jacques Le Roux commented on OFBIZ-9870: Then you should say, we should RE-discuss this. It has been discussed in the past and the consensus is that we don't remove trailing spaces in patches because it hurts reviewers with false changes. So please if you want this dicussed start a thread in dev ML. bq. You can adjust your IDE/Eclipse to ignore whitepaces in diffs, so you only see the real changes. That works very good. I'm reviewing directly in my email clients, so this is not relevant for me. Maybe a solution would be to suggest another reviewing process, THAT can be discussed I think. And then possibly removing trailing spaces would be a good thing indeed. > [Refactoring] Package org.apache.ofbiz.accounting.invoice > - > > Key: OFBIZ-9870 > URL: https://issues.apache.org/jira/browse/OFBIZ-9870 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-9870_org.apache.ofbiz.accounting.invoice.InvoiceServices_refactoring.patch, > > OFBIZ-9870_org.apache.ofbiz.accounting.invoice.InvoiceWorker_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9870) [Refactoring] Package org.apache.ofbiz.accounting.invoice
[ https://issues.apache.org/jira/browse/OFBIZ-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287283#comment-16287283 ] Jacques Le Roux commented on OFBIZ-9870: Thanks Michael, Dennis, Please Dennis adjust your IDE or similar to not remove trailing white spaces when you create a patch, especially a big one, you may do that temporarily. Consider that else reviewers have to be confronted with a lot of false changes , thanks! > [Refactoring] Package org.apache.ofbiz.accounting.invoice > - > > Key: OFBIZ-9870 > URL: https://issues.apache.org/jira/browse/OFBIZ-9870 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-9870_org.apache.ofbiz.accounting.invoice.InvoiceServices_refactoring.patch, > > OFBIZ-9870_org.apache.ofbiz.accounting.invoice.InvoiceWorker_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
