[jira] [Commented] (OFBIZ-9905) Use "Create" instead of "Create New" on the various screens of all components

2019-04-28 Thread sourabh jain (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828897#comment-16828897
 ] 

sourabh jain commented on OFBIZ-9905:
-

Thank you, Jacques.

> Use "Create" instead of "Create New" on the various screens of all components
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9905.patch, OFBIZ-9905.patch, OFBIZ-9905.patch, 
> UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9905) Use "Create" instead of "Create New" on the various screens of all components

2019-04-27 Thread sourabh jain (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827488#comment-16827488
 ] 

sourabh jain commented on OFBIZ-9905:
-

Provided patch with removing the unused UI labels. Didn't remove some labels 
which are used to signify the proper title property.

> Use "Create" instead of "Create New" on the various screens of all components
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9905.patch, OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9905) Use "Create" instead of "Create New" on the various screens of all components

2019-04-27 Thread sourabh jain (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827472#comment-16827472
 ] 

sourabh jain commented on OFBIZ-9905:
-

Hi Jacques,

Yes, I didn't remove any labels. I'll rectify all the unused labels in my 
commit and surely removed in the next patch.

No, I didn't let that in labels file. Actually, some labels are used in the 
title property so I didn't remove them.

> Use "Create" instead of "Create New" on the various screens of all components
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9905.patch, OFBIZ-9905.patch, OFBIZ-9905.patch, 
> UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9905) Use "Create" instead of "Create New" on the various screens of all components

2019-04-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817354#comment-16817354
 ] 

Jacques Le Roux commented on OFBIZ-9905:


I'd like to commit this, but I'd prefer answers before :)

> Use "Create" instead of "Create New" on the various screens of all components
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9905.patch, OFBIZ-9905.patch, OFBIZ-9905.patch, 
> UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9905) Use "Create" instead of "Create New" on the various screens of all components

2019-04-05 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810840#comment-16810840
 ] 

Jacques Le Roux commented on OFBIZ-9905:


Hi sourabh,

In the last patch I see no removing of the now unused(?) labels, normal?

Actually it maybe makes sense because if I takes the 1st one: 
AccountingCreateNewInvoice. You replace it in InvoiceSubTabBar but it's still 
used in NewInvoice screen. Is it voluntarily that you let this instance, either 
in the labels file or in the screen?

> Use "Create" instead of "Create New" on the various screens of all components
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9905.patch, OFBIZ-9905.patch, OFBIZ-9905.patch, 
> UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9905) Use "Create" instead of "Create New" on the various screens of all components

2019-03-09 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788603#comment-16788603
 ] 

Pierre Smits commented on OFBIZ-9905:
-

Please set the  'affects version' and 'components'  fields. 

Also, as a side question, why should this be considered to have a 'major' 
priority?

> Use "Create" instead of "Create New" on the various screens of all components
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: sourabh jain
>Priority: Major
> Attachments: OFBIZ-9905.patch, OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)