Suraj Khurana created OFBIZ-10337:
-------------------------------------
Summary: Check for only QOH while doing reservations
Key: OFBIZ-10337
URL: https://issues.apache.org/jira/browse/OFBIZ-10337
Project: OFBiz
Issue Type: Improvement
Reporter: Suraj Khurana
Assignee: Suraj Khurana
While checking around code around inventory reservations, I was surprised to
see that _*reserveProductInventory*_ service only checks for QOH quantity
greater than one apart from that when _*reserveFromInventoryItemInline*_ is
called, it checks for ATP confirming system to behave as required.
Everything works fine but this is redundant code and we can have check for ATP
at top level so make reservations logic works faster. We can improve this flow
by adding ATP check at _*reserveProductInventory*_ service as well.
We can check QOH being on safer side, but ideally a system will always have
lesser ATP than QOH and logically we should only check for ATP while doing
reservations.
Same discussion is also available on dev ML.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
