Jacques Le Roux created OFBIZ-11470:
---------------------------------------
Summary: Ensure that the SameSite attribute is set to 'strict' for
all cookies.
Key: OFBIZ-11470
URL: https://issues.apache.org/jira/browse/OFBIZ-11470
Project: OFBiz
Issue Type: Sub-task
Components: ALL APPLICATIONS
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
As reported by OWASP ZAP:
bq. A cookie has been set without the SameSite attribute, which means that the
cookie can be sent as a result of a 'cross-site' request. The SameSite
attribute is an effective counter measure to cross-site request forgery,
cross-site script inclusion, and timing attacks.
The solution was not obvious in OFBiz for 2 reasons:
# There is no HttpServletResponse::setHeader. So we need to use a filter
(SameSiteFilter) and even that is not enough because of 2:
# To prevent session fixation we force Tomcat to generates a new jsessionId,
ultimately put in cookie, in LoginWorker::login. So we need to add a call to
SameSiteFilter::addSameSiteCookieAttribute in
setResponseBrowserDefaultSecurityHeaders.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
