[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2021-02-11 Thread Michael Brohl (Jira) 


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6705:
-
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, 
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:  
>   if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
>  = request.getParameter("viewIndex") ? 
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
>  = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: 
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2020-02-27 Thread Michael Brohl (Jira) 


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6705:
-
Affects Version/s: Release Branch 17.12
   Release Branch 18.12
   Trunk

> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: 17.12.02
>
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, 
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:  
>   if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
>  = request.getParameter("viewIndex") ? 
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
>  = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: 
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2020-02-27 Thread Michael Brohl (Jira) 


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6705:
-
Fix Version/s: (was: 17.12.02)

> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, 
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:  
>   if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
>  = request.getParameter("viewIndex") ? 
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
>  = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: 
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2020-02-27 Thread Michael Brohl (Jira) 


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6705:
-
Fix Version/s: (was: 17.12.01)
   17.12.02

> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: 17.12.02
>
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, 
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:  
>   if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
>  = request.getParameter("viewIndex") ? 
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
>  = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: 
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2020-02-09 Thread Michael Brohl (Jira) 


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6705:
-
Attachment: OFBIZ-6705_2020.patch

> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, 
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:  
>   if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
>  = request.getParameter("viewIndex") ? 
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
>  = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: 
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)