[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-9351:
-
Attachment: OFBIZ-9351_plugins.patch
I think I just missed some traces in Birt so adding another patch for plugins &
reopening it.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-9351:
-
Attachment: OFBIZ-9351.patch
Removed field types "id-ne", "id-long-ne" and "id-vlong-ne" from fieldtype*.xml
files in this patch.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-9351:
Affects Version/s: Trunk
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-9351:
Issue Type: Improvement (was: Task)
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-9351:
-
Attachment: OFBIZ-9351_plugins.patch
Following changes applied on plugins:
Replaced fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id",
"id-long" and "id-vlong" respectively which are primary keys.
The patch also covers the field names like "parentTypeId" as it will always be
empty for some record that starts the hierarchy.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-9351:
-
Attachment: OFBIZ-9351.patch
Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id",
"id-long" and "id-vlong" respectively which are primary keys.
The patch also covers the field names like "parentTypeId" as it will always be
empty for some record that starts the hierarchy.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: OFBIZ-9351.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9351:
---
Description:
As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added to
implement validations on data. But, because the validations where only
implemented in some place like webtools, it contradicts the distinction to be
upheld on various layers. So it is better to remove these field types. So we
will remove all those field types and will create sub tickets to replace them
in entity definitions by corresponding "id" types.
When replacing the "not empty" field types in entity definitions by
corresponding "id" types we will add a *not-null="true"* attribute to "makes
the field NOT NULL on the database (like primary key fields)" as explained in
"not-null" documentation in fieldtypemodel.xsd. We will finally clean the
documentation of the "not-null" in fieldtypemodel.xsd.
Related Links:
http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
http://markmail.org/message/otec62xiwkpjttkq
A more vivid description:
http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
was:
As discussed
http://markmail.org/message/d2tpovewhtotukwa
There are various field types in FieldType*.xml files that were added initially
to implement validations on data but as it contradicts the distinction to be
upheld on various layers, it is better to remove these field types.
Field Types with "not empty" like "id-ne", "id-long-ne" etc have no
implementation underneath. So we will remove all those field types and will
create sub tickets to update occurrences.
Related Links:
http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
http://markmail.org/message/otec62xiwkpjttkq
A more vivid description:
http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[ https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9351: --- Description: As discussed http://markmail.org/message/d2tpovewhtotukwa There are various field types in FieldType*.xml files that were added initially to implement validations on data but as it contradicts the distinction to be upheld on various layers, it is better to remove these field types. Field Types with "not empty" like "id-ne", "id-long-ne" etc have no implementation underneath. So we will remove all those field types and will create sub tickets to update occurrences. Related Links: http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html http://markmail.org/message/otec62xiwkpjttkq A more vivid description: http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k was: As discussed http://markmail.org/message/d2tpovewhtotukwa There are various field types in FieldType*.xml files that are added initially to implement validations on data but as it contradicts the distinction to be upheld on various layers, it is better to remove these field types. Field Types with "not empty" like "id-ne", "id-log-ne" etc have no implementation underneath. So will be removing all those field types and will create sub tickets to update its occurrences. Related Links: http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html http://markmail.org/message/otec62xiwkpjttkq A more vivid description: http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k > Remove unnecessary field types > -- > > Key: OFBIZ-9351 > URL: https://issues.apache.org/jira/browse/OFBIZ-9351 > Project: OFBiz > Issue Type: Task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > > As discussed > http://markmail.org/message/d2tpovewhtotukwa > There are various field types in FieldType*.xml files that were added > initially to implement validations on data but as it contradicts the > distinction to be upheld on various layers, it is better to remove these > field types. > Field Types with "not empty" like "id-ne", "id-long-ne" etc have no > implementation underneath. So we will remove all those field types and will > create sub tickets to update occurrences. > Related Links: > http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html > http://markmail.org/message/otec62xiwkpjttkq > A more vivid description: > http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k -- This message was sent by Atlassian JIRA (v6.3.15#6346)
