[
https://issues.apache.org/jira/browse/OFBIZ-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9565:
---------------------------------
Attachment: OFBIZ-9565_org.apache.ofbiz.base.lang.test_bugfixes.patch
- fixed some diamond operators
- didn't fix the main issue (listed in description), because the method which
was used, was only used for testing, which makes the issue irrelevant
> [FB] Package org.apache.ofbiz.base.lang.test
> --------------------------------------------
>
> Key: OFBIZ-9565
> URL: https://issues.apache.org/jira/browse/OFBIZ-9565
> Project: OFBiz
> Issue Type: Sub-task
> Components: base
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-9565_org.apache.ofbiz.base.lang.test_bugfixes.patch
>
>
> - ComparableRangeTests.java:82, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
> Return value of method without side effect is ignored
> This code calls a method and ignores the return value. However our analysis
> shows that the method (including its implementations in subclasses if any)
> does not produce any effect other than return value. Thus this call can be
> removed.
> We are trying to reduce the false positives as much as possible, but in some
> cases this warning might be wrong. Common false-positive cases include:
> - The method is designed to be overridden and produce a side effect in other
> projects which are out of the scope of the analysis.
> - The method is called to trigger the class loading which may have a side
> effect.
> - The method is called just to get some exception.
> If you feel that our assumption is incorrect, you can use a @CheckReturnValue
> annotation to instruct FindBugs that ignoring the return value of this method
> is acceptable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
