Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145807342
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/batch/JoinBatchBindingSetUpdater.java
---
@@ -74,53
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145809414
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/CommonNodeMetadataImpl.java
---
@@ -0,0
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145809455
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/CommonNodeMetadataImpl.java
---
@@ -0,0
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145811379
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/StateNodeMetadata.java
---
@@ -0,0 +1,91 @@
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/245
the complexity of the changes shouldn't matter to git, I was able to
squash all the commits into 1 with no conflicts. I am still seeing compile
errors in GeoFunctionsIT
---
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211490#comment-16211490
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211493#comment-16211493
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211491#comment-16211491
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211570#comment-16211570
]
ASF GitHub Bot commented on RYA-405:
Github user asfgit commented on the issue:
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145808226
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/CommonNodeMetadata.java
---
@@ -65,6 +67,14
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145810151
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/JoinMetadata.java
---
@@ -224,6 +231,20 @@
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145809880
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/ConstructQueryMetadata.java
---
@@ -199,13
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145810046
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/FilterMetadata.java
---
@@ -221,6 +228,20 @@
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/245
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/533/Build
result:
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145807979
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/batch/serializer/JoinBatchInformationTypeAdapter.java
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145810280
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/PeriodicQueryMetadata.java
---
@@ -271,6
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145811793
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/util/AggregationStateMetadataVisitor.java
---
@@
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211454#comment-16211454
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on the issue:
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/245
sure, something of this scale, it would be nice to have it split up into
smaller commits. Do you not have create issue rights on Jira? If not, let me
know which tickets need making and
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211458#comment-16211458
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on the issue:
[
https://issues.apache.org/jira/browse/RYA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211626#comment-16211626
]
ASF GitHub Bot commented on RYA-284:
Github user asfgit commented on the issue:
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/246
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/532/Failed
Tests:
[
https://issues.apache.org/jira/browse/RYA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211638#comment-16211638
]
ASF GitHub Bot commented on RYA-284:
Github user meiercaleb closed the pull request at:
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145810475
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/QueryMetadata.java
---
@@ -215,6 +220,20 @@
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211441#comment-16211441
]
ASF GitHub Bot commented on RYA-405:
Github user jomach commented on the issue:
Github user jomach commented on the issue:
https://github.com/apache/incubator-rya/pull/245
Can we create tasks for each point that need change ?
---
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211488#comment-16211488
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211492#comment-16211492
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145780275
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/resolver/RyaTripleContext.java
---
@@ -19,28 +19,20 @@
* under the License.
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211494#comment-16211494
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211489#comment-16211489
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on a diff in the pull request:
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145781632
--- Diff:
extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloExecuteSparqlQuery.java
---
@@ -37,21 +37,15 @@
import
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145780732
--- Diff:
common/rya.api/src/test/java/org/apache/rya/api/query/strategy/wholerow/MockRdfConfiguration.java
---
@@ -22,7 +22,7 @@
import
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145781500
--- Diff:
extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloCreatePeriodicPCJ.java
---
@@ -45,12 +44,12 @@
import
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145780360
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/resolver/RyaTypeResolver.java
---
@@ -23,28 +23,27 @@
import
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145782313
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/IndexPlanValidator/ValidIndexCombinationGenerator.java
---
@@ -86,11 +81,8 @@
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145781552
--- Diff:
extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloDeletePeriodicPCJ.java
---
@@ -43,11 +42,11 @@
import
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145807643
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/batch/JoinBatchInformation.java
---
@@ -1,4 +1,6 @@
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145812197
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/util/StopNodeVisitor.java
---
@@ -0,0 +1,54 @@
Github user meiercaleb closed the pull request at:
https://github.com/apache/incubator-rya/pull/246
---
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/240#discussion_r145810960
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/StateNodeMetadata.java
---
@@ -0,0 +1,91 @@
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/240
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/534/
---
Github user jomach commented on the issue:
https://github.com/apache/incubator-rya/pull/245
@isper3at Sorry I cannot undo that. This is taking a lot more effort that I
initially thought because of the geoindexing. I'm thinking about closing this
PR and open a new one when I have
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211367#comment-16211367
]
ASF GitHub Bot commented on RYA-405:
Github user jomach commented on the issue:
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/245
I'm checking out your commit now to see why geoindexing would give you
grief.
I don't think a new PR is required, we can just not do the review until
after it builds, change the title to
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211376#comment-16211376
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on the issue:
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/245
you have 2 commits that have the same message with different hashes, can
you clean that up and get this to build?
---
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211327#comment-16211327
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on the issue:
GitHub user meiercaleb opened a pull request:
https://github.com/apache/incubator-rya/pull/246
RYA-284: updated to support the use of bloom filter
## Description
Modified Range construction in AccumuloRyaQueryEngine to be compatible with
Bloom Filters that only use Row
[
https://issues.apache.org/jira/browse/RYA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211386#comment-16211386
]
ASF GitHub Bot commented on RYA-284:
GitHub user meiercaleb opened a pull request:
Github user jomach commented on the issue:
https://github.com/apache/incubator-rya/pull/245
So I found why. I tested the minicluster in a new project alone and it
works fine. Seems to be the Pom.xml I will push my other commits that are local
until now
---
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211412#comment-16211412
]
ASF GitHub Bot commented on RYA-405:
Github user jomach commented on the issue:
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/245
I'm still confused as to why your commits are overlapping so much and why
you can't squash the commits.
---
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211415#comment-16211415
]
ASF GitHub Bot commented on RYA-405:
Github user isper3at commented on the issue:
Github user jomach commented on the issue:
https://github.com/apache/incubator-rya/pull/245
Because The changes are not trivial...
---
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145724613
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/RdfCloudTripleStoreConfigurationBuilder.java
---
@@ -123,7 +123,7 @@ public B
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211423#comment-16211423
]
ASF GitHub Bot commented on RYA-405:
Github user jomach commented on the issue:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211427#comment-16211427
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211428#comment-16211428
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145730329
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/domain/RyaType.java ---
@@ -93,10 +93,7 @@ public boolean equals(final Object o) {
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145731794
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/domain/StatementMetadata.java
---
@@ -23,26 +23,16 @@
import java.util.HashMap;
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145724742
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/RdfCloudTripleStoreConfigurationBuilder.java
---
@@ -88,8 +88,8 @@ public B
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211430#comment-16211430
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211431#comment-16211431
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211429#comment-16211429
]
ASF GitHub Bot commented on RYA-405:
Github user ejwhite922 commented on a diff in the pull request:
65 matches
Mail list logo
