[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Github user amihalik commented on the issue: https://github.com/apache/incubator-rya/pull/115 @joshelser thanks a lot for finding those libraries and reading the docs in detail to find the equivalent to ParametersAreNonNullByDefault. I've updated the PR with your findings, and if there are no more comments, I'll pull it into master tomorrow. (Note that the Jenkins failure is the result of some test failures that I've fixing in another PR). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Github user joshelser commented on the issue: https://github.com/apache/incubator-rya/pull/115 Not sure about ParametersAreNonNullByDefault, curiously, it's mentioned https://github.com/stephenc/findbugs-annotations/blob/master/src/spec/javadoc/edu/umd/cs/findbugs/annotations/DefaultAnnotationForParameters.html#L87-L91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Github user joshelser commented on the issue: https://github.com/apache/incubator-rya/pull/115 ThreadSafe and Immutable are available in https://github.com/stephenc/jcip-annotations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Github user isper3at commented on the issue: https://github.com/apache/incubator-rya/pull/115 Just the Nullable annotation. I imagine it has something to do with findbugs, but it seems odd that we would have to use the 3rd party annotation over the java one. I kinda wish we could link the // SEE RYA-211 with an actual javadoc link to jira --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---