[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user ejwhite922 commented on the issue: https://github.com/apache/incubator-rya/pull/264 @kchilton2 do you have any preference on the suggested solutions? ---
[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user ejwhite922 commented on the issue:
https://github.com/apache/incubator-rya/pull/264
System.getProperty("user.home") returns paths with backslashes in Windows
(i.e. "C:\\Users\\" is returned). The parsing of this fails in a
call to String.replaceFirst(String regex, String replacement) since the
backslashes aren't escaped as needed for the replacement param string. The
paths used in the unit test don't affect this since
System.getProperty("user.home") is what's causing it to fail (called inside
RyaCommand.loadData).
---
[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user kchilton2 commented on the issue:
https://github.com/apache/incubator-rya/pull/264
What does System.getProperty("user.home") look like when you're running on
Windows? If it has forward slashes, then the test should also use forward
slashes since you will be providing a Windows path, not a Linux one.
---
[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user ejwhite922 commented on the issue:
https://github.com/apache/incubator-rya/pull/264
@kchilton2 @pujav65
Both the test and shell command fail in Windows since it will return a path
for rootedFile without file separators. Another option is we could set the
path back to its native file separators after the regex replacements are done.
final String userHome =
FilenameUtils.separatorsToUnix(System.getProperty("user.home"));
final Path rootedFile = Paths.get(
FilenameUtils.separatorsToSystem(file.replaceFirst("^~", userHome)) );
---
[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user pujav65 commented on the issue: https://github.com/apache/incubator-rya/pull/264 I like what Eric did. Is the issue that the test is failing, or that this shell command just doesn't work in windows? If the latter, then Eric's approach seems fine. If the former, then maybe Kevin is right and we should just fix the test to use File.separator() or something like that. I looked at the underlying implementation of loadStatementsFile, and it delegates to Sesame/OpenRDF. I don't like Eric's suggestion of replaceAll -- its less readable. ---
[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user ejwhite922 commented on the issue:
https://github.com/apache/incubator-rya/pull/264
An alternative could be to escape all '\\' characters instead of changing
to '/'. Would this be a better solution?
final String userHome = System.getProperty("user.home");
// Replace all '\\' with '' (escaping for regex and again for java)
final String escapedUserHome = userHome.replaceAll("",
"");
final Path rootedFile = Paths.get( file.replaceFirst("^~", escapedUserHome)
);
---
[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/264 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/668/ ---
[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user ejwhite922 commented on the issue: https://github.com/apache/incubator-rya/pull/264 asfbot build ---
[GitHub] incubator-rya issue #264: RYA-447 Fixed issue building rya.shell under Windo...
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/264 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/664/Failed Tests: 3incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.prospector: 3org.apache.rya.prospector.mr.ProspectorTest.testCountorg.apache.rya.prospector.service.ProspectorServiceEvalStatsDAOTest.testCountorg.apache.rya.prospector.service.ProspectorServiceEvalStatsDAOTest.testNoAuthsCount ---
