[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-rya/pull/191


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen

[jdasch]

Github user jdasch commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/191#discussion_r130889403
  
--- Diff: extras/rya.benchmark/pom.xml ---
@@ -106,11 +106,29 @@
 
 
 
-src/main/gen
+src/gen/java
 
org.apache.rya.benchmark.query
 
 
 
+
--- End diff --

Plugin execution is unnecessary if code is stored in 
${project.build.directory}/generated-sources.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen

[ejwhite922]

GitHub user ejwhite922 opened a pull request:

https://github.com/apache/incubator-rya/pull/191

RYA-306 Remove rya.benchmark committed gen

## Description
Deleted the committed generated source code in rya.benchmark from git.  It 
is now generated and ignored by git so when building changes to those files 
they don't show up as changed files in git.
Also, other projects that use generated source now append the license 
header to the generated files.  The license header is placed in the top level 
Rya project under "resources" so all projects can access it and has a property 
in the rya parent pom called "license.header.file".

### Tests
Build

### Links
[Jira](https://issues.apache.org/jira/browse/RYA-306)

### Checklist
- [ ] Code Review
- [ ] Squash Commits

 People To Review
@meiercaleb 
@amihalik 
@jdasch


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ejwhite922/incubator-rya 
RYA-306_RemoveBenchmarkGen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rya/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #191


commit 9c1b7946a361636a3d616898c8d261dfafa04de4
Author: eric.white 
Date:   2017-08-01T15:32:06Z

RYA-306 Removed rya.benchmark gen source files from git.  Made all 
generated files appear automatically in their corresponding Eclipse project 
.classpath file when updating through Maven.

commit a994f25bbafa00b00628d8ee595f88ac22ba819e
Author: eric.white 
Date:   2017-08-01T21:04:47Z

RYA-306 Commit #2. Added license header to generated source files in other 
projects.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---