[GitHub] incubator-rya pull request #242: RYA-402 Create Kafka reusable test code pro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-rya/pull/242


---

[GitHub] incubator-rya pull request #242: RYA-402 Create Kafka reusable test code pro...

[kchilton2]

Github user kchilton2 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/242#discussion_r144101585
  
--- Diff: test/kafka/pom.xml ---
@@ -0,0 +1,82 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+org.apache.rya
+rya.test.parent
+3.2.12-incubating-SNAPSHOT
+
+
+4.0.0
+rya.test.kafka
+
+Apache Rya Test Kafka
+
+This module contains the Rya Test Kakfa components that help write 
Kafka
+based integration tests.
+
+
+
+
+
+org.apache.kafka
+kafka-clients
+
+
+
+org.apache.kafka
+kafka-clients
+test
+
+
+
+org.apache.kafka
+kafka_2.11
+
+
+slf4j-log4j12
+org.slf4j
+
+
+
+
+
+org.apache.kafka
+kafka_2.11
+test
+compile
+
+
+slf4j-log4j12
+org.slf4j
+
+
+
+
+
+
+junit
+junit
+4.12
--- End diff --

Removed.


---

[GitHub] incubator-rya pull request #242: RYA-402 Create Kafka reusable test code pro...

[jdasch]

Github user jdasch commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/242#discussion_r144007026
  
--- Diff: test/kafka/pom.xml ---
@@ -0,0 +1,82 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+org.apache.rya
+rya.test.parent
+3.2.12-incubating-SNAPSHOT
+
+
+4.0.0
+rya.test.kafka
+
+Apache Rya Test Kafka
+
+This module contains the Rya Test Kakfa components that help write 
Kafka
+based integration tests.
+
+
+
+
+
+org.apache.kafka
+kafka-clients
+
+
+
+org.apache.kafka
+kafka-clients
+test
+
+
+
+org.apache.kafka
+kafka_2.11
+
+
+slf4j-log4j12
+org.slf4j
+
+
+
+
+
+org.apache.kafka
+kafka_2.11
+test
+compile
+
+
+slf4j-log4j12
+org.slf4j
+
+
+
+
+
+
+junit
+junit
+4.12
--- End diff --

Not sure if you still need this version override.  If you do, I'll take a 
wag at it when I tackle RYA-366.


---

[GitHub] incubator-rya pull request #242: RYA-402 Create Kafka reusable test code pro...

[kchilton2]

GitHub user kchilton2 opened a pull request:

https://github.com/apache/incubator-rya/pull/242

RYA-402 Create Kafka reusable test code project.


## Description
>What Changed?
[Brief Description of what changed]

### Tests
>Coverage?

[Description of what tests were written]

### Links
[Jira](https://issues.apache.org/jira/browse/RYA-NUMBER)

### Checklist
- [ ] Code Review
- [ ] Squash Commits

 People To Reivew
[Add those who should review this]


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kchilton2/incubator-rya RYA-402

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rya/pull/242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #242


commit 156a18b0edb0174352cb0321daeca5c7ca668e57
Author: kchilton2 
Date:   2017-10-10T22:36:25Z

RYA-402 Create Kafka reusable test code project.




---