[GitHub] incubator-rya pull request #286: RYA-467 update topic cleanup.policy

2018-04-16 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-rya/pull/286


---

[GitHub] incubator-rya pull request #286: RYA-467 update topic cleanup.policy

2018-04-02 Thread ejwhite922 
Github user ejwhite922 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/286#discussion_r178586652
  
--- Diff: 
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/interactor/KafkaTopicPropertiesBuilder.java
 ---
@@ -0,0 +1,46 @@
+package org.apache.rya.streams.kafka.interactor;
--- End diff --

Add license


---

[GitHub] incubator-rya pull request #286: RYA-467 update topic cleanup.policy

2018-04-02 Thread ejwhite922 
Github user ejwhite922 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/286#discussion_r178588294
  
--- Diff: 
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/interactor/KafkaTopicPropertiesBuilder.java
 ---
@@ -0,0 +1,46 @@
+package org.apache.rya.streams.kafka.interactor;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.Optional;
+import java.util.Properties;
+
+/**
+ * Properties builder to be used when creating new Kafka Topics.
+ *
+ * Descriptions of properties can be found at
+ * {@link https://kafka.apache.org/documentation/#topicconfigs}
+ */
+public class KafkaTopicPropertiesBuilder {
+/*- Cleanup Policy -*/
+public static final String CLEANUP_POLICY_KEY = "cleanup.policy";
--- End diff --

Maybe change to:
= LogConfig.CleanupPolicyProp();


---

[GitHub] incubator-rya pull request #286: RYA-467 update topic cleanup.policy

2018-04-02 Thread ejwhite922 
Github user ejwhite922 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/286#discussion_r178586989
  
--- Diff: 
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/interactor/KafkaTopicPropertiesBuilder.java
 ---
@@ -0,0 +1,46 @@
+package org.apache.rya.streams.kafka.interactor;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.Optional;
+import java.util.Properties;
+
+/**
+ * Properties builder to be used when creating new Kafka Topics.
+ *
+ * Descriptions of properties can be found at
+ * {@link https://kafka.apache.org/documentation/#topicconfigs}
+ */
+public class KafkaTopicPropertiesBuilder {
+/*- Cleanup Policy -*/
+public static final String CLEANUP_POLICY_KEY = "cleanup.policy";
+public static final String CLEANUP_POLICY_DELETE = "cleanup.policy";
--- End diff --

Change to:
= "delete";
or
= LogConfig.Delete();


---

[GitHub] incubator-rya pull request #286: RYA-467 update topic cleanup.policy

2018-04-02 Thread ejwhite922 
Github user ejwhite922 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/286#discussion_r178587123
  
--- Diff: 
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/interactor/KafkaTopicPropertiesBuilder.java
 ---
@@ -0,0 +1,46 @@
+package org.apache.rya.streams.kafka.interactor;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.Optional;
+import java.util.Properties;
+
+/**
+ * Properties builder to be used when creating new Kafka Topics.
+ *
+ * Descriptions of properties can be found at
+ * {@link https://kafka.apache.org/documentation/#topicconfigs}
+ */
+public class KafkaTopicPropertiesBuilder {
+/*- Cleanup Policy -*/
+public static final String CLEANUP_POLICY_KEY = "cleanup.policy";
+public static final String CLEANUP_POLICY_DELETE = "cleanup.policy";
+public static final String CLEANUP_POLICY_COMPACT = "cleanup.policy";
--- End diff --

Change to:
= "compact";
or
= LogConfig.Compact();


---

[GitHub] incubator-rya pull request #286: RYA-467 update topic cleanup.policy

2018-04-02 Thread isper3at 
GitHub user isper3at opened a pull request:

https://github.com/apache/incubator-rya/pull/286

RYA-467 update topic cleanup.policy


## Description
>What Changed?

Added a topic properties builder.  Only one
property is currently in the builder, but
adding others should be easy.

### Tests
>Coverage?

### Links
[Jira](https://issues.apache.org/jira/browse/RYA-467)

### Checklist
- [ ] Code Review
- [x] Squash Commits

 People To Reivew
@kchilton2 
@ejwhite922 
@pujav65 
@dlotts
@jessehatfield 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/isper3at/incubator-rya RYA-467

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rya/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #286


commit 6565ca4b28c04398c799b5507b0237828a5eb613
Author: Andrew Smith 
Date:   2018-04-02T16:32:40Z

RYA-467 update topic cleanup.policy

Added a topic properties builder.  Only one
property is currently in the builder, but
adding others should be easy.




---