[jira] [Commented] (RYA-178) Review RAT Exclusions
[ https://issues.apache.org/jira/browse/RYA-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576196#comment-15576196 ] ASF GitHub Bot commented on RYA-178: Github user asfgit closed the pull request at: https://github.com/apache/incubator-rya/pull/107 > Review RAT Exclusions > - > > Key: RYA-178 > URL: https://issues.apache.org/jira/browse/RYA-178 > Project: Rya > Issue Type: Task >Affects Versions: 3.2.10 >Reporter: Aaron Mihalik >Assignee: Caleb Meier > Fix For: 3.2.10 > > > During 3.2.10-RC1 Review, Josh Noted: > * Saw some XML files in the build which were excluded from the > apache-rat-plugin. I'd recommend minimizing the exclusions as much as > possible. > * mvn apache-rat:check passes (after `rm DEPENDENCIES`) > (Need to add DEPENDENCIES to the exclusion list) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-178) Review RAT Exclusions
[ https://issues.apache.org/jira/browse/RYA-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576081#comment-15576081 ] ASF GitHub Bot commented on RYA-178: Github user amihalik commented on the issue: https://github.com/apache/incubator-rya/pull/107 delete `sail/src/test/resources/univ-bench.owl` completely. It appears that we don't use it in any tests. > Review RAT Exclusions > - > > Key: RYA-178 > URL: https://issues.apache.org/jira/browse/RYA-178 > Project: Rya > Issue Type: Task >Affects Versions: 3.2.10 >Reporter: Aaron Mihalik >Assignee: Caleb Meier > > During 3.2.10-RC1 Review, Josh Noted: > * Saw some XML files in the build which were excluded from the > apache-rat-plugin. I'd recommend minimizing the exclusions as much as > possible. > * mvn apache-rat:check passes (after `rm DEPENDENCIES`) > (Need to add DEPENDENCIES to the exclusion list) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-178) Review RAT Exclusions
[ https://issues.apache.org/jira/browse/RYA-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573345#comment-15573345 ] ASF GitHub Bot commented on RYA-178: GitHub user meiercaleb opened a pull request: https://github.com/apache/incubator-rya/pull/107 RYA-178-Remove Rat Exclusions for OWL Files ## Description >What Changed? Removed Rat Exclusions for OWL files. ### Tests No new tests added. Build passes rat check. ### Links [Jira](https://issues.apache.org/jira/browse/RYA-178) ### Checklist - [] Code Review - [X] Squash Commits People To Reivew Aaron Mihalik You can merge this pull request into a Git repository by running: $ git pull https://github.com/meiercaleb/incubator-rya RYA-178 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #107 commit 168f6c336014967121ba5571ec38be4183f4499e Author: Caleb Meier Date: 2016-10-13T22:04:14Z RYA-178-Remove Rat Exclusions for OWL Files > Review RAT Exclusions > - > > Key: RYA-178 > URL: https://issues.apache.org/jira/browse/RYA-178 > Project: Rya > Issue Type: Task >Affects Versions: 3.2.10 >Reporter: Aaron Mihalik >Assignee: Caleb Meier > > During 3.2.10-RC1 Review, Josh Noted: > * Saw some XML files in the build which were excluded from the > apache-rat-plugin. I'd recommend minimizing the exclusions as much as > possible. > * mvn apache-rat:check passes (after `rm DEPENDENCIES`) > (Need to add DEPENDENCIES to the exclusion list) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
