[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[ https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439864#comment-16439864 ] ASF GitHub Bot commented on RYA-467: Github user asfgit closed the pull request at: https://github.com/apache/incubator-rya/pull/286 > Rya Streams - QueryChangeLog topic deletes content after 7 days. > > > Key: RYA-467 > URL: https://issues.apache.org/jira/browse/RYA-467 > Project: Rya > Issue Type: Bug >Reporter: Kevin Chilton >Assignee: Eric White >Priority: Major > > The automatically created topic used as the QueryChangeLog for a rya instance > uses the default "cleanup.policy" or "delete", and it does it after 7 days. > The policy for that topic should be "compact" since the query change log > needs to persist forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[ https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428594#comment-16428594 ] ASF GitHub Bot commented on RYA-467: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/286 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/724/ > Rya Streams - QueryChangeLog topic deletes content after 7 days. > > > Key: RYA-467 > URL: https://issues.apache.org/jira/browse/RYA-467 > Project: Rya > Issue Type: Bug >Reporter: Kevin Chilton >Assignee: Eric White >Priority: Major > > The automatically created topic used as the QueryChangeLog for a rya instance > uses the default "cleanup.policy" or "delete", and it does it after 7 days. > The policy for that topic should be "compact" since the query change log > needs to persist forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[ https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428502#comment-16428502 ] ASF GitHub Bot commented on RYA-467: Github user pujav65 commented on the issue: https://github.com/apache/incubator-rya/pull/286 asfbot build > Rya Streams - QueryChangeLog topic deletes content after 7 days. > > > Key: RYA-467 > URL: https://issues.apache.org/jira/browse/RYA-467 > Project: Rya > Issue Type: Bug >Reporter: Kevin Chilton >Assignee: Eric White >Priority: Major > > The automatically created topic used as the QueryChangeLog for a rya instance > uses the default "cleanup.policy" or "delete", and it does it after 7 days. > The policy for that topic should be "compact" since the query change log > needs to persist forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[ https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423016#comment-16423016 ] ASF GitHub Bot commented on RYA-467: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/286 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/721/ > Rya Streams - QueryChangeLog topic deletes content after 7 days. > > > Key: RYA-467 > URL: https://issues.apache.org/jira/browse/RYA-467 > Project: Rya > Issue Type: Bug >Reporter: Kevin Chilton >Assignee: Eric White >Priority: Major > > The automatically created topic used as the QueryChangeLog for a rya instance > uses the default "cleanup.policy" or "delete", and it does it after 7 days. > The policy for that topic should be "compact" since the query change log > needs to persist forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[
https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422799#comment-16422799
]
ASF GitHub Bot commented on RYA-467:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/286#discussion_r178586989
--- Diff:
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/interactor/KafkaTopicPropertiesBuilder.java
---
@@ -0,0 +1,46 @@
+package org.apache.rya.streams.kafka.interactor;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.Optional;
+import java.util.Properties;
+
+/**
+ * Properties builder to be used when creating new Kafka Topics.
+ *
+ * Descriptions of properties can be found at
+ * {@link https://kafka.apache.org/documentation/#topicconfigs}
+ */
+public class KafkaTopicPropertiesBuilder {
+/*- Cleanup Policy -*/
+public static final String CLEANUP_POLICY_KEY = "cleanup.policy";
+public static final String CLEANUP_POLICY_DELETE = "cleanup.policy";
--- End diff --
Change to:
= "delete";
or
= LogConfig.Delete();
> Rya Streams - QueryChangeLog topic deletes content after 7 days.
>
>
> Key: RYA-467
> URL: https://issues.apache.org/jira/browse/RYA-467
> Project: Rya
> Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Eric White
>Priority: Major
>
> The automatically created topic used as the QueryChangeLog for a rya instance
> uses the default "cleanup.policy" or "delete", and it does it after 7 days.
> The policy for that topic should be "compact" since the query change log
> needs to persist forever.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[
https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422802#comment-16422802
]
ASF GitHub Bot commented on RYA-467:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/286#discussion_r178588294
--- Diff:
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/interactor/KafkaTopicPropertiesBuilder.java
---
@@ -0,0 +1,46 @@
+package org.apache.rya.streams.kafka.interactor;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.Optional;
+import java.util.Properties;
+
+/**
+ * Properties builder to be used when creating new Kafka Topics.
+ *
+ * Descriptions of properties can be found at
+ * {@link https://kafka.apache.org/documentation/#topicconfigs}
+ */
+public class KafkaTopicPropertiesBuilder {
+/*- Cleanup Policy -*/
+public static final String CLEANUP_POLICY_KEY = "cleanup.policy";
--- End diff --
Maybe change to:
= LogConfig.CleanupPolicyProp();
> Rya Streams - QueryChangeLog topic deletes content after 7 days.
>
>
> Key: RYA-467
> URL: https://issues.apache.org/jira/browse/RYA-467
> Project: Rya
> Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Eric White
>Priority: Major
>
> The automatically created topic used as the QueryChangeLog for a rya instance
> uses the default "cleanup.policy" or "delete", and it does it after 7 days.
> The policy for that topic should be "compact" since the query change log
> needs to persist forever.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[
https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422801#comment-16422801
]
ASF GitHub Bot commented on RYA-467:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/286#discussion_r178587123
--- Diff:
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/interactor/KafkaTopicPropertiesBuilder.java
---
@@ -0,0 +1,46 @@
+package org.apache.rya.streams.kafka.interactor;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.Optional;
+import java.util.Properties;
+
+/**
+ * Properties builder to be used when creating new Kafka Topics.
+ *
+ * Descriptions of properties can be found at
+ * {@link https://kafka.apache.org/documentation/#topicconfigs}
+ */
+public class KafkaTopicPropertiesBuilder {
+/*- Cleanup Policy -*/
+public static final String CLEANUP_POLICY_KEY = "cleanup.policy";
+public static final String CLEANUP_POLICY_DELETE = "cleanup.policy";
+public static final String CLEANUP_POLICY_COMPACT = "cleanup.policy";
--- End diff --
Change to:
= "compact";
or
= LogConfig.Compact();
> Rya Streams - QueryChangeLog topic deletes content after 7 days.
>
>
> Key: RYA-467
> URL: https://issues.apache.org/jira/browse/RYA-467
> Project: Rya
> Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Eric White
>Priority: Major
>
> The automatically created topic used as the QueryChangeLog for a rya instance
> uses the default "cleanup.policy" or "delete", and it does it after 7 days.
> The policy for that topic should be "compact" since the query change log
> needs to persist forever.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[ https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422803#comment-16422803 ] ASF GitHub Bot commented on RYA-467: Github user ejwhite922 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/286#discussion_r178586652 --- Diff: extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/interactor/KafkaTopicPropertiesBuilder.java --- @@ -0,0 +1,46 @@ +package org.apache.rya.streams.kafka.interactor; --- End diff -- Add license > Rya Streams - QueryChangeLog topic deletes content after 7 days. > > > Key: RYA-467 > URL: https://issues.apache.org/jira/browse/RYA-467 > Project: Rya > Issue Type: Bug >Reporter: Kevin Chilton >Assignee: Eric White >Priority: Major > > The automatically created topic used as the QueryChangeLog for a rya instance > uses the default "cleanup.policy" or "delete", and it does it after 7 days. > The policy for that topic should be "compact" since the query change log > needs to persist forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[ https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422786#comment-16422786 ] ASF GitHub Bot commented on RYA-467: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/286 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/720/Build result: FAILURE[...truncated 1.48 MB...][INFO] Apache Rya Spark Support ... SKIPPED[INFO] Apache Rya Web Projects SKIPPED[INFO] Apache Rya Web Implementation .. SKIPPED[INFO] [INFO] BUILD FAILURE[INFO] [INFO] Total time: 23:07 min[INFO] Finished at: 2018-04-02T17:08:34+00:00[INFO] Final Memory: 335M/3024M[INFO] [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.streams.kafka: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.streams/kafka/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.streams.kafkachannel stoppedSetting status of 6565ca4b28c04398c799b5507b0237828a5eb613 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/720/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing > Rya Streams - QueryChangeLog topic deletes content after 7 days. > > > Key: RYA-467 > URL: https://issues.apache.org/jira/browse/RYA-467 > Project: Rya > Issue Type: Bug >Reporter: Kevin Chilton >Assignee: Eric White >Priority: Major > > The automatically created topic used as the QueryChangeLog for a rya instance > uses the default "cleanup.policy" or "delete", and it does it after 7 days. > The policy for that topic should be "compact" since the query change log > needs to persist forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[ https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422739#comment-16422739 ] ASF GitHub Bot commented on RYA-467: GitHub user isper3at opened a pull request: https://github.com/apache/incubator-rya/pull/286 RYA-467 update topic cleanup.policy ## Description >What Changed? Added a topic properties builder. Only one property is currently in the builder, but adding others should be easy. ### Tests >Coverage? ### Links [Jira](https://issues.apache.org/jira/browse/RYA-467) ### Checklist - [ ] Code Review - [x] Squash Commits People To Reivew @kchilton2 @ejwhite922 @pujav65 @dlotts @jessehatfield You can merge this pull request into a Git repository by running: $ git pull https://github.com/isper3at/incubator-rya RYA-467 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/286.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #286 commit 6565ca4b28c04398c799b5507b0237828a5eb613 Author: Andrew Smith Date: 2018-04-02T16:32:40Z RYA-467 update topic cleanup.policy Added a topic properties builder. Only one property is currently in the builder, but adding others should be easy. > Rya Streams - QueryChangeLog topic deletes content after 7 days. > > > Key: RYA-467 > URL: https://issues.apache.org/jira/browse/RYA-467 > Project: Rya > Issue Type: Bug >Reporter: Kevin Chilton >Assignee: Eric White >Priority: Major > > The automatically created topic used as the QueryChangeLog for a rya instance > uses the default "cleanup.policy" or "delete", and it does it after 7 days. > The policy for that topic should be "compact" since the query change log > needs to persist forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-467) Rya Streams - QueryChangeLog topic deletes content after 7 days.
[ https://issues.apache.org/jira/browse/RYA-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402602#comment-16402602 ] Andrew Smith commented on RYA-467: -- KafkaTopics.java:145 add the cleanup policy as a property in the currently empty Properties that is used as the topic configuration. > Rya Streams - QueryChangeLog topic deletes content after 7 days. > > > Key: RYA-467 > URL: https://issues.apache.org/jira/browse/RYA-467 > Project: Rya > Issue Type: Bug >Reporter: Kevin Chilton >Assignee: Eric White >Priority: Major > > The automatically created topic used as the QueryChangeLog for a rya instance > uses the default "cleanup.policy" or "delete", and it does it after 7 days. > The policy for that topic should be "compact" since the query change log > needs to persist forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
