Re: [PR] fix:stores nil for unimplemented registry types [incubator-seata-go]
222twotwotwo closed pull request #1132: fix:stores nil for unimplemented registry types URL: https://github.com/apache/incubator-seata-go/pull/1132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix:stores nil for unimplemented registry types [incubator-seata-go]
222twotwotwo commented on PR #1132: URL: https://github.com/apache/incubator-seata-go/pull/1132#issuecomment-4943272988 #1127 has been resolved by #1126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix:stores nil for unimplemented registry types [incubator-seata-go]
github-actions[bot] commented on PR #1132: URL: https://github.com/apache/incubator-seata-go/pull/1132#issuecomment-4935779536 > Bot detected the issue body's language is not English, translate it automatically. > Resolve the CI problems. This ci problem does not seem to be introduced by this pr. I saw the same ci error in several other prs with the same ci failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix:stores nil for unimplemented registry types [incubator-seata-go]
222twotwotwo commented on PR #1132: URL: https://github.com/apache/incubator-seata-go/pull/1132#issuecomment-4935776203 > Resolve the CI problems. 此ci问题貌似不是本pr引入，我在其他几个同样ci失败的pr里看到同样的ci错误 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix:stores nil for unimplemented registry types [incubator-seata-go]
thunguo commented on PR #1132: URL: https://github.com/apache/incubator-seata-go/pull/1132#issuecomment-4913627827 Resolve the CI problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] fix:stores nil for unimplemented registry types [incubator-seata-go]
codecov-commenter commented on PR #1132: URL: https://github.com/apache/incubator-seata-go/pull/1132#issuecomment-4906876555 ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1132?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.11%. Comparing base ([`c34171e`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/c34171eabcf68fd5a34a7f8cd21e58f75f3ce6fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1cde65f`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/1cde65f48169710cf061108de6006cc6a7271f61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1132?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [pkg/discovery/init.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1132?src=pr&el=tree&filepath=pkg%2Fdiscovery%2Finit.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2Rpc2NvdmVyeS9pbml0Lmdv) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## master#1132 +/- ## == + Coverage 57.07% 57.11% +0.04% == Files 299 299 Lines 2049520491 -4 == + Hits1169711704 +7 + Misses 7793 7783 -10 + Partials 1005 1004 -1 ``` [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1132?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
