[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2856: add unit test cases about mariadb;

2019-08-15 Thread GitBox
terrymanu commented on issue #2856: add unit test cases about mariadb; URL: https://github.com/apache/incubator-shardingsphere/pull/2856#issuecomment-521608832 Thank you for contribution. This is an automated message from

[GitHub] [incubator-shardingsphere] gholly commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version

2019-08-15 Thread GitBox
gholly commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-521537452 I have the same problem. ` Hibernate: insert into dd_bank_2 (application_number, company_id, id)

[GitHub] [incubator-shardingsphere] ningyu1 commented on issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm

2019-08-15 Thread GitBox
ningyu1 commented on issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/2873#issuecomment-521551527 @KomachiSion tks.

[GitHub] [incubator-shardingsphere] yangjwInRiver opened a new issue #2878: Fail to execute create dynamic table sql

2019-08-15 Thread GitBox
yangjwInRiver opened a new issue #2878: Fail to execute create dynamic table sql URL: https://github.com/apache/incubator-shardingsphere/issues/2878 ### Which version of ShardingSphere did you use? 4.0.0-RC1 ### Which project did you use? Sharding-JDBC or Sharding-Proxy?

[GitHub] [incubator-shardingsphere] jukai5501 commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
jukai5501 commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521563151 Hi! I removed assistedQueryColumn configuration. Error reporting at runtime. ``` 2019-08-15

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2877: fastjson 0day, spring boot version to fix security

2019-08-15 Thread GitBox
coveralls commented on issue #2877: fastjson 0day,spring boot version to fix security URL: https://github.com/apache/incubator-shardingsphere/pull/2877#issuecomment-521563312 ## Pull Request Test Coverage Report for [Build 9157](https://coveralls.io/builds/25149740) * **0** of

[GitHub] [incubator-shardingsphere] jukai5501 closed issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
jukai5501 closed issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2877: fastjson 0day, spring boot version to fix security

2019-08-15 Thread GitBox
terrymanu commented on issue #2877: fastjson 0day,spring boot version to fix security URL: https://github.com/apache/incubator-shardingsphere/pull/2877#issuecomment-521603723 Hi, for this project, it do not need fastjson, so it is unnecessary to add it to pom

[GitHub] [incubator-shardingsphere] terrymanu closed pull request #2877: fastjson 0day, spring boot version to fix security

2019-08-15 Thread GitBox
terrymanu closed pull request #2877: fastjson 0day,spring boot version to fix security URL: https://github.com/apache/incubator-shardingsphere/pull/2877 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2878: Fail to execute create dynamic table sql

2019-08-15 Thread GitBox
terrymanu commented on issue #2878: Fail to execute create dynamic table sql URL: https://github.com/apache/incubator-shardingsphere/issues/2878#issuecomment-521608453 I don't understand. for DDL, what's mean for change unique key and key? What is your error message?

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2856: add unit test cases about mariadb;

2019-08-15 Thread GitBox
terrymanu merged pull request #2856: add unit test cases about mariadb; URL: https://github.com/apache/incubator-shardingsphere/pull/2856 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2849: add SPI for Opentracing implements

2019-08-15 Thread GitBox
coveralls edited a comment on issue #2849: add SPI for Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/pull/2849#issuecomment-520159632 ## Pull Request Test Coverage Report for [Build 9165](https://coveralls.io/builds/25152890) * **11** of **21**

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2851: ComplexKeysShardingAlgorithm example

2019-08-15 Thread GitBox
terrymanu commented on issue #2851: ComplexKeysShardingAlgorithm example URL: https://github.com/apache/incubator-shardingsphere/issues/2851#issuecomment-521609975 Can you consider about submit a pull request for example? @DongJigong

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521611015 There is no 'ActiveSpan' in io.opentracing:0.31.0. The shardingsphere throws an

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521611015 There is no 'ActiveSpan' in io.opentracing:0.31.0. The shardingsphere throws an

[GitHub] [incubator-shardingsphere] yangjwInRiver commented on issue #2878: Fail to execute create dynamic table sql

2019-08-15 Thread GitBox
yangjwInRiver commented on issue #2878: Fail to execute create dynamic table sql URL: https://github.com/apache/incubator-shardingsphere/issues/2878#issuecomment-521616712 I configure `record_no,gmt8_create,account_no` to sharding-columns ,and table strategy is complex

[GitHub] [incubator-shardingsphere] yangjwInRiver commented on issue #2878: Fail to execute create dynamic table sql

2019-08-15 Thread GitBox
yangjwInRiver commented on issue #2878: Fail to execute create dynamic table sql URL: https://github.com/apache/incubator-shardingsphere/issues/2878#issuecomment-521614736 It is different in logic sql and execute sql。 logic sql ``` UNIQUE KEY `unique_record_no` (`record_no`)

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2856: add unit test cases about mariadb;

2019-08-15 Thread GitBox
coveralls commented on issue #2856: add unit test cases about mariadb; URL: https://github.com/apache/incubator-shardingsphere/pull/2856#issuecomment-521607289 ## Pull Request Test Coverage Report for [Build 9130](https://coveralls.io/builds/25151942) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521611015 There is no 'ActiveSpan' in io.opentracing:0.31.0. The shardingsphere where throw an

[GitHub] [incubator-shardingsphere-example] cherrylzhao opened a new pull request #164: migrate spi-impl association example to spi-impl-example.

2019-08-15 Thread GitBox
cherrylzhao opened a new pull request #164: migrate spi-impl association example to spi-impl-example. URL: https://github.com/apache/incubator-shardingsphere-example/pull/164 This is an automated message from the Apache

[GitHub] [incubator-shardingsphere-example] cherrylzhao merged pull request #164: migrate spi-impl association example to spi-impl-example.

2019-08-15 Thread GitBox
cherrylzhao merged pull request #164: migrate spi-impl association example to spi-impl-example. URL: https://github.com/apache/incubator-shardingsphere-example/pull/164 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2875: fix select, update grammar of mysql

2019-08-15 Thread GitBox
coveralls commented on issue #2875: fix select,update grammar of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/2875#issuecomment-521544034 ## Pull Request Test Coverage Report for [Build 9154](https://coveralls.io/builds/25148790) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] yangjwInRiver commented on issue #2878: Fail to execute create dynamic table sql

2019-08-15 Thread GitBox
yangjwInRiver commented on issue #2878: Fail to execute create dynamic table sql URL: https://github.com/apache/incubator-shardingsphere/issues/2878#issuecomment-521552165 the statement execution failed because of the unique key and key is changed

[GitHub] [incubator-shardingsphere] jukai5501 commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
jukai5501 commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521554460 Hi! I was using your configuration. Error reporting at runtime. The credential field that

[GitHub] [incubator-shardingsphere] jukai5501 commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
jukai5501 commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521559444 Hi! I implemented the ShardingQueryAssistedEncryptor interface. I want to encrypt credential field

[GitHub] [incubator-shardingsphere] xfyang1989 commented on issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change.

2019-08-15 Thread GitBox
xfyang1989 commented on issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change. URL: https://github.com/apache/incubator-shardingsphere/issues/2827#issuecomment-521526606 Spring's own

[GitHub] [incubator-shardingsphere] reynaldliu opened a new pull request #2877: fastjson 0day, spring boot version to fix security

2019-08-15 Thread GitBox
reynaldliu opened a new pull request #2877: fastjson 0day,spring boot version to fix security URL: https://github.com/apache/incubator-shardingsphere/pull/2877 https://github.com/alibaba/fastjson/issues/2513 Fixes #ISSUSE_ID. Changes proposed in this pull request: - -

[GitHub] [incubator-shardingsphere] KomachiSion removed a comment on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
KomachiSion removed a comment on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521472441 Please change to this configuration and retry. ``` spring: shardingsphere: datasource:

[GitHub] [incubator-shardingsphere] KomachiSion edited a comment on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
KomachiSion edited a comment on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521557242 @jukai5501, you need to change some config according to your environment, do not copy my configuration,

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
KomachiSion commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521557242 @jukai5501, you need to change some config, do not copy my configuration, `cipherColumn` and

[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #2879: fix getString() from Date format error

2019-08-15 Thread GitBox
tuohai666 opened a new pull request #2879: fix getString() from Date format error URL: https://github.com/apache/incubator-shardingsphere/pull/2879 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] DongJigong edited a comment on issue #2851: ComplexKeysShardingAlgorithm example

2019-08-15 Thread GitBox
DongJigong edited a comment on issue #2851: ComplexKeysShardingAlgorithm example URL: https://github.com/apache/incubator-shardingsphere/issues/2851#issuecomment-521589646 > Not yet, dose anybody want add a example for ComplexKeysShardingAlgorithm?

[GitHub] [incubator-shardingsphere] reynaldliu opened a new issue #2874: How can I get a distribution package/release/bin from source code?

2019-08-15 Thread GitBox
reynaldliu opened a new issue #2874: How can I get a distribution package/release/bin from source code? URL: https://github.com/apache/incubator-shardingsphere/issues/2874 How can I get a distribution package/release/bin from source code? last update at

[GitHub] [incubator-shardingsphere] DongJigong commented on issue #2865: 4.0.0-RC1 jpa select result change some values and save shoud update Row Data rather then insert

2019-08-15 Thread GitBox
DongJigong commented on issue #2865: 4.0.0-RC1 jpa select result change some values and save shoud update Row Data rather then insert URL: https://github.com/apache/incubator-shardingsphere/issues/2865#issuecomment-521529891 > > Other solution, I think, is add where clause with sharding

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
KomachiSion commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521561298 Remove `assistedQueryColumn` and retry This is

[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #2876: fix wrong return type of getBlob()

2019-08-15 Thread GitBox
tuohai666 opened a new pull request #2876: fix wrong return type of getBlob() URL: https://github.com/apache/incubator-shardingsphere/pull/2876 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521565698 @tuohai666 I tested it for SkyWalking with sharding-jdbc and sharding-proxy. But the

[GitHub] [incubator-shardingsphere] jukai5501 commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
jukai5501 commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521565601 Hi! It is OK now, I forgot remove the ShardingQueryAssistedEncryptor conf. > 在

[GitHub] [incubator-shardingsphere] DongJigong opened a new issue #2880: Complex Keys Sharding Algorithm between and suport

2019-08-15 Thread GitBox
DongJigong opened a new issue #2880: Complex Keys Sharding Algorithm between and suport URL: https://github.com/apache/incubator-shardingsphere/issues/2880 ## Feature Request **For English only**, other languages will not accept. Please pay attention on issues you submitted,

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2876: fix wrong return type of getBlob()

2019-08-15 Thread GitBox
terrymanu merged pull request #2876: fix wrong return type of getBlob() URL: https://github.com/apache/incubator-shardingsphere/pull/2876 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2879: fix getString() from Date format error

2019-08-15 Thread GitBox
terrymanu merged pull request #2879: fix getString() from Date format error URL: https://github.com/apache/incubator-shardingsphere/pull/2879 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2874: How can I get a distribution package/release/bin from source code?

2019-08-15 Thread GitBox
terrymanu closed issue #2874: How can I get a distribution package/release/bin from source code? URL: https://github.com/apache/incubator-shardingsphere/issues/2874 This is an automated message from the Apache Git Service.

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2874: How can I get a distribution package/release/bin from source code?

2019-08-15 Thread GitBox
terrymanu commented on issue #2874: How can I get a distribution package/release/bin from source code? URL: https://github.com/apache/incubator-shardingsphere/issues/2874#issuecomment-521604691 4.0.0-RC2 has not released yet

[GitHub] [incubator-shardingsphere] DongJigong commented on issue #2865: 4.0.0-RC1 jpa select result change some values and save shoud update Row Data rather then insert

2019-08-15 Thread GitBox
DongJigong commented on issue #2865: 4.0.0-RC1 jpa select result change some values and save shoud update Row Data rather then insert URL: https://github.com/apache/incubator-shardingsphere/issues/2865#issuecomment-521534993 > > > Other solution, I think, is add where clause with

[GitHub] [incubator-shardingsphere] DongJigong closed issue #2865: 4.0.0-RC1 jpa select result change some values and save shoud update Row Data rather then insert

2019-08-15 Thread GitBox
DongJigong closed issue #2865: 4.0.0-RC1 jpa select result change some values and save shoud update Row Data rather then insert URL: https://github.com/apache/incubator-shardingsphere/issues/2865 This is an automated

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2879: fix getString() from Date format error

2019-08-15 Thread GitBox
coveralls commented on issue #2879: fix getString() from Date format error URL: https://github.com/apache/incubator-shardingsphere/pull/2879#issuecomment-521583014 ## Pull Request Test Coverage Report for [Build 9158](https://coveralls.io/builds/25150419) * **1** of **1**

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521600338 OK. I heard someone have tested with the version of io.zipkin.brave

[GitHub] [incubator-shardingsphere] jingshanglu opened a new pull request #2875: fix select, update grammar of mysql

2019-08-15 Thread GitBox
jingshanglu opened a new pull request #2875: fix select,update grammar of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/2875 Changes proposed in this pull request: - fix select grammar - fix update grammar

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version

2019-08-15 Thread GitBox
KomachiSion commented on issue #2866: encrypt not work in 4.0.0-RC2-SNAPSHOT version URL: https://github.com/apache/incubator-shardingsphere/issues/2866#issuecomment-521546573 Please change to this configuration and retry. ``` spring: shardingsphere: datasource:

[GitHub] [incubator-shardingsphere] ningyu1 removed a comment on issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm

2019-08-15 Thread GitBox
ningyu1 removed a comment on issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/2873#issuecomment-521551527 @KomachiSion tks.

[GitHub] [incubator-shardingsphere] ningyu1 commented on issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm

2019-08-15 Thread GitBox
ningyu1 commented on issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/2873#issuecomment-521553289 @KomachiSion Different from question #2193 The problem is that

[GitHub] [incubator-shardingsphere] DongJigong commented on issue #2851: ComplexKeysShardingAlgorithm example

2019-08-15 Thread GitBox
DongJigong commented on issue #2851: ComplexKeysShardingAlgorithm example URL: https://github.com/apache/incubator-shardingsphere/issues/2851#issuecomment-521589646 > Not yet, dose anybody want add a example for ComplexKeysShardingAlgorithm?

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2841: openjdk11 not work

2019-08-15 Thread GitBox
terrymanu commented on issue #2841: openjdk11 not work URL: https://github.com/apache/incubator-shardingsphere/issues/2841#issuecomment-521604382 Will close soon if no response any more. This is an automated message from the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2843: I modify this code to support MySQL and SQLServer ,it's has some problem?

2019-08-15 Thread GitBox
terrymanu commented on issue #2843: I modify this code to support MySQL and SQLServer ,it's has some problem? URL: https://github.com/apache/incubator-shardingsphere/issues/2843#issuecomment-521604519 Will close soon if no response any more.

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #2872: Format some unit test class.

2019-08-15 Thread GitBox
tristaZero merged pull request #2872: Format some unit test class. URL: https://github.com/apache/incubator-shardingsphere/pull/2872 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2871: Make sure SpringBootConfiguration.class load before DataSourceAutoConfiguration.class

2019-08-15 Thread GitBox
terrymanu merged pull request #2871: Make sure SpringBootConfiguration.class load before DataSourceAutoConfiguration.class URL: https://github.com/apache/incubator-shardingsphere/pull/2871 This is an automated message from

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2875: fix select, update grammar of mysql

2019-08-15 Thread GitBox
terrymanu merged pull request #2875: fix select,update grammar of mysql URL: https://github.com/apache/incubator-shardingsphere/pull/2875 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2834: sharding proxy “select * into outfile” fail

2019-08-15 Thread GitBox
terrymanu commented on issue #2834: sharding proxy “select * into outfile” fail URL: https://github.com/apache/incubator-shardingsphere/issues/2834#issuecomment-521868328 Will close soon if no volunteer interested This

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2867: shardingsphere-incubating-4.0.0-RC1-sharding-proxy Demo Not Run

2019-08-15 Thread GitBox
terrymanu commented on issue #2867: shardingsphere-incubating-4.0.0-RC1-sharding-proxy Demo Not Run URL: https://github.com/apache/incubator-shardingsphere/issues/2867#issuecomment-521869396 Can you explain why close this issue without any reason to update?

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2831: SQL where include (, report "Missing right paren."

2019-08-15 Thread GitBox
terrymanu commented on issue #2831: SQL where include (, report "Missing right paren." URL: https://github.com/apache/incubator-shardingsphere/issues/2831#issuecomment-521870106 **For English only**, other languages will not accept.

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #2867: shardingsphere-incubating-4.0.0-RC1-sharding-proxy Demo Not Run

2019-08-15 Thread GitBox
terrymanu edited a comment on issue #2867: shardingsphere-incubating-4.0.0-RC1-sharding-proxy Demo Not Run URL: https://github.com/apache/incubator-shardingsphere/issues/2867#issuecomment-521869396 Can you explain why close this issue without any reason to update? We hope every issue

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2594: how to set all tables hint database and tables algorithmClassName

2019-08-15 Thread GitBox
terrymanu commented on issue #2594: how to set all tables hint database and tables algorithmClassName URL: https://github.com/apache/incubator-shardingsphere/issues/2594#issuecomment-521870301 Can you explain why close this issue without any reason to update? We hope every issue have

[GitHub] [incubator-shardingsphere-example] betterjava opened a new pull request #166: fix bug set column for UserRepositoryImpl.getUsers()

2019-08-15 Thread GitBox
betterjava opened a new pull request #166: fix bug set column for UserRepositoryImpl.getUsers() URL: https://github.com/apache/incubator-shardingsphere-example/pull/166 Fixes #165. Changes proposed in this pull request: - get result from ResultSet by column not by index.

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521883965 OK. I understand what you said. The current situation is : - The highest

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2841: openjdk11 not work

2019-08-15 Thread GitBox
terrymanu closed issue #2841: openjdk11 not work URL: https://github.com/apache/incubator-shardingsphere/issues/2841 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere-example] betterjava opened a new issue #165: UserRepositoryImpl.getUsers() set wrong column for User Entity

2019-08-15 Thread GitBox
betterjava opened a new issue #165: UserRepositoryImpl.getUsers() set wrong column for User Entity URL: https://github.com/apache/incubator-shardingsphere-example/issues/165 UserRepositoryImpl.getUsers() like below in example code: > User user = new User();

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
betterjava edited a comment on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521883965 OK. I understand what you said. The current situation is : - The highest

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2850: table doesn't exist

2019-08-15 Thread GitBox
terrymanu commented on issue #2850: table doesn't exist URL: https://github.com/apache/incubator-shardingsphere/issues/2850#issuecomment-521869876 Can you explain why close this issue without any reason to update? We hope every issue have their value which should include enough

[GitHub] [incubator-shardingsphere] Ah39 commented on issue #1990: sharding-jdbc can't work in multi thread concurrent

2019-08-15 Thread GitBox
Ah39 commented on issue #1990: sharding-jdbc can't work in multi thread concurrent URL: https://github.com/apache/incubator-shardingsphere/issues/1990#issuecomment-521874307 mark This is an automated message from the

[GitHub] [incubator-shardingsphere] Ah39 edited a comment on issue #1990: sharding-jdbc can't work in multi thread concurrent

2019-08-15 Thread GitBox
Ah39 edited a comment on issue #1990: sharding-jdbc can't work in multi thread concurrent URL: https://github.com/apache/incubator-shardingsphere/issues/1990#issuecomment-521874307 mark ParsingResultCache This is an

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2880: ComplexKeysShardingAlgorithm sql between and suport

2019-08-15 Thread GitBox
KomachiSion commented on issue #2880: ComplexKeysShardingAlgorithm sql between and suport URL: https://github.com/apache/incubator-shardingsphere/issues/2880#issuecomment-521855005 duplicate with #2613 This is an

[GitHub] [incubator-shardingsphere] KomachiSion closed issue #2880: ComplexKeysShardingAlgorithm sql between and suport

2019-08-15 Thread GitBox
KomachiSion closed issue #2880: ComplexKeysShardingAlgorithm sql between and suport URL: https://github.com/apache/incubator-shardingsphere/issues/2880 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2855: The dml/dql operation in the same thread don't route to master database.

2019-08-15 Thread GitBox
terrymanu commented on issue #2855: The dml/dql operation in the same thread don't route to master database. URL: https://github.com/apache/incubator-shardingsphere/issues/2855#issuecomment-521868569 Will close soon if no response any more.

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2843: I modify this code to support MySQL and SQLServer ,it's has some problem?

2019-08-15 Thread GitBox
terrymanu closed issue #2843: I modify this code to support MySQL and SQLServer ,it's has some problem? URL: https://github.com/apache/incubator-shardingsphere/issues/2843 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2774: OutOfMemoryError caused by excessive pagination

2019-08-15 Thread GitBox
terrymanu closed issue #2774: OutOfMemoryError caused by excessive pagination URL: https://github.com/apache/incubator-shardingsphere/issues/2774 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

2019-08-15 Thread GitBox
tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521873789 So, we should try to find way to support both of the implements.

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2849: add SPI for Opentracing implements

2019-08-15 Thread GitBox
betterjava commented on issue #2849: add SPI for Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/pull/2849#issuecomment-521884671 Since I can not find a way to make shardingsphere support Skywalking,jaeger,zipkin by openstracing at the same time,So it make

[GitHub] [incubator-shardingsphere] betterjava closed pull request #2849: add SPI for Opentracing implements

2019-08-15 Thread GitBox
betterjava closed pull request #2849: add SPI for Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/pull/2849 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2825: Too many keys are generated. There are only 1 target objects. You either specified a wrong 'keyProperty' or encountered a drive

2019-08-15 Thread GitBox
tristaZero commented on issue #2825: Too many keys are generated. There are only 1 target objects. You either specified a wrong 'keyProperty' or encountered a driver bug like #1523. URL: https://github.com/apache/incubator-shardingsphere/issues/2825#issuecomment-521893977 Please pay

[GitHub] [incubator-shardingsphere] tristaZero closed issue #2825: Too many keys are generated. There are only 1 target objects. You either specified a wrong 'keyProperty' or encountered a driver bug

2019-08-15 Thread GitBox
tristaZero closed issue #2825: Too many keys are generated. There are only 1 target objects. You either specified a wrong 'keyProperty' or encountered a driver bug like #1523. URL: https://github.com/apache/incubator-shardingsphere/issues/2825