[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2978: Filter out incorrect table which with only alias.

2019-09-05 Thread GitBox
coveralls edited a comment on issue #2978: Filter out incorrect table which with only alias. URL: https://github.com/apache/incubator-shardingsphere/pull/2978#issuecomment-528205522 ## Pull Request Test Coverage Report for [Build 294](https://coveralls.io/builds/25545046) * **11**

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

2019-09-05 Thread GitBox
coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-527423607 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] copyshop commented on issue #2948: My database table names are all uppercase , how to config ?

2019-09-05 Thread GitBox
copyshop commented on issue #2948: My database table names are all uppercase , how to config ? URL: https://github.com/apache/incubator-shardingsphere/issues/2948#issuecomment-528381560 I guess it doesn't mean much. it's only ignore case-sensitive.

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2978: Filter out incorrect table which with only alias.

2019-09-05 Thread GitBox
terrymanu merged pull request #2978: Filter out incorrect table which with only alias. URL: https://github.com/apache/incubator-shardingsphere/pull/2978 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2961: Delete with alias error

2019-09-05 Thread GitBox
terrymanu closed issue #2961: Delete with alias error URL: https://github.com/apache/incubator-shardingsphere/issues/2961 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528351057 yeah, I think so, we can deal with the remaining parameters by your way, i.e maxRows,fetchSize and

[GitHub] [incubator-shardingsphere] xiyelife closed pull request #2984: Fix for #2923

2019-09-05 Thread GitBox
xiyelife closed pull request #2984: Fix for #2923 URL: https://github.com/apache/incubator-shardingsphere/pull/2984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2979: support hint in sharding-proxy

2019-09-05 Thread GitBox
betterjava commented on issue #2979: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/issues/2979#issuecomment-528350394 I think the pivotal problem is how the shardingEngine get hint value.Because different BackendConnection may in the same thread,so

[GitHub] [incubator-shardingsphere-doc] nancyzrh opened a new pull request #239: replace travis build status with jenkins

2019-09-05 Thread GitBox
nancyzrh opened a new pull request #239: replace travis build status with jenkins URL: https://github.com/apache/incubator-shardingsphere-doc/pull/239 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #2984: Fix for #2923

2019-09-05 Thread GitBox
xiyelife opened a new pull request #2984: Fix for #2923 URL: https://github.com/apache/incubator-shardingsphere/pull/2984 Fixes #2923 First, if preparedStatemnt == null in getRoutedStatements(), emptyList will be returned. This step will stop NPE, but set queryTime() actually is not

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528332022 Got it, maybe we can split this task to two small ones. First, if preparedStatemnt == null in

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

2019-09-05 Thread GitBox
coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-527423607 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528332022 Got it, maybe we can split this task to two small ones. First, if preparedStatemnt ==

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

2019-09-05 Thread GitBox
coveralls edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-527423607 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] copyshop commented on issue #2948: My database table names are all uppercase , how to config ?

2019-09-05 Thread GitBox
copyshop commented on issue #2948: My database table names are all uppercase , how to config ? URL: https://github.com/apache/incubator-shardingsphere/issues/2948#issuecomment-528382517 for example broadcastTables: - t_config - T_TEST it can run correctly.

[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #2985: Fixes #2923.

2019-09-05 Thread GitBox
xiyelife opened a new pull request #2985: Fixes #2923. URL: https://github.com/apache/incubator-shardingsphere/pull/2985 Fixes #2923. Changes proposed in this pull request: First, if preparedStatemnt == null in getRoutedStatements(), emptyList will be returned. This step will

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2985: Fixes #2923.

2019-09-05 Thread GitBox
coveralls commented on issue #2985: Fixes #2923. URL: https://github.com/apache/incubator-shardingsphere/pull/2985#issuecomment-528432384 ## Pull Request Test Coverage Report for [Build 303](https://coveralls.io/builds/25549469) * **5** of **6** **(83.33%)** changed or added

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2927: Use JavaAgent introducing Sharding-JDBC

2019-09-05 Thread GitBox
sunbufu commented on issue #2927: Use JavaAgent introducing Sharding-JDBC URL: https://github.com/apache/incubator-shardingsphere/issues/2927#issuecomment-528608582 Sorry, Why should we replace the DataSource in connection pool? Can you give me some examples?

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2926: mysql page limit Long parameter type error

2019-09-05 Thread GitBox
terrymanu commented on issue #2926: mysql page limit Long parameter type error URL: https://github.com/apache/incubator-shardingsphere/issues/2926#issuecomment-528696510 @sunbufu Welcome This is an automated message from

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2926: mysql page limit Long parameter type error

2019-09-05 Thread GitBox
sunbufu commented on issue #2926: mysql page limit Long parameter type error URL: https://github.com/apache/incubator-shardingsphere/issues/2926#issuecomment-528610020 I agree with KomachiSion. This is an automated message

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #1899: Decide SQLs that need a default schema

2019-09-05 Thread GitBox
tuohai666 commented on issue #1899: Decide SQLs that need a default schema URL: https://github.com/apache/incubator-shardingsphere/issues/1899#issuecomment-528690740 Duplicate with #2673 This is an automated message from the

[GitHub] [incubator-shardingsphere] tuohai666 closed issue #1899: Decide SQLs that need a default schema

2019-09-05 Thread GitBox
tuohai666 closed issue #1899: Decide SQLs that need a default schema URL: https://github.com/apache/incubator-shardingsphere/issues/1899 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #239: replace travis build status with jenkins

2019-09-05 Thread GitBox
terrymanu merged pull request #239: replace travis build status with jenkins URL: https://github.com/apache/incubator-shardingsphere-doc/pull/239 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere-doc] terrymanu commented on issue #238: Add leaf key generator related content

2019-09-05 Thread GitBox
terrymanu commented on issue #238: Add leaf key generator related content URL: https://github.com/apache/incubator-shardingsphere-doc/pull/238#issuecomment-528686660 Cloud you remove company name from Chinese document? This

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #1423: config error and unsupport error throw on routing phase

2019-09-05 Thread GitBox
terrymanu commented on issue #1423: config error and unsupport error throw on routing phase URL: https://github.com/apache/incubator-shardingsphere/issues/1423#issuecomment-528689725 Close for expired This is an automated

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #1234: Proxy overload protection

2019-09-05 Thread GitBox
terrymanu commented on issue #1234: Proxy overload protection URL: https://github.com/apache/incubator-shardingsphere/issues/1234#issuecomment-528689644 Expired This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu closed issue #1234: Proxy overload protection

2019-09-05 Thread GitBox
terrymanu closed issue #1234: Proxy overload protection URL: https://github.com/apache/incubator-shardingsphere/issues/1234 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] terrymanu closed issue #1423: config error and unsupport error throw on routing phase

2019-09-05 Thread GitBox
terrymanu closed issue #1423: config error and unsupport error throw on routing phase URL: https://github.com/apache/incubator-shardingsphere/issues/1423 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2927: Use JavaAgent introducing Sharding-JDBC

2019-09-05 Thread GitBox
tuohai666 commented on issue #2927: Use JavaAgent introducing Sharding-JDBC URL: https://github.com/apache/incubator-shardingsphere/issues/2927#issuecomment-528691594 We don't have to replace the DataSource if you have better idea. There's no demo yet.

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2092: Update sharding key is allowed but not work

2019-09-05 Thread GitBox
betterjava commented on issue #2092: Update sharding key is allowed but not work URL: https://github.com/apache/incubator-shardingsphere/issues/2092#issuecomment-528695006 Ok,I got it.I will try do that. This is an automated

[GitHub] [incubator-shardingsphere] sunbufu edited a comment on issue #2926: mysql page limit Long parameter type error

2019-09-05 Thread GitBox
sunbufu edited a comment on issue #2926: mysql page limit Long parameter type error URL: https://github.com/apache/incubator-shardingsphere/issues/2926#issuecomment-528610020 I agree with KomachiSion, can i submit a PR ?

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2932: Cannot obtained Data from multiple data sources when integrating MyBatis with HitManager

2019-09-05 Thread GitBox
terrymanu closed issue #2932: Cannot obtained Data from multiple data sources when integrating MyBatis with HitManager URL: https://github.com/apache/incubator-shardingsphere/issues/2932 This is an automated message from

[GitHub] [incubator-shardingsphere] pitymonkey commented on a change in pull request #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

2019-09-05 Thread GitBox
pitymonkey commented on a change in pull request #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#discussion_r321553959 ## File path:

[GitHub] [incubator-shardingsphere] taojintianxia commented on issue #2948: My database table names are all uppercase , how to config ?

2019-09-05 Thread GitBox
taojintianxia commented on issue #2948: My database table names are all uppercase , how to config ? URL: https://github.com/apache/incubator-shardingsphere/issues/2948#issuecomment-528685527 > In MySQL, databases correspond to directories within the data directory. Each table within a

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2911: 4.0.0-RC2 does not support Oracle 12C connection configuration

2019-09-05 Thread GitBox
terrymanu commented on issue #2911: 4.0.0-RC2 does not support Oracle 12C connection configuration URL: https://github.com/apache/incubator-shardingsphere/issues/2911#issuecomment-528687688 For english only @timchan1011

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2092: Update sharding key is allowed but not work

2019-09-05 Thread GitBox
terrymanu commented on issue #2092: Update sharding key is allowed but not work URL: https://github.com/apache/incubator-shardingsphere/issues/2092#issuecomment-528691261 @betterjava Welcome to discuss this issue. For this issue, we should judge the SQL is update sharding key or

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2716: Optimization for OptimizedStatement

2019-09-05 Thread GitBox
terrymanu closed issue #2716: Optimization for OptimizedStatement URL: https://github.com/apache/incubator-shardingsphere/issues/2716 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2915: sharding-proxy mysql varchar can not complete display

2019-09-05 Thread GitBox
terrymanu commented on issue #2915: sharding-proxy mysql varchar can not complete display URL: https://github.com/apache/incubator-shardingsphere/issues/2915#issuecomment-528688181 > i find the answer。when use navicat 11.1.13 Enterprise Edition,some field can not complete display。but

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change.

2019-09-05 Thread GitBox
terrymanu closed issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change. URL: https://github.com/apache/incubator-shardingsphere/issues/2827

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change.

2019-09-05 Thread GitBox
terrymanu commented on issue #2827: The same transaction executes the following two sqls, and the last one is not the result of the current transaction change. URL: https://github.com/apache/incubator-shardingsphere/issues/2827#issuecomment-528688562 It is really too long time for waiting

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam

2019-09-05 Thread GitBox
terrymanu commented on issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam URL: https://github.com/apache/incubator-shardingsphere/issues/2860#issuecomment-528693631 Closed for no response anymore.

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam

2019-09-05 Thread GitBox
terrymanu closed issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam URL: https://github.com/apache/incubator-shardingsphere/issues/2860 This is an automated message from

[GitHub] [incubator-shardingsphere] pitymonkey commented on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

2019-09-05 Thread GitBox
pitymonkey commented on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-528681409 > for this issue, there are 2 point you should know. > > 1. enhance DataSourceUtils

[GitHub] [incubator-shardingsphere] terrymanu closed issue #1858: Add TransactionalDataSource to encapsulation distribute transaction.

2019-09-05 Thread GitBox
terrymanu closed issue #1858: Add TransactionalDataSource to encapsulation distribute transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/1858 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #1858: Add TransactionalDataSource to encapsulation distribute transaction.

2019-09-05 Thread GitBox
terrymanu commented on issue #1858: Add TransactionalDataSource to encapsulation distribute transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/1858#issuecomment-528690207 Close for expired This is

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2910: Use data source ID and table ID to force routing is required. There is no Value in some situation.

2019-09-05 Thread GitBox
terrymanu commented on issue #2910: Use data source ID and table ID to force routing is required. There is no Value in some situation. URL: https://github.com/apache/incubator-shardingsphere/issues/2910#issuecomment-528692543 Closed for no response anymore

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2910: Use data source ID and table ID to force routing is required. There is no Value in some situation.

2019-09-05 Thread GitBox
terrymanu closed issue #2910: Use data source ID and table ID to force routing is required. There is no Value in some situation. URL: https://github.com/apache/incubator-shardingsphere/issues/2910 This is an automated

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528702306 @xiyelife Hi, if first one is done, the second one, i think, there is a easier way to do.

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement.

2019-09-05 Thread GitBox
tristaZero commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement. URL: https://github.com/apache/incubator-shardingsphere/issues/2981#issuecomment-528703047 @sunbufu Are u interested in this, so easy. As i said

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2601: Verify the shardingRule at the beginning

2019-09-05 Thread GitBox
sunbufu commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-528708601 I think the difficulty is not on groovy script, It's on how to get the case to prove sharding rule is wrong, but we can not

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement.

2019-09-05 Thread GitBox
sunbufu commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement. URL: https://github.com/apache/incubator-shardingsphere/issues/2981#issuecomment-528709012 Yes, I'd like to do. This is an

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version

2019-09-05 Thread GitBox
tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-528711099 @gholly Hi, `insert into dd_bank_2 (application_number, company_id, id) values (?, ?, ?)` There is

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version

2019-09-05 Thread GitBox
tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-528711468 @yangjwInRiver I am sorry to give feedback so late, which column is your primary key? You not add

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement.

2019-09-05 Thread GitBox
tristaZero commented on issue #2981: It doesn't work when set properties for ShardingPreparedStatement. URL: https://github.com/apache/incubator-shardingsphere/issues/2981#issuecomment-528715322 Waiting for your pr.  This

[GitHub] [incubator-shardingsphere] StHsiang commented on issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam

2019-09-05 Thread GitBox
StHsiang commented on issue #2860: Access Sharing-Proxy 4.0.0RC2 with navicat return null point exception for lack of scheam URL: https://github.com/apache/incubator-shardingsphere/issues/2860#issuecomment-528697249 When I connectted to a sharding proxy 4.0.0-RC2 server with navicat

[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-05 Thread GitBox
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528210958 @betterjava this is the tablename. have anything wrong?

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2978: Filter out incorrect table which with only alias.

2019-09-05 Thread GitBox
terrymanu commented on issue #2978: Filter out incorrect table which with only alias. URL: https://github.com/apache/incubator-shardingsphere/pull/2978#issuecomment-528216649 Can you add test case for sql `delete xxx from tbl AS xxx WHERE xxx`?

[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-05 Thread GitBox
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528265133 @betterjava it looks like no problem

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-05 Thread GitBox
betterjava commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528267545 it seems like problem will happen when use mybatis-plus. I

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-05 Thread GitBox
betterjava edited a comment on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528267545 It seems like problem will happen when use

[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-05 Thread GitBox
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528268487 @betterjava thank you so much

[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411 not only batch insert,the sigle insert occured too ,here is my sql: encrypted columns:

[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411 not only batch insert,the sigle insert occured too ,here is my sql: encrypted columns:

[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528240055 @tristaZero ok ,that's what I thought at first. I'll try to modify my pr later. And I found

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528244617 The problem of interchanged column was solved at

[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-05 Thread GitBox
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528250990 @betterjava yes ,the table name is wrong... this

[GitHub] [incubator-shardingsphere] liaoxianrong opened a new issue #2980: The Long type parameters of Pagination are incompatible

2019-09-05 Thread GitBox
liaoxianrong opened a new issue #2980: The Long type parameters of Pagination are incompatible URL: https://github.com/apache/incubator-shardingsphere/issues/2980 When I using Mybatis-plus PaginationInterceptor plugin, shardingsphere does not work, something wrong has happend. Track it

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-05 Thread GitBox
betterjava commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528272468 @Keanhua which mybatis-plus version  you used?

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528278742 @xiyelife Hi, after my investigation, the similar problem also happens in

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2980: The Long type parameters of Pagination are incompatible

2019-09-05 Thread GitBox
KomachiSion commented on issue #2980: The Long type parameters of Pagination are incompatible URL: https://github.com/apache/incubator-shardingsphere/issues/2980#issuecomment-528280631 duplicate with #2926 This is an

[GitHub] [incubator-shardingsphere] Keanhua commented on issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-05 Thread GitBox
Keanhua commented on issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972#issuecomment-528284417 @betterjava 3.1.0

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2982: rm travis && and jenkins badge

2019-09-05 Thread GitBox
terrymanu merged pull request #2982: rm travis && and jenkins badge URL: https://github.com/apache/incubator-shardingsphere/pull/2982 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] KomachiSion closed issue #2980: The Long type parameters of Pagination are incompatible

2019-09-05 Thread GitBox
KomachiSion closed issue #2980: The Long type parameters of Pagination are incompatible URL: https://github.com/apache/incubator-shardingsphere/issues/2980 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] nancyzrh opened a new pull request #2982: rm travis && and jenkins badge

2019-09-05 Thread GitBox
nancyzrh opened a new pull request #2982: rm travis && and jenkins badge URL: https://github.com/apache/incubator-shardingsphere/pull/2982 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - -

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2982: rm travis && and jenkins badge

2019-09-05 Thread GitBox
coveralls commented on issue #2982: rm travis && and jenkins badge URL: https://github.com/apache/incubator-shardingsphere/pull/2982#issuecomment-528289353 ## Pull Request Test Coverage Report for [Build 292](https://coveralls.io/builds/25543187) * **0** of **0** changed or added

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2673: Support query for `DB.TBL` in ShardingProxy

2019-09-05 Thread GitBox
tuohai666 commented on issue #2673: Support query for `DB.TBL` in ShardingProxy URL: https://github.com/apache/incubator-shardingsphere/issues/2673#issuecomment-528222593 @benkris1 @xuanergg Let's discuss in english please.

[GitHub] [incubator-shardingsphere-doc] wgy8283335 opened a new pull request #238: Add leaf key generator related content

2019-09-05 Thread GitBox
wgy8283335 opened a new pull request #238: Add leaf key generator related content URL: https://github.com/apache/incubator-shardingsphere-doc/pull/238 Add leaf key generator related content This is an automated message from

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286 @xiyelife Thanks for [your kind

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286 @xiyelife Thanks for [your kind

[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #2957: sharding-proxy could not support hint strategy

2019-09-05 Thread GitBox
cherrylzhao edited a comment on issue #2957: sharding-proxy could not support hint strategy URL: https://github.com/apache/incubator-shardingsphere/issues/2957#issuecomment-528234303 created another hint enhance issue in #2979

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286 @xiyelife Thanks for [your kind

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286 @xiyelife Thanks for [your kind

[GitHub] [incubator-shardingsphere] xiyelife closed pull request #2977: Fixes #2923 when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife closed pull request #2977: Fixes #2923 when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/pull/2977 This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411 not only batch insert,the sigle insert occured too ,here is mysql: encrypted columns: name

[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411 not only batch insert,the sigle insert occured too ,here is my sql: **encrypted

[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528223411 not only batch insert,the sigle insert occured too ,here is my sql: encrypted columns:

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528229523 @xiyelife Thanks for your particular description. So great, i guess i get the point!

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528232286 @xiyelife Thanks for [your kind pr](https://github.com/apache/incubator-shardingsphere/pull/2977)

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528244617 The problem of interchanged column is solved at

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #2981: It doesn't work when set properties for ShardingPreparedStatement.

2019-09-05 Thread GitBox
tristaZero opened a new issue #2981: It doesn't work when set properties for ShardingPreparedStatement. URL: https://github.com/apache/incubator-shardingsphere/issues/2981 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you

[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-05 Thread GitBox
xiyelife commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-528303029 @tristaZero Hi, there are no incoming parameters to bind at the time of construction, which can

[GitHub] [incubator-shardingsphere] betterjava opened a new pull request #2983: fix Bug 2972

2019-09-05 Thread GitBox
betterjava opened a new pull request #2983: fix Bug 2972 URL: https://github.com/apache/incubator-shardingsphere/pull/2983 Fixes #2972. Changes proposed in this pull request: - We should not return original ResultSet for ShardingStatement or ShardingPreparedStatement.Because if

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2983: fix Bug 2972

2019-09-05 Thread GitBox
coveralls commented on issue #2983: fix Bug 2972 URL: https://github.com/apache/incubator-shardingsphere/pull/2983#issuecomment-528312869 ## Pull Request Test Coverage Report for [Build 293](https://coveralls.io/builds/25544265) * **0** of **0** changed or added relevant lines in