[GitHub] [shardingsphere] tristaZero merged pull request #5683: fix the proxy start problem

2020-05-19 Thread GitBox
tristaZero merged pull request #5683: URL: https://github.com/apache/shardingsphere/pull/5683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] kimmking commented on a change in pull request #5671: Initialize basic code structure for shardingsphere-cluster

2020-05-19 Thread GitBox
kimmking commented on a change in pull request #5671: URL: https://github.com/apache/shardingsphere/pull/5671#discussion_r427079795 ## File path:

[GitHub] [shardingsphere] Lucas-307 commented on issue #5458: scaling incrementalSyncTask is stuck

2020-05-19 Thread GitBox
Lucas-307 commented on issue #5458: URL: https://github.com/apache/shardingsphere/issues/5458#issuecomment-630602607 @malaxiaolongxia Maybe you can try any other server_id to new MySQLClient. `show variables like '%server_id%';` is select master server_id, MySQLClient is a slave, we

[GitHub] [shardingsphere] wubingting commented on issue #5680: Daily community promotion

2020-05-19 Thread GitBox
wubingting commented on issue #5680: URL: https://github.com/apache/shardingsphere/issues/5680#issuecomment-630625147 ok! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shardingsphere] tuohai666 opened a new pull request #5683: fix the proxy start problem

2020-05-19 Thread GitBox
tuohai666 opened a new pull request #5683: URL: https://github.com/apache/shardingsphere/pull/5683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] kimmking closed issue #5489: Improve unit test coverage of sharding-orchestration

2020-05-19 Thread GitBox
kimmking closed issue #5489: URL: https://github.com/apache/shardingsphere/issues/5489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [shardingsphere] yanyzy opened a new pull request #5682: Support spring namespace for shadow rule

2020-05-19 Thread GitBox
yanyzy opened a new pull request #5682: URL: https://github.com/apache/shardingsphere/pull/5682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5682: Support spring namespace for shadow rule

2020-05-19 Thread GitBox
codecov-commenter commented on pull request #5682: URL: https://github.com/apache/shardingsphere/pull/5682#issuecomment-630613780 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr=h1) Report > Merging

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #5671: Initialize basic code structure for shardingsphere-cluster

2020-05-19 Thread GitBox
menghaoranss commented on a change in pull request #5671: URL: https://github.com/apache/shardingsphere/pull/5671#discussion_r427083352 ## File path:

[GitHub] [shardingsphere] tristaZero merged pull request #5684: Redesign spring namespace for decouple datasource and rules dependencies

2020-05-19 Thread GitBox
tristaZero merged pull request #5684: URL: https://github.com/apache/shardingsphere/pull/5684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] tristaZero opened a new pull request #5686: Delete RuntimeContext

2020-05-19 Thread GitBox
tristaZero opened a new pull request #5686: URL: https://github.com/apache/shardingsphere/pull/5686 Ref #5593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] terrymanu opened a new pull request #5687: Add spring module sturctures

2020-05-19 Thread GitBox
terrymanu opened a new pull request #5687: URL: https://github.com/apache/shardingsphere/pull/5687 For #3691. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] Lucas-307 opened a new issue #5688: ShardingSphere-Scaling Mysql datasource checker is incomplete

2020-05-19 Thread GitBox
Lucas-307 opened a new issue #5688: URL: https://github.com/apache/shardingsphere/issues/5688 As a mysql slave, we should have `SELECT, REPLICATION SLAVE, REPLICATION CLIENT ON *.*` privileges. Current code only check `SELECT` and `REPLICATION CLIENT` privileges, it's not enough.

[GitHub] [shardingsphere] wubingting commented on issue #650: Welcome to leave your article link(欢迎留下关于ShardingSphere的文章链接)

2020-05-19 Thread GitBox
wubingting commented on issue #650: URL: https://github.com/apache/shardingsphere/issues/650#issuecomment-630646492 ### 文章汇总 *** 新闻快讯 - [新起航!Sharding-JDBC经过公投,正式改名为Sharding-Sphere](https://mp.weixin.qq.com/s/pVGqBwObhOCyTQK439rWvQ) -

[GitHub] [shardingsphere] kimmking merged pull request #5671: Initialize basic code structure for shardingsphere-cluster

2020-05-19 Thread GitBox
kimmking merged pull request #5671: URL: https://github.com/apache/shardingsphere/pull/5671 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] terrymanu opened a new pull request #5684: Redesign spring namespace for decouple datasource and rules dependencies

2020-05-19 Thread GitBox
terrymanu opened a new pull request #5684: URL: https://github.com/apache/shardingsphere/pull/5684 For #5508. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shardingsphere] cherrylzhao opened a new pull request #5685: split jdbc and proxy integration env

2020-05-19 Thread GitBox
cherrylzhao opened a new pull request #5685: URL: https://github.com/apache/shardingsphere/pull/5685 - add proxy it env file - use maven profile to split jdbc and proxy integration environment This is an automated message

[GitHub] [shardingsphere] tuohai666 merged pull request #5685: split jdbc and proxy integration env

2020-05-19 Thread GitBox
tuohai666 merged pull request #5685: URL: https://github.com/apache/shardingsphere/pull/5685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] tuohai666 merged pull request #5687: Add spring module sturctures

2020-05-19 Thread GitBox
tuohai666 merged pull request #5687: URL: https://github.com/apache/shardingsphere/pull/5687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] terrymanu merged pull request #5686: Delete RuntimeContext

2020-05-19 Thread GitBox
terrymanu merged pull request #5686: URL: https://github.com/apache/shardingsphere/pull/5686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] yanyzy merged pull request #5690: Split rule namespace to feature modules

2020-05-19 Thread GitBox
yanyzy merged pull request #5690: URL: https://github.com/apache/shardingsphere/pull/5690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] terrymanu closed issue #5508: New API design for 5.x

2020-05-19 Thread GitBox
terrymanu closed issue #5508: URL: https://github.com/apache/shardingsphere/issues/5508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] wubingting edited a comment on issue #650: Welcome to leave your article link(欢迎留下关于ShardingSphere的文章链接)

2020-05-19 Thread GitBox
wubingting edited a comment on issue #650: URL: https://github.com/apache/shardingsphere/issues/650#issuecomment-630646492 ### 文章汇总 *** 新闻快讯 - [新起航!Sharding-JDBC经过公投,正式改名为Sharding-Sphere](https://mp.weixin.qq.com/s/pVGqBwObhOCyTQK439rWvQ)

[GitHub] [shardingsphere] wubingting edited a comment on issue #650: Welcome to leave your article link(欢迎留下关于ShardingSphere的文章链接)

2020-05-19 Thread GitBox
wubingting edited a comment on issue #650: URL: https://github.com/apache/shardingsphere/issues/650#issuecomment-630646492 ### 文章汇总 *** 新闻快讯 - [新起航!Sharding-JDBC经过公投,正式改名为Sharding-Sphere](https://mp.weixin.qq.com/s/pVGqBwObhOCyTQK439rWvQ) -

[GitHub] [shardingsphere] kimmking commented on issue #5659: The event notice-board of the community (社区活动公告)

2020-05-19 Thread GitBox
kimmking commented on issue #5659: URL: https://github.com/apache/shardingsphere/issues/5659#issuecomment-630744758 > > Ten thousands applause and flowers for @tristaZero . > > Thanks @kimmking > I hear that there is another presentation presented by you. If we can take part in,

[GitHub] [shardingsphere] Lucas-307 commented on issue #5688: ShardingSphere-Scaling Mysql datasource checker is incomplete

2020-05-19 Thread GitBox
Lucas-307 commented on issue #5688: URL: https://github.com/apache/shardingsphere/issues/5688#issuecomment-630754412 @kimmking sure. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shardingsphere] terrymanu opened a new pull request #5690: Split rule namespace to feature modules

2020-05-19 Thread GitBox
terrymanu opened a new pull request #5690: URL: https://github.com/apache/shardingsphere/pull/5690 For #3691. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] tristaZero opened a new pull request #5689: Create DataSourceParameter.java

2020-05-19 Thread GitBox
tristaZero opened a new pull request #5689: URL: https://github.com/apache/shardingsphere/pull/5689 Ref #5593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] dongzl merged pull request #5689: Create DataSourceParameter.java

2020-05-19 Thread GitBox
dongzl merged pull request #5689: URL: https://github.com/apache/shardingsphere/pull/5689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] kimmking commented on issue #5688: ShardingSphere-Scaling Mysql datasource checker is incomplete

2020-05-19 Thread GitBox
kimmking commented on issue #5688: URL: https://github.com/apache/shardingsphere/issues/5688#issuecomment-630732032 Can you make a pr to improve it. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shardingsphere] wubingting edited a comment on issue #650: Welcome to leave your article link(欢迎留下关于ShardingSphere的文章链接)

2020-05-19 Thread GitBox
wubingting edited a comment on issue #650: URL: https://github.com/apache/shardingsphere/issues/650#issuecomment-630646492 ### 文章汇总 *** 新闻快讯 - [新起航!Sharding-JDBC经过公投,正式改名为Sharding-Sphere](https://mp.weixin.qq.com/s/pVGqBwObhOCyTQK439rWvQ) -

[GitHub] [shardingsphere] terrymanu merged pull request #5676: YamlRuleConfiguration is generated dynamically based on the user's co…

2020-05-19 Thread GitBox
terrymanu merged pull request #5676: URL: https://github.com/apache/shardingsphere/pull/5676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] wubingting edited a comment on issue #650: Welcome to leave your article link(欢迎留下关于ShardingSphere的文章链接)

2020-05-19 Thread GitBox
wubingting edited a comment on issue #650: URL: https://github.com/apache/shardingsphere/issues/650#issuecomment-630646492 ### 文章汇总 *** 新闻快讯 - [新起航!Sharding-JDBC经过公投,正式改名为Sharding-Sphere](https://mp.weixin.qq.com/s/pVGqBwObhOCyTQK439rWvQ)

[GitHub] [shardingsphere] avalon5666 commented on issue #5681: A complementary configuration for sharding-scaling

2020-05-19 Thread GitBox
avalon5666 commented on issue #5681: URL: https://github.com/apache/shardingsphere/issues/5681#issuecomment-630755578 Can we add field to distinguish source and destination component? For source, there has jdbc and shardingsphere configuration, the destination is the same as.

[GitHub] [shardingsphere] menghaoranss opened a new pull request #5691: Initialize cluster state module

2020-05-19 Thread GitBox
menghaoranss opened a new pull request #5691: URL: https://github.com/apache/shardingsphere/pull/5691 For #5666 Changes proposed in this pull request: - Write/read instance state to/from registry center - Initialize cluster state module, define the state api

[GitHub] [shardingsphere] terrymanu merged pull request #5692: fix pom.xml

2020-05-19 Thread GitBox
terrymanu merged pull request #5692: URL: https://github.com/apache/shardingsphere/pull/5692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] yu199195 opened a new pull request #5694: Fix Spring bean collection if have not one.

2020-05-19 Thread GitBox
yu199195 opened a new pull request #5694: URL: https://github.com/apache/shardingsphere/pull/5694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [shardingsphere] kimmking merged pull request #5696: Fix error when startup with metadata check enabled and no table created

2020-05-19 Thread GitBox
kimmking merged pull request #5696: URL: https://github.com/apache/shardingsphere/pull/5696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] kimmking merged pull request #5693: Use spring original bean:props instead of props-ref with spring namespace

2020-05-19 Thread GitBox
kimmking merged pull request #5693: URL: https://github.com/apache/shardingsphere/pull/5693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] terrymanu opened a new pull request #5696: Fix error when startup with metadata check enabled and no table created

2020-05-19 Thread GitBox
terrymanu opened a new pull request #5696: URL: https://github.com/apache/shardingsphere/pull/5696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] yu199195 opened a new pull request #5692: fix pom.xml

2020-05-19 Thread GitBox
yu199195 opened a new pull request #5692: URL: https://github.com/apache/shardingsphere/pull/5692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5695: Fix5486

2020-05-19 Thread GitBox
codecov-commenter commented on pull request #5695: URL: https://github.com/apache/shardingsphere/pull/5695#issuecomment-630938932 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5695?src=pr=h1) Report > Merging

[GitHub] [shardingsphere] terrymanu opened a new pull request #5693: Use spring original bean:props instead of props-ref with spring namespace

2020-05-19 Thread GitBox
terrymanu opened a new pull request #5693: URL: https://github.com/apache/shardingsphere/pull/5693 For #5508. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shardingsphere] cherrylzhao commented on issue #5626: the service method is select readonly transaction report the error "Expected command status BEGIN, got ."

2020-05-19 Thread GitBox
cherrylzhao commented on issue #5626: URL: https://github.com/apache/shardingsphere/issues/5626#issuecomment-630881738 As you see, the response packet of `Begin command` is wrong currently, so transaction operation could not been supported.

[GitHub] [shardingsphere] terrymanu merged pull request #5694: Fix Spring bean collection if have not one.

2020-05-19 Thread GitBox
terrymanu merged pull request #5694: URL: https://github.com/apache/shardingsphere/pull/5694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] kimmking opened a new pull request #5695: Fix5486

2020-05-19 Thread GitBox
kimmking opened a new pull request #5695: URL: https://github.com/apache/shardingsphere/pull/5695 Changes proposed in this pull request: - fix #5486 This is an automated message from the Apache Git Service. To respond

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5694: Fix Spring bean collection if have not one.

2020-05-19 Thread GitBox
codecov-commenter commented on pull request #5694: URL: https://github.com/apache/shardingsphere/pull/5694#issuecomment-630908519 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5694?src=pr=h1) Report > Merging

[shardingsphere-benchmark] branch master updated: for performance

2020-05-19 Thread zhangyonglun
This is an automated email from the ASF dual-hosted git repository. zhangyonglun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new cb8a9a4 for

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5691: Initialize cluster state module

2020-05-19 Thread GitBox
codecov-commenter commented on pull request #5691: URL: https://github.com/apache/shardingsphere/pull/5691#issuecomment-631175202 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5691?src=pr=h1) Report > Merging

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5682: Support spring namespace for shadow rule

2020-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #5682: URL: https://github.com/apache/shardingsphere/pull/5682#issuecomment-630613780 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr=h1) Report > Merging

[GitHub] [shardingsphere] dongzl commented on issue #5632: when insert sql have "role" column,sharding-jdbc can not route divided table

2020-05-19 Thread GitBox
dongzl commented on issue #5632: URL: https://github.com/apache/shardingsphere/issues/5632#issuecomment-631184068 > > Hi @wang7241 , 4.0.0-RC1 is an old version, you can try the newest release version, `4.1.0`. > > Excuse me for my questions,I think it is common to have a "role"

[GitHub] [shardingsphere] wang7241 commented on issue #5632: when insert sql have "role" column,sharding-jdbc can not route divided table

2020-05-19 Thread GitBox
wang7241 commented on issue #5632: URL: https://github.com/apache/shardingsphere/issues/5632#issuecomment-631184326 > > > Hi @wang7241 , 4.0.0-RC1 is an old version, you can try the newest release version, `4.1.0`. > > > > > > Excuse me for my questions,I think it is common to

[GitHub] [shardingsphere] iGitHubJ opened a new issue #5697: It happens"IllegalArgumentException: Property 'sqlSessionFactory' or 'sqlSessionTemplate' are required", when I use sharding orchestration

2020-05-19 Thread GitBox
iGitHubJ opened a new issue #5697: URL: https://github.com/apache/shardingsphere/issues/5697 ## Question It happens"IllegalArgumentException: Property 'sqlSessionFactory' or 'sqlSessionTemplate' are required", when I use sharding orchestration . env:springboot2.2.5

[GitHub] [shardingsphere] tristaZero opened a new pull request #5698: Refactor DataSourceConverter

2020-05-19 Thread GitBox
tristaZero opened a new pull request #5698: URL: https://github.com/apache/shardingsphere/pull/5698 Ref #5593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] menghaoranss closed pull request #5691: Initialize cluster state module

2020-05-19 Thread GitBox
menghaoranss closed pull request #5691: URL: https://github.com/apache/shardingsphere/pull/5691 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] terrymanu merged pull request #5682: Support spring namespace for shadow rule

2020-05-19 Thread GitBox
terrymanu merged pull request #5682: URL: https://github.com/apache/shardingsphere/pull/5682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] terrymanu opened a new pull request #5699: Rename package from org.apache.shardingsphere.driver.spring to org.apache.shardingsphere.spring

2020-05-19 Thread GitBox
terrymanu opened a new pull request #5699: URL: https://github.com/apache/shardingsphere/pull/5699 For #5636. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5698: Refactor DataSourceConverter

2020-05-19 Thread GitBox
codecov-commenter commented on pull request #5698: URL: https://github.com/apache/shardingsphere/pull/5698#issuecomment-631228464 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5698?src=pr=h1) Report > Merging

[GitHub] [shardingsphere] kimmking commented on a change in pull request #5691: Initialize cluster state module

2020-05-19 Thread GitBox
kimmking commented on a change in pull request #5691: URL: https://github.com/apache/shardingsphere/pull/5691#discussion_r427752090 ## File path:

[GitHub] [shardingsphere] yanyzy merged pull request #5699: Rename package from org.apache.shardingsphere.driver.spring to org.apache.shardingsphere.spring

2020-05-19 Thread GitBox
yanyzy merged pull request #5699: URL: https://github.com/apache/shardingsphere/pull/5699 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] terrymanu merged pull request #5698: Refactor DataSourceConverter

2020-05-19 Thread GitBox
terrymanu merged pull request #5698: URL: https://github.com/apache/shardingsphere/pull/5698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [shardingsphere] kimmking commented on issue #5697: It happens"IllegalArgumentException: Property 'sqlSessionFactory' or 'sqlSessionTemplate' are required", when I use sharding orchestration

2020-05-19 Thread GitBox
kimmking commented on issue #5697: URL: https://github.com/apache/shardingsphere/issues/5697#issuecomment-631249632 Hi, you should try 4.1.0 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shardingsphere] kimmking edited a comment on issue #5697: It happens"IllegalArgumentException: Property 'sqlSessionFactory' or 'sqlSessionTemplate' are required", when I use sharding orchest

2020-05-19 Thread GitBox
kimmking edited a comment on issue #5697: URL: https://github.com/apache/shardingsphere/issues/5697#issuecomment-631249632 Hi, did you config a custom datasource such like druid-starter? And you should try 4.1.0. This