[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521909700 Thanks for your effort. You really make big progress. --

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521873789 So, we should try to find way to support both of the implements.

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521600338 OK. I heard someone have tested with the version of io.zipkin.brave 5.1.1/io.opentracing.brav

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements

tuohai666 commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521143162 > @tuohai666 should I add SkywalkingTracer as default implement? It's not necessary.