Re: [I] ci: accidental actions/checkout failure in E2E-SQL [shardingsphere]
terrymanu closed issue #38298: ci: accidental actions/checkout failure in E2E-SQL URL: https://github.com/apache/shardingsphere/issues/38298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] ci: accidental actions/checkout failure in E2E-SQL [shardingsphere]
ym0506 commented on issue #38298:
URL:
https://github.com/apache/shardingsphere/issues/38298#issuecomment-4002408141
Follow-up correction (previous comment lost inline code formatting due shell
escaping):
I prepared a fix PR for this issue:
https://github.com/apache/shardingsphere/pull/38352
Summary of the patch:
- Explicitly set `ref: ${{ github.ref }}` for all `actions/checkout` steps
in `.github/workflows/e2e-sql.yml`
- Keep PR merged-with-base validation semantics while reducing accidental
`not our ref` checkout failures
- Scope is limited to E2E-SQL workflow checkout configuration only
Please review when convenient. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [I] ci: accidental actions/checkout failure in E2E-SQL [shardingsphere]
ym0506 commented on issue #38298: URL: https://github.com/apache/shardingsphere/issues/38298#issuecomment-4002407517 I prepared a fix PR for this issue: https://github.com/apache/shardingsphere/pull/38352\n\nSummary of the patch:\n- Explicitly set for all steps in \n- Keep PR merged-with-base validation semantics while reducing accidental checkout failures\n- Scope is limited to E2E-SQL workflow checkout configuration only\n\nPlease review when convenient. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] ci: accidental actions/checkout failure in E2E-SQL [shardingsphere]
ym0506 commented on issue #38298: URL: https://github.com/apache/shardingsphere/issues/38298#issuecomment-4001324402 I investigated this issue and compared failed/successful jobs in the same run: https://github.com/apache/shardingsphere/actions/runs/22547669595 The failed jobs hit `actions/checkout` with: `fatal: remote error: upload-pack: not our ref 48ffae5acbd53e554a99fe93ebd0cf6572a5a6a5` while other matrix jobs in the same run succeeded. So this looks like an intermittent synthetic-merge checkout problem, not a test-code regression. I’d like to propose a small workflow fix in `e2e-sql.yml`: - for `pull_request`, checkout by PR merge ref (`refs/pull//merge`) instead of relying on the synthetic merge SHA fetch path - keep `workflow_dispatch` behavior unchanged This still validates against merged-with-base state, but should reduce accidental `not our ref` failures. I can open a PR scoped to E2E-SQL first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] ci: accidental actions/checkout failure in E2E-SQL [shardingsphere]
sandynz commented on issue #38298: URL: https://github.com/apache/shardingsphere/issues/38298#issuecomment-3987937178 From https://github.blog/changelog/2026-02-19-changes-to-test-merge-commit-generation-for-pull-requests/ > To reduce delays when determining the mergeability for a pull request and improve system reliability, we’ve changed the frequency at which we generate test merge commits for open pull requests. > > Test merge commits will only be generated when one of the following is true: > > - Changes are pushed to the pull request branch. > - The merge base between the pull request and base branches changes. > - The current test merge commit is older than 12 hours. > > Previously, test merge commits were also generated when viewing the pull request page. > > This change does not impact mergeability checks, reporting of merge conflicts, or rule enforcement. Post it here for now, it might be useful for later investigation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] ci: accidental actions/checkout failure in E2E-SQL [shardingsphere]
sandynz commented on issue #38298: URL: https://github.com/apache/shardingsphere/issues/38298#issuecomment-3983951285 I'll monitor similar CI failure later, and do some improvement if necessary. ## Possible solution ### Solution 1. Use `github.event.pull_request.head.sha` in `actions/checkout` (not preferred) ``` - uses: actions/[email protected] with: ref: ${{ github.event.pull_request.head.sha }} ``` It could avoid this CI failure. Then PR could not reflect latest master branch changes, it might hide CI failure and merge error-prone code into master branch. ### Solution 2. Take source code snapshot and reuse it in matrix jobs (preferred) Take source code snapshot in prepare-e2e-artifacts job, and recover source code in e2e-sql matrix jobs. Not sure it could be implemented or not. I'll investigate it later if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
