[GitHub] wu-sheng closed issue #1020: StreamCorruptedException used version 5.6.8 es

2018-04-03 Thread GitBox
wu-sheng closed issue #1020: StreamCorruptedException used version 5.6.8 es URL: https://github.com/apache/incubator-skywalking/issues/1020 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #1020: StreamCorruptedException used version 5.6.8 es

2018-04-03 Thread GitBox
wu-sheng commented on issue #1020: StreamCorruptedException used version 5.6.8 es URL: https://github.com/apache/incubator-skywalking/issues/1020#issuecomment-378183002 5.6.8 is not our supported version. Maybe you can correct the document for use. 5.5 is latest version we supported.

[GitHub] jklliang opened a new issue #1020: StreamCorruptedException used version 5.6.8 es

2018-04-03 Thread GitBox
jklliang opened a new issue #1020: StreamCorruptedException used version 5.6.8 es URL: https://github.com/apache/incubator-skywalking/issues/1020 es version 5.6.8 , starte collecter throw StreamCorruptedException : exception info: 2018-04-03 16:42:34,348 -

[GitHub] wu-sheng commented on issue #1019: Fix two wrong urls.

2018-04-03 Thread GitBox
wu-sheng commented on issue #1019: Fix two wrong urls. URL: https://github.com/apache/incubator-skywalking/pull/1019#issuecomment-378177036 @michaelsembwever Done. This is an automated message from the Apache Git Service. To

[GitHub] candyleer opened a new pull request #1021: fix CONSTRUCTOR_WITH_LIST_HOSTANDPORT_ARG_INTERCEPT_CLASS spell error

2018-04-03 Thread GitBox
candyleer opened a new pull request #1021: fix CONSTRUCTOR_WITH_LIST_HOSTANDPORT_ARG_INTERCEPT_CLASS spell error URL: https://github.com/apache/incubator-skywalking/pull/1021 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug

[GitHub] candyleer closed pull request #1018: avoid "by zero" exception when all request are error and another class not found exception fix

2018-04-03 Thread GitBox
candyleer closed pull request #1018: avoid "by zero" exception when all request are error and another class not found exception fix URL: https://github.com/apache/incubator-skywalking/pull/1018 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it

[GitHub] candyleer opened a new pull request #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
candyleer opened a new pull request #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New

[GitHub] wu-sheng commented on issue #1018: avoid "by zero" exception when all request are error and another class not found exception fix

2018-04-03 Thread GitBox
wu-sheng commented on issue #1018: avoid "by zero" exception when all request are error and another class not found exception fix URL: https://github.com/apache/incubator-skywalking/pull/1018#issuecomment-378208275 @candyleer I assume it is a bug. Please help to fix this in another pr.

[GitHub] coveralls commented on issue #1018: avoid "by zero" exception when all request are error and another class not found exception fix

2018-04-03 Thread GitBox
coveralls commented on issue #1018: avoid "by zero" exception when all request are error and another class not found exception fix URL: https://github.com/apache/incubator-skywalking/pull/1018#issuecomment-378142457 [![Coverage

[GitHub] coveralls commented on issue #1018: avoid "by zero" exception when all request are error and another class not found exception fix

2018-04-03 Thread GitBox
coveralls commented on issue #1018: avoid "by zero" exception when all request are error and another class not found exception fix URL: https://github.com/apache/incubator-skywalking/pull/1018#issuecomment-378142457 [![Coverage

[GitHub] wu-sheng commented on a change in pull request #1018: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
wu-sheng commented on a change in pull request #1018: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1018#discussion_r178737496 ## File path:

[GitHub] coveralls commented on issue #1018: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
coveralls commented on issue #1018: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1018#issuecomment-378142457 [![Coverage Status](https://coveralls.io/builds/16308951/badge)](https://coveralls.io/builds/16308951)

[GitHub] michaelsembwever commented on a change in pull request #1019: Fix two wrong urls.

2018-04-03 Thread GitBox
michaelsembwever commented on a change in pull request #1019: Fix two wrong urls. URL: https://github.com/apache/incubator-skywalking/pull/1019#discussion_r178725986 ## File path: docs/en/How-to-release.md ## @@ -269,10 +269,18 @@ I will procedd to publish the release

[GitHub] wu-sheng opened a new pull request #1019: Fix two wrong urls.

2018-04-03 Thread GitBox
wu-sheng opened a new pull request #1019: Fix two wrong urls. URL: https://github.com/apache/incubator-skywalking/pull/1019 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng closed pull request #1: Update 2017-12-21-quick-start.md

2018-04-03 Thread GitBox
wu-sheng closed pull request #1: Update 2017-12-21-quick-start.md URL: https://github.com/apache/incubator-skywalking-website/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] coveralls commented on issue #1019: Fix two wrong urls.

2018-04-03 Thread GitBox
coveralls commented on issue #1019: Fix two wrong urls. URL: https://github.com/apache/incubator-skywalking/pull/1019#issuecomment-378149441 [![Coverage Status](https://coveralls.io/builds/16309264/badge)](https://coveralls.io/builds/16309264) Coverage remained the same at

[GitHub] coveralls commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
coveralls commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378249519 [![Coverage Status](https://coveralls.io/builds/16314949/badge)](https://coveralls.io/builds/16314949)

[GitHub] wu-sheng closed pull request #1021: fix CONSTRUCTOR_WITH_LIST_HOSTANDPORT_ARG_INTERCEPT_CLASS spell error

2018-04-03 Thread GitBox
wu-sheng closed pull request #1021: fix CONSTRUCTOR_WITH_LIST_HOSTANDPORT_ARG_INTERCEPT_CLASS spell error URL: https://github.com/apache/incubator-skywalking/pull/1021 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] coveralls commented on issue #1021: fix CONSTRUCTOR_WITH_LIST_HOSTANDPORT_ARG_INTERCEPT_CLASS spell error

2018-04-03 Thread GitBox
coveralls commented on issue #1021: fix CONSTRUCTOR_WITH_LIST_HOSTANDPORT_ARG_INTERCEPT_CLASS spell error URL: https://github.com/apache/incubator-skywalking/pull/1021#issuecomment-378245683 [![Coverage

[GitHub] peng-yongsheng opened a new pull request #1023: Source release from the new codes by git clone.

2018-04-03 Thread GitBox
peng-yongsheng opened a new pull request #1023: Source release from the new codes by git clone. URL: https://github.com/apache/incubator-skywalking/pull/1023 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Document -

[GitHub] wu-sheng opened a new issue #1024: Ask some helps for Chinese document

2018-04-03 Thread GitBox
wu-sheng opened a new issue #1024: Ask some helps for Chinese document URL: https://github.com/apache/incubator-skywalking/issues/1024 Based on Apache requirements, we provided all documents in English as default. But we have a lot of Chinese end users, so, we are always looking for

[GitHub] coveralls commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
coveralls commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378249519 [![Coverage Status](https://coveralls.io/builds/16317575/badge)](https://coveralls.io/builds/16317575)

[GitHub] coveralls commented on issue #1023: Source release from the new codes by git clone.

2018-04-03 Thread GitBox
coveralls commented on issue #1023: Source release from the new codes by git clone. URL: https://github.com/apache/incubator-skywalking/pull/1023#issuecomment-378296804 [![Coverage Status](https://coveralls.io/builds/16317966/badge)](https://coveralls.io/builds/16317966)

[GitHub] zone1511 opened a new issue #1025: Unable to attach source

2018-04-03 Thread GitBox
zone1511 opened a new issue #1025: Unable to attach source URL: https://github.com/apache/incubator-skywalking/issues/1025 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirement

[GitHub] coveralls commented on issue #1023: Source release from the new codes by git clone.

2018-04-03 Thread GitBox
coveralls commented on issue #1023: Source release from the new codes by git clone. URL: https://github.com/apache/incubator-skywalking/pull/1023#issuecomment-378296804 [![Coverage Status](https://coveralls.io/builds/16329254/badge)](https://coveralls.io/builds/16329254)

[GitHub] WillemJiang opened a new pull request #1026: Enable the build of ServiceComb Java Chassis

2018-04-03 Thread GitBox
WillemJiang opened a new pull request #1026: Enable the build of ServiceComb Java Chassis URL: https://github.com/apache/incubator-skywalking/pull/1026 As ServiceComb Java Chassis 1.0.0-m1 is release, we should enable the build and publish the SNAPSHOT build of it.

[GitHub] coveralls commented on issue #1026: Enable the build of ServiceComb Java Chassis

2018-04-03 Thread GitBox
coveralls commented on issue #1026: Enable the build of ServiceComb Java Chassis URL: https://github.com/apache/incubator-skywalking/pull/1026#issuecomment-378446964 [![Coverage Status](https://coveralls.io/builds/16330072/badge)](https://coveralls.io/builds/16330072) Coverage

[GitHub] wu-sheng commented on issue #1025: Unable to attach source

2018-04-03 Thread GitBox
wu-sheng commented on issue #1025: Unable to attach source URL: https://github.com/apache/incubator-skywalking/issues/1025#issuecomment-378448767 @zone1511 I am not familiar with your question and error. Can you provide more logs? What is happening?

[GitHub] wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378417329 @peng-yongsheng if we intend to process error in tps and avg reponse time, I think there are three metrics 1.

[GitHub] coveralls commented on issue #1019: Fix two wrong urls.

2018-04-03 Thread GitBox
coveralls commented on issue #1019: Fix two wrong urls. URL: https://github.com/apache/incubator-skywalking/pull/1019#issuecomment-378149441 [![Coverage Status](https://coveralls.io/builds/16328128/badge)](https://coveralls.io/builds/16328128) Coverage remained the same at

[GitHub] wu-sheng closed pull request #1019: Fix two wrong urls.

2018-04-03 Thread GitBox
wu-sheng closed pull request #1019: Fix two wrong urls. URL: https://github.com/apache/incubator-skywalking/pull/1019 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] coveralls commented on issue #1017: Because of key issue, system env override can't be supported.

2018-04-03 Thread GitBox
coveralls commented on issue #1017: Because of key issue, system env override can't be supported. URL: https://github.com/apache/incubator-skywalking/pull/1017#issuecomment-378122466 [![Coverage

[GitHub] wu-sheng closed pull request #1017: Because of key issue, system env override can't be supported.

2018-04-03 Thread GitBox
wu-sheng closed pull request #1017: Because of key issue, system env override can't be supported. URL: https://github.com/apache/incubator-skywalking/pull/1017 This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-03 Thread GitBox
wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378471557 Do you have actual serve access from browser or somewhere? The UI and traces should be showed automatically, if you

[GitHub] candyleer commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
candyleer commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378476944 @peng-yongsheng great ,tks i fix this bug in 5 files, please review if there miss any file and is it right ?

[GitHub] coveralls commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
coveralls commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378249519 [![Coverage Status](https://coveralls.io/builds/16331627/badge)](https://coveralls.io/builds/16331627)

[GitHub] coveralls commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
coveralls commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378249519 [![Coverage Status](https://coveralls.io/builds/16332080/badge)](https://coveralls.io/builds/16332080)

[GitHub] WillemJiang opened a new pull request #1027: Update the support version of ServiceComb

2018-04-03 Thread GitBox
WillemJiang opened a new pull request #1027: Update the support version of ServiceComb URL: https://github.com/apache/incubator-skywalking/pull/1027 This is an automated message from the Apache Git Service. To respond to

[GitHub] wu-sheng closed pull request #1027: Update the support version of ServiceComb

2018-04-03 Thread GitBox
wu-sheng closed pull request #1027: Update the support version of ServiceComb URL: https://github.com/apache/incubator-skywalking/pull/1027 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] wu-sheng commented on issue #1025: Unable to attach source

2018-04-03 Thread GitBox
wu-sheng commented on issue #1025: Unable to attach source URL: https://github.com/apache/incubator-skywalking/issues/1025#issuecomment-378460977 I got `BUILD SUCCESS` after I run `mvn source:jar`. Do you run this in `master` branch? From my experience, our Apache release already includes

[GitHub] wu-sheng commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor

2018-04-03 Thread GitBox
wu-sheng commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1028#issuecomment-378462495 @IluckySi Because you have still not provided your auto test cases, this bug can't be detected

[GitHub] coveralls commented on issue #1027: Update the support version of ServiceComb

2018-04-03 Thread GitBox
coveralls commented on issue #1027: Update the support version of ServiceComb URL: https://github.com/apache/incubator-skywalking/pull/1027#issuecomment-378458005 [![Coverage Status](https://coveralls.io/builds/16330763/badge)](https://coveralls.io/builds/16330763) Coverage

[GitHub] peng-yongsheng commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
peng-yongsheng commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378459919 @candyleer I can help you to find all places which need to fixed.

[GitHub] 50168383 commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor

2018-04-03 Thread GitBox
50168383 commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1028#issuecomment-378461512 add Exception more detail : DEBUG 2018-04-04 09:41:31

[GitHub] wu-sheng commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor

2018-04-03 Thread GitBox
wu-sheng commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1028#issuecomment-378462180 I think this is a bug of `xmemcached` plugin. All classes defined in

[GitHub] peng-yongsheng commented on issue #1023: Source release from the new codes by git clone.

2018-04-03 Thread GitBox
peng-yongsheng commented on issue #1023: Source release from the new codes by git clone. URL: https://github.com/apache/incubator-skywalking/pull/1023#issuecomment-378466063 @wu-sheng This PR modify the implementation, not change the usage mode of the script. The document contains the

[GitHub] candyleer commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
candyleer commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378467093 @wu-sheng ok, i will update soon This is an

[GitHub] wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-03 Thread GitBox
wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378467795 @peng-yongsheng Please provide a change list, to help @candyleer 's contributions and our review works. Thanks.