[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378507435 @ascrutae where "toggle breakpoint" i can set ? org.apache.skywalking.apm.agent.core.remote.TraceSegmentServiceClient.

[GitHub] candyleer opened a new pull request #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript

2018-04-04 Thread GitBox
candyleer opened a new pull request #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript URL: https://github.com/apache/incubator-skywalking-ui/pull/154 in web ui menu "Server",it throw an exception that is ``` Validation error of type FieldUndefined: Field

[GitHub] wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378514748 Yes, you can set there. Or TracingContext#createSpan. Or the interceptor of the certain plugin (eg, SpringMVC) ---

[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378519827 before ignore exception ERROR 2018-04-04 09:53:33 InstMethodsInter : class[class org.apache.http.impl.client.De

[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378519827 before ignore exception ERROR 2018-04-04 09:53:33 InstMethodsInter : class[class org.apache.http.impl.client.De

[GitHub] peng-yongsheng commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
peng-yongsheng commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378523338 @candyleer Notice that there is a main content "**But I dont like change the metric meaning in different c

[GitHub] wu-sheng commented on issue #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript

2018-04-04 Thread GitBox
wu-sheng commented on issue #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript URL: https://github.com/apache/incubator-skywalking-ui/pull/154#issuecomment-378527184 @candyleer I think you are faster than our PMC :) This is a new version(beta) feature, check h

[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378527210 1 Trace created; 2 trace segments have been sent to collector. ok . where "toggle breakpoint" i can set

[GitHub] wu-sheng commented on issue #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript

2018-04-04 Thread GitBox
wu-sheng commented on issue #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript URL: https://github.com/apache/incubator-skywalking-ui/pull/154#issuecomment-378527526 I mean here: ![image](https://user-images.githubusercontent.com/5441976/38297712-e68656

[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378527978 i think find . is org.apache.skywalking.apm.collector.storage.es.dao.GlobalTraceEsPersistenceDAO ? ---

[GitHub] peng-yongsheng opened a new issue #1032: Collector performance optimization

2018-04-04 Thread GitBox
peng-yongsheng opened a new issue #1032: Collector performance optimization URL: https://github.com/apache/incubator-skywalking/issues/1032 1. Use collector instrument module to collect performance metrics report. This is an a

[GitHub] sebbASF opened a new issue #1033: Download page must include links to KEYS, sigs, hashes

2018-04-04 Thread GitBox
sebbASF opened a new issue #1033: Download page must include links to KEYS, sigs, hashes URL: https://github.com/apache/incubator-skywalking/issues/1033 The download page: http://skywalking.apache.org/downloads/ must include links to KEYS, sigs and hashes and should indicate how to v

[GitHub] candyleer commented on issue #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript

2018-04-04 Thread GitBox
candyleer commented on issue #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript URL: https://github.com/apache/incubator-skywalking-ui/pull/154#issuecomment-378532469 @wu-sheng haha ,i have updated this `serverInfo.osName` just now , and now it's worked !

[GitHub] wu-sheng commented on issue #1031: Links missing from website

2018-04-04 Thread GitBox
wu-sheng commented on issue #1031: Links missing from website URL: https://github.com/apache/incubator-skywalking/issues/1031#issuecomment-378532786 Thanks, I will adjust our website. This is an automated message from the Apa

[GitHub] candyleer commented on issue #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript

2018-04-04 Thread GitBox
candyleer commented on issue #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript URL: https://github.com/apache/incubator-skywalking-ui/pull/154#issuecomment-378532469 @wu-sheng haha ,i have updated this `serverInfo.osName` just now , and now it's worked since

[GitHub] sebbASF opened a new issue #1031: Links missing from website

2018-04-04 Thread GitBox
sebbASF opened a new issue #1031: Links missing from website URL: https://github.com/apache/incubator-skywalking/issues/1031 There do not appear to be any links to the following on the website: - issue tracker - mailing lists ASF projects must also link to: - AL 2.0 licen

[GitHub] coveralls commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
coveralls commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378249519 [![Coverage Status](https://coveralls.io/builds/16335034/badge)](https://coveralls.io/builds/16335034) C

[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378541112 TraceSegmentServiceHandler segmentParseService.parse(segment, ISegmentParseService.Source.Agent);

[GitHub] candyleer commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
candyleer commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378541735 @peng-yongsheng ok, i understand what you mean Th

[GitHub] wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378546037 Do you even delete es data, but didnt restart agent/ application? -

[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378547624 i don't restart agent in debugging . This is an automa

[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378547769 and no even delete es data This is an automated messa

[GitHub] wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.

2018-04-04 Thread GitBox
wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-378549258 @peng-yongsheng could you provide more ways to debug?

[GitHub] ascrutae commented on issue #1030: 5.0-alpha , Can't find Jorg.apache.skywalking.apm.plugin.jedis.v2.edisClusterConstructorWithListHostAndPortArgInterceptor

2018-04-04 Thread GitBox
ascrutae commented on issue #1030: 5.0-alpha , Can't find Jorg.apache.skywalking.apm.plugin.jedis.v2.edisClusterConstructorWithListHostAndPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1030#issuecomment-378550517 @50168383 Thanks for your mention! This i

[GitHub] wu-sheng commented on issue #1030: 5.0-alpha , Can't find Jorg.apache.skywalking.apm.plugin.jedis.v2.edisClusterConstructorWithListHostAndPortArgInterceptor

2018-04-04 Thread GitBox
wu-sheng commented on issue #1030: 5.0-alpha , Can't find Jorg.apache.skywalking.apm.plugin.jedis.v2.edisClusterConstructorWithListHostAndPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1030#issuecomment-378550608 This is a similar bug as #1028 . Change to the

[GitHub] wu-sheng closed issue #1030: 5.0-alpha , Can't find Jorg.apache.skywalking.apm.plugin.jedis.v2.edisClusterConstructorWithListHostAndPortArgInterceptor

2018-04-04 Thread GitBox
wu-sheng closed issue #1030: 5.0-alpha , Can't find Jorg.apache.skywalking.apm.plugin.jedis.v2.edisClusterConstructorWithListHostAndPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1030 This is a

[GitHub] 50168383 opened a new issue #1030: 5.0-alpha , Can't find Jorg.apache.skywalking.apm.plugin.jedis.v2.edisClusterConstructorWithListHostAndPortArgInterceptor

2018-04-04 Thread GitBox
50168383 opened a new issue #1030: 5.0-alpha , Can't find Jorg.apache.skywalking.apm.plugin.jedis.v2.edisClusterConstructorWithListHostAndPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1030 Please answer these questions before submitting your issue. - W

[GitHub] coveralls commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
coveralls commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378249519 [![Coverage Status](https://coveralls.io/builds/16336210/badge)](https://coveralls.io/builds/16336210) C

[GitHub] peng-yongsheng opened a new issue #1034: Collector automated testing for storage module

2018-04-04 Thread GitBox
peng-yongsheng opened a new issue #1034: Collector automated testing for storage module URL: https://github.com/apache/incubator-skywalking/issues/1034 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Feature or performance improvem

[GitHub] wu-sheng commented on issue #1031: Links missing from website

2018-04-04 Thread GitBox
wu-sheng commented on issue #1031: Links missing from website URL: https://github.com/apache/incubator-skywalking/issues/1031#issuecomment-378600383 Links updated. ![image](https://user-images.githubusercontent.com/5441976/38310536-61f415be-384f-11e8-9a33-b386549b1562.png)

[GitHub] wu-sheng commented on issue #1033: Download page must include links to KEYS, sigs, hashes

2018-04-04 Thread GitBox
wu-sheng commented on issue #1033: Download page must include links to KEYS, sigs, hashes URL: https://github.com/apache/incubator-skywalking/issues/1033#issuecomment-378600936 Download page updated. ![image](https://user-images.githubusercontent.com/5441976/38310590-8c38491c-384f-

[GitHub] wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378606332 @candyleer Is already done? Or need further works?

[GitHub] wu-sheng commented on issue #1034: Collector automated testing for storage module

2018-04-04 Thread GitBox
wu-sheng commented on issue #1034: Collector automated testing for storage module URL: https://github.com/apache/incubator-skywalking/issues/1034#issuecomment-378609841 > [Source code project](https://github.com/{Account ID}/{forked project name from incubator-skywalking}) Forked p

[GitHub] candyleer commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
candyleer commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378613464 @wu-sheng already done,it's worked This is an aut

[GitHub] wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378615762 @peng-yongsheng Please review this. This is an auto

[GitHub] sebbASF commented on issue #1033: Download page must include links to KEYS, sigs, hashes

2018-04-04 Thread GitBox
sebbASF commented on issue #1033: Download page must include links to KEYS, sigs, hashes URL: https://github.com/apache/incubator-skywalking/issues/1033#issuecomment-378680988 Sorry, but the KEYS, sigs and hashes URLs must not use dist.apache.org. That host is not intended for public use;

[GitHub] sebbASF opened a new issue #1035: Website must have incubation disclaimer and standard copyright footer

2018-04-04 Thread GitBox
sebbASF opened a new issue #1035: Website must have incubation disclaimer and standard copyright footer URL: https://github.com/apache/incubator-skywalking/issues/1035 All podling websites must have an incubation disclaimer. They must also have a standard copyright footer. -

[GitHub] coveralls commented on issue #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
coveralls commented on issue #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378249519 [![Coverage Status](https://coveralls.io/builds/16353674/badge)](https://coveralls.io/builds/16353674) C

[GitHub] peng-yongsheng closed pull request #1022: avoid "by zero" exception when all request are error

2018-04-04 Thread GitBox
peng-yongsheng closed pull request #1022: avoid "by zero" exception when all request are error URL: https://github.com/apache/incubator-skywalking/pull/1022 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov