[GitHub] chidaodezhongsheng opened a new pull request #1220: support shardingjdbc database storage feature

2018-05-13 Thread GitBox
chidaodezhongsheng opened a new pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] New feature provided

[GitHub] coveralls commented on issue #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
coveralls commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388535000 [![Coverage Status](https://coveralls.io/builds/16963044/badge)](https://coveralls.io/builds/16963044) Coverage increased

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388693585 -javaagent:~/skywalking-agent/skywalking-agent.jar ``` private static AbstractTracerContext getOrCreate(String operationName,

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187836198 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388693585 ignore me This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388687519 @leizhiyuan You could debug the `TracingContext#finish`. The `TraceSegment` in the method should contain all the data you need.

[GitHub] franknew opened a new issue #1219: bug: the agent file path with blank space in windows server would report an error

2018-05-13 Thread GitBox
franknew opened a new issue #1219: bug: the agent file path with blank space in windows server would report an error URL: https://github.com/apache/incubator-skywalking/issues/1219 agent path:C:/Program Files/Apache Software Foundation/Tomcat 7.0_Tomcat7_8024/agent/skywalking-agent.jar

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804736 ## File path:

[GitHub] candyleer commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
candyleer commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187805028 ## File path:

[GitHub] candyleer commented on issue #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
candyleer commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388635799 I will all the enhance class and method as constant variables This is

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804908 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804858 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804932 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804927 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804934 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804912 ## File path:

[GitHub] candyleer commented on issue #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
candyleer commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388636416 OK,thanks for you review and I will follow your suggestions This is an

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804867 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804871 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804867 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804858 ## File path:

[GitHub] candyleer commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
candyleer commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187805003 ## File path:

[GitHub] wu-sheng closed pull request #1218: Fix http_client plugin

2018-05-13 Thread GitBox
wu-sheng closed pull request #1218: Fix http_client plugin URL: https://github.com/apache/incubator-skywalking/pull/1218 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng closed issue #1211: The same operation has a duplicate globalTraceID´╝Ť

2018-05-13 Thread GitBox
wu-sheng closed issue #1211: The same operation has a duplicate globalTraceID´╝Ť URL: https://github.com/apache/incubator-skywalking/issues/1211 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6

2018-05-13 Thread GitBox
wu-sheng commented on issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6 URL: https://github.com/apache/incubator-skywalking/issues/1214#issuecomment-388668300 What do you mean about stack number? The whole project is

[GitHub] wu-sheng closed issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6

2018-05-13 Thread GitBox
wu-sheng closed issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6 URL: https://github.com/apache/incubator-skywalking/issues/1214 This is an automated

[GitHub] coveralls commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-13 Thread GitBox
coveralls commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-387610938 [![Coverage Status](https://coveralls.io/builds/16962218/badge)](https://coveralls.io/builds/16962218)

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820793 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187819683 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820927 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820993 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820481 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820358 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@ -98,11

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820452 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187821464 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187821901 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187822108 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187822039 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187822748 ## File path:

[GitHub] candyleer commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-13 Thread GitBox
candyleer commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-388676751 Yes ,I tested, it works .it just like ``` select * from table where service_name like "%value%" ```

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged locally,

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged locally,