[GitHub] wu-sheng commented on issue #1124: Duplicated service search result

2018-05-14 Thread GitBox
wu-sheng commented on issue #1124: Duplicated service search result URL: https://github.com/apache/incubator-skywalking/issues/1124#issuecomment-386185825 I am moving this issue to beta2, because this is caused by this service is out of date. I guess, some one sets the application code

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388727682 @wu-sheng thanks a lot, I will resolve the conflicts and mentions. 技术部·架构部·林嘉琦 手机:18710075837

[GitHub] liuwei881 commented on issue #1221: sky walking是否提供python 的api,就是直接通过python调取skywalking的相关信息?

2018-05-14 Thread GitBox
liuwei881 commented on issue #1221: sky walking是否提供python 的api,就是直接通过python调取skywalking的相关信息? URL: https://github.com/apache/incubator-skywalking/issues/1221#issuecomment-388707922 sky walking是否提供python 的api? This is an

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388727682 @wu-sheng thanks a lot, I will resolve the conflicts and mentions. 技术部·架构部·林嘉琦 手机:18710075837

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388736637 @wu-sheng thanks a lot, I will resolve the conflicts and mentions.

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187901397 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187901335 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@

[GitHub] Rainbowboys opened a new issue #1223: Some doubts about the ui

2018-05-14 Thread GitBox
Rainbowboys opened a new issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ]

[GitHub] wu-sheng commented on issue #1221: Does SkyWalking support Python API?

2018-05-14 Thread GitBox
wu-sheng commented on issue #1221: Does SkyWalking support Python API? URL: https://github.com/apache/incubator-skywalking/issues/1221#issuecomment-388710765 You could see from the readme. SkyWalking is supporting multiple languages, Java, .NET, Nodejs. Go is still ongoing. But you should

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858734 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,13 @@ +# Supported Database

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858505 ## File path: docs/README.md ## @@ -1,45 +1,46 @@ -## Documents -[![cn

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187851353 ## File path: apm-collector/apm-collector-boot/src/main/resources/application.yml ##

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858208 ## File path: apm-dist/release-docs/LICENSE ## @@ -255,6 +256,7 @@ The text of each

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858863 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,13 @@ +# Supported Database

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898156 ## File path: docs/README_ZH.md ## @@ -1,42 +1,46 @@ -## 中文文档 -[![EN

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898936 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,21 @@ +# Supported Database

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899581 ## File path: docs/README_ZH.md ## @@ -1,42 +1,46 @@ -## 中文文档 -[![EN

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [![Coverage

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388747564 When we release sofarpc 5.4.0 I will provide a new test report This is

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187879656 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187881241 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187879700 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@ -31,11

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187883147 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/pom.xml

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899006 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,21 @@ +# Supported Database

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898905 ## File path: docs/cn/Shardingjdbc-CN.md ## @@ -0,0 +1,21 @@ +# 支持数据库分片存储

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899019 ## File path: docs/cn/Shardingjdbc-CN.md ## @@ -0,0 +1,21 @@ +# 支持数据库分片存储

[GitHub] liuwei881 opened a new issue #1221: sky walking是否提供python 的api,就是直接通过python调取skywalking的相关信息?

2018-05-14 Thread GitBox
liuwei881 opened a new issue #1221: sky walking是否提供python 的api,就是直接通过python调取skywalking的相关信息? URL: https://github.com/apache/incubator-skywalking/issues/1221 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388745138 @leizhiyuan Ping us when you are ready (after release). And I have to ask, where does

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388742185 @wu-sheng I have tested it, It seems everything is ok,

[GitHub] dinggel opened a new issue #1222: How do I package the master branch code?

2018-05-14 Thread GitBox
dinggel opened a new issue #1222: How do I package the master branch code? URL: https://github.com/apache/incubator-skywalking/issues/1222 I want to use the latest version of incubator-skywalking-ui,i have some problems when i run the master branch code of incubator-skywalking-ui with the

[GitHub] wu-sheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388715549 @chidaodezhongsheng Conflicts must be resolved. This is

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187961412 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187903231 ## File path:

[GitHub] liliang8858 opened a new issue #1226: Exception while executing runnable

2018-05-14 Thread GitBox
liliang8858 opened a new issue #1226: Exception while executing runnable URL: https://github.com/apache/incubator-skywalking/issues/1226 - Why do you submit this issue? - [0] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___

[GitHub] wu-sheng commented on issue #1219: bug: the agent file path with blank space in windows server would report an error

2018-05-14 Thread GitBox
wu-sheng commented on issue #1219: bug: the agent file path with blank space in windows server would report an error URL: https://github.com/apache/incubator-skywalking/issues/1219#issuecomment-388804792 Maybe you can debug on your env? Try to find what happens, and send a pull request?

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187959970 ## File path:

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187959970 ## File path:

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187961811 ## File path:

[GitHub] tangmingming closed issue #1224: agent启动报错

2018-05-14 Thread GitBox
tangmingming closed issue #1224: agent启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1224 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] tangmingming commented on issue #1224: agent启动报错

2018-05-14 Thread GitBox
tangmingming commented on issue #1224: agent启动报错 URL: https://github.com/apache/incubator-skywalking/issues/1224#issuecomment-388776203 是我服务端application.yml 配置有问题 改成本机IP(10.111.80.226)就好了 naming: jetty: host: 0.0.0.0 port: 10800 context_path: / remote:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187911271 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@

[GitHub] liliang8858 commented on issue #1226: Exception while executing runnable

2018-05-14 Thread GitBox
liliang8858 commented on issue #1226: Exception while executing runnable URL: https://github.com/apache/incubator-skywalking/issues/1226#issuecomment-388794743 There is no GRPC Must the GRPC be started? This is an

[GitHub] wu-sheng opened a new pull request #1227: Update README.md

2018-05-14 Thread GitBox
wu-sheng opened a new pull request #1227: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/1227 Miss a word in readme. This is an automated message from the Apache Git Service. To respond to the

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187960804 ## File path:

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187963546 ## File path:

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187965357 ## File path:

[GitHub] wu-sheng commented on issue #1225: 5.0 configuration issues.

2018-05-14 Thread GitBox
wu-sheng commented on issue #1225: 5.0 configuration issues. URL: https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388774678 Cluster and remote deploy need your real IPs. This is an automated message

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [![Coverage

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187902459 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@

[GitHub] wu-sheng commented on issue #1223: Some doubts about the ui

2018-05-14 Thread GitBox
wu-sheng commented on issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223#issuecomment-388775681 - Sort will optimize in beta. - Please provide more details. - log can be changed. @hanahmily

[GitHub] coveralls commented on issue #1227: Update README.md

2018-05-14 Thread GitBox
coveralls commented on issue #1227: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/1227#issuecomment-388814704 [![Coverage Status](https://coveralls.io/builds/16969049/badge)](https://coveralls.io/builds/16969049) Coverage increased (+0.004%) to

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187964503 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187911664 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962668 ## File path:

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962693 ## File path:

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962693 ## File path:

[GitHub] liliang8858 closed issue #1226: Exception while executing runnable

2018-05-14 Thread GitBox
liliang8858 closed issue #1226: Exception while executing runnable URL: https://github.com/apache/incubator-skywalking/issues/1226 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] wu-sheng closed issue #1222: How do I package the master branch code?

2018-05-14 Thread GitBox
wu-sheng closed issue #1222: How do I package the master branch code? URL: https://github.com/apache/incubator-skywalking/issues/1222 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng closed issue #1225: 5.0 configuration issues.

2018-05-14 Thread GitBox
wu-sheng closed issue #1225: 5.0 configuration issues. URL: https://github.com/apache/incubator-skywalking/issues/1225 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wfs0902 commented on issue #1225: 5.0 configuration issues.

2018-05-14 Thread GitBox
wfs0902 commented on issue #1225: 5.0 configuration issues. URL: https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388770134 The 5.0 operation document is not updated accordingly. This is an automated

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962668 ## File path:

[GitHub] wu-sheng commented on issue #1225: 5.0 configuration issues.

2018-05-14 Thread GitBox
wu-sheng commented on issue #1225: 5.0 configuration issues. URL: https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388770896 Yes, need a 0.0.0.0 by default. Please send a pr to fix. But beta is under release, can't change at this momeny, considering this is a

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388835222 @ascrutae I have changed sofarpc componentId to be 32 This is an

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187968284 ## File path:

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187970209 ## File path:

[GitHub] wu-sheng closed pull request #1227: Update README.md

2018-05-14 Thread GitBox
wu-sheng closed pull request #1227: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/1227 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] wu-sheng commented on issue #1225: 5.0 configuration issues.

2018-05-14 Thread GitBox
wu-sheng commented on issue #1225: 5.0 configuration issues. URL: https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388770896 Yes, need a 0.0.0.0 by default. Please send a pr to fix. But beta is under release, can't change at this momeny, considering this is a

[GitHub] wfs0902 commented on issue #1225: 5.0 configuration issues.

2018-05-14 Thread GitBox
wfs0902 commented on issue #1225: 5.0 configuration issues. URL: https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388773568 Thanks very much for your quick reply,In cluster mode, the IP that all nodes publish is 0.0.0.0, which affects the service load?

[GitHub] wfs0902 commented on issue #1225: 5.0 configuration issues.

2018-05-14 Thread GitBox
wfs0902 commented on issue #1225: 5.0 configuration issues. URL: https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-389006126 Remote use real IP,There is an error,the following "DEBUG 2018-05-15 08:36:36 DiscoveryRestServiceClient : GRPC server list remain

[GitHub] Rainbowboys commented on issue #1223: Some doubts about the ui

2018-05-14 Thread GitBox
Rainbowboys commented on issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223#issuecomment-389014918 ok thanks ! There are some questions ,I know use apm-toolkit-opentracing set up Log and tags,But i when i use apm-toolkit-trace,find it

[GitHub] wu-sheng commented on issue #1228: bug:remote agent.config use real collector IP that happens connection exception

2018-05-14 Thread GitBox
wu-sheng commented on issue #1228: bug:remote agent.config use real collector IP that happens connection exception URL: https://github.com/apache/incubator-skywalking/issues/1228#issuecomment-389024283 All IPs exception UI/Jetty, need to be changed into real IPs.

[GitHub] wu-sheng closed issue #1228: bug:remote agent.config use real collector IP that happens connection exception

2018-05-14 Thread GitBox
wu-sheng closed issue #1228: bug:remote agent.config use real collector IP that happens connection exception URL: https://github.com/apache/incubator-skywalking/issues/1228 This is an automated message from the Apache Git

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r188153469 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@ -98,11

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r188153469 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@ -98,11

[GitHub] wfs0902 opened a new issue #1228: bug:remote agent.config use real collector IP that happens connection exception

2018-05-14 Thread GitBox
wfs0902 opened a new issue #1228: bug:remote agent.config use real collector IP that happens connection exception URL: https://github.com/apache/incubator-skywalking/issues/1228 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ]

[GitHub] wfs0902 commented on issue #1228: bug:remote agent.config use real collector IP that happens connection exception

2018-05-14 Thread GitBox
wfs0902 commented on issue #1228: bug:remote agent.config use real collector IP that happens connection exception URL: https://github.com/apache/incubator-skywalking/issues/1228#issuecomment-389022369 Configure as you say.In collector application.yml, ips use 0.0.0.0 ,remote agent

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [![Coverage

[GitHub] wu-sheng commented on issue #1223: Some doubts about the ui

2018-05-14 Thread GitBox
wu-sheng commented on issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223#issuecomment-389024734 The internal toolkit is only for tag, now. You can send pull request to support log, if you want.