[GitHub] hanahmily commented on issue #1215: No traceId In trace page sometimes

2018-05-20 Thread GitBox
hanahmily commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390524333 There is no `traceId` in response data. Can @peng-yongsheng help to handle this?

[GitHub] hanahmily commented on issue #1188: Span detail in trace view should be in message box

2018-05-20 Thread GitBox
hanahmily commented on issue #1188: Span detail in trace view should be in message box URL: https://github.com/apache/incubator-skywalking/issues/1188#issuecomment-390524674 @wu-sheng I agree with your idea. We should support this feature in next major version which is not 5.0.0.

[GitHub] hanahmily commented on a change in pull request #1240: Add application filter for service and two conditions for trace query.

2018-05-20 Thread GitBox
hanahmily commented on a change in pull request #1240: Add application filter for service and two conditions for trace query. URL: https://github.com/apache/incubator-skywalking/pull/1240#discussion_r189478204 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1240: Add application filter for service and two conditions for trace query.

2018-05-20 Thread GitBox
wu-sheng commented on a change in pull request #1240: Add application filter for service and two conditions for trace query. URL: https://github.com/apache/incubator-skywalking/pull/1240#discussion_r189478383 ## File path:

[GitHub] hanahmily commented on issue #1201: Can't show the detail of Span with empty operation name

2018-05-20 Thread GitBox
hanahmily commented on issue #1201: Can't show the detail of Span with empty operation name URL: https://github.com/apache/incubator-skywalking/issues/1201#issuecomment-390524455 Can you provide some examples? This is an