[GitHub] wu-sheng closed pull request #1249: Provide runtime context.

2018-05-21 Thread GitBox
wu-sheng closed pull request #1249: Provide runtime context. URL: https://github.com/apache/incubator-skywalking/pull/1249 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng opened a new issue #1251: Add sha512 into the release vote mail

2018-05-21 Thread GitBox
wu-sheng opened a new issue #1251: Add sha512 into the release vote mail URL: https://github.com/apache/incubator-skywalking/issues/1251 In the beta release vote: ``` > Release Candidate: > *https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-beta/ I

[GitHub] wu-sheng commented on issue #1240: Add application filter for service and two conditions for trace query.

2018-05-21 Thread GitBox
wu-sheng commented on issue #1240: Add application filter for service and two conditions for trace query. URL: https://github.com/apache/incubator-skywalking/pull/1240#issuecomment-390684847 @peng-yongsheng @hanahmily I wouldn't merge, or try to merge this pr. Please consider this as a

[GitHub] wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span

2018-05-21 Thread GitBox
wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248#issuecomment-390598555 > Now,I have an application and it is slow in some machine, but i don't know which machine, so Do we need add

[GitHub] candyleer opened a new issue #1248: Hope to add hostname or ip to traceSegment or span

2018-05-21 Thread GitBox
candyleer opened a new issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ]

[GitHub] wu-sheng opened a new pull request #1249: Provide runtime context.

2018-05-21 Thread GitBox
wu-sheng opened a new pull request #1249: Provide runtime context. URL: https://github.com/apache/incubator-skywalking/pull/1249 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ]

[GitHub] wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span

2018-05-21 Thread GitBox
wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248#issuecomment-390598792 @hanahmily @peng-yongsheng What do you think about this in beta2? It makes sense in some cases. I am just not sure

[GitHub] ascrutae commented on issue #1249: Provide runtime context.

2018-05-21 Thread GitBox
ascrutae commented on issue #1249: Provide runtime context. URL: https://github.com/apache/incubator-skywalking/pull/1249#issuecomment-390609933 Ref: #1243 This is an automated message from the Apache Git Service. To

[GitHub] candyleer opened a new issue #1250: Dashboard to Service page Error

2018-05-21 Thread GitBox
candyleer opened a new issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ]

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-21 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-390805885 @candyleer Can you provide me your zipkin demo? I will do this in these days.

[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes

2018-05-21 Thread GitBox
candyleer commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390832701 this may caused by `global_trace` not initialized for current trace id ```java traceBrief.getTraces().forEach(trace -> {

[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes

2018-05-21 Thread GitBox
candyleer commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390832701 this may caused by `global_trace` not initialized for current trace id ``` traceBrief.getTraces().forEach(trace -> {

[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes

2018-05-21 Thread GitBox
candyleer commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390836611 the `TraceSegment` save in es, but the `global_trace` is on the way to save to es. so some trace don't have global trace id.

[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes

2018-05-21 Thread GitBox
candyleer commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390836611 the `TraceSegment` saved in es, but the `global_trace` is on the way to save to es. so some trace don't have global trace id.

[GitHub] candyleer commented on issue #1215: No traceId In trace page sometimes

2018-05-21 Thread GitBox
candyleer commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-390836611 the `TraceSegment` saved in es, but the `global_trace` is on the way to save to es. so some trace don't have global trace id.should

[GitHub] candyleer opened a new pull request #1253: fix NPE when has connection exception

2018-05-21 Thread GitBox
candyleer opened a new pull request #1253: fix NPE when has connection exception URL: https://github.com/apache/incubator-skywalking/pull/1253 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided

[GitHub] coveralls commented on issue #1253: Fix NPE in Okhttp plugin when connect failed

2018-05-21 Thread GitBox
coveralls commented on issue #1253: Fix NPE in Okhttp plugin when connect failed URL: https://github.com/apache/incubator-skywalking/pull/1253#issuecomment-390867553 [![Coverage Status](https://coveralls.io/builds/17099260/badge)](https://coveralls.io/builds/17099260) Coverage

[GitHub] wu-sheng opened a new issue #1244: Consider to use the released version of org.apache.skywalking:apm-checkstyle

2018-05-21 Thread GitBox
wu-sheng opened a new issue #1244: Consider to use the released version of org.apache.skywalking:apm-checkstyle URL: https://github.com/apache/incubator-skywalking/issues/1244 In the beta release vote: ``` +0 mvn clean package mostly builds (see below) build fails in

[GitHub] wu-sheng opened a new issue #1246: Add `re-tag` step in release document

2018-05-21 Thread GitBox
wu-sheng opened a new issue #1246: Add `re-tag` step in release document URL: https://github.com/apache/incubator-skywalking/issues/1246 In the beta release vote: ``` > Release Tag : > * v5.0.0-beta Should be v5.0.0-beta-RC1 (or later) while under vote, and then re-tagged

[GitHub] wu-sheng closed issue #1239: file name too long on windows7 when i checkout 5.0.0-beta

2018-05-21 Thread GitBox
wu-sheng closed issue #1239: file name too long on windows7 when i checkout 5.0.0-beta URL: https://github.com/apache/incubator-skywalking/issues/1239 This is an automated message from the Apache Git Service. To respond to

[GitHub] wu-sheng commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta

2018-05-21 Thread GitBox
wu-sheng commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta URL: https://github.com/apache/incubator-skywalking/issues/1239#issuecomment-390590017 @leilianjie I am closing this. Run some search in Baidu or Google. There should be some solution for this.

[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring

2018-05-21 Thread GitBox
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-390590807 @candyleer @ascrutae I have just understood Hytrix 's way. Look like the only way to support is, providing three segments for incoming

[GitHub] wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span

2018-05-21 Thread GitBox
wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span URL: https://github.com/apache/incubator-skywalking/issues/1200#issuecomment-390591290 I will remove the milestone, I have finish some prototype codes of this(branch manual-span), also make context-switchable(branch

[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-21 Thread GitBox
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390821301 @SevenPointOld Could you finish this PR soon? I look forward to merge this pr into beta2 release.